You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/04/04 15:17:56 UTC

[GitHub] [nifi] guvencenanguvenal opened a new pull request #4183: NIFI-7176

guvencenanguvenal opened a new pull request #4183: NIFI-7176
URL: https://github.com/apache/nifi/pull/4183
 
 
   -okhttp client update version
   -read timeout supported expression value from flowfile and variables. (support different timeout value for each request)
   -connection timeout supported expression value from variables 
   -based on updated master(my previous PR is not ok to merge)
   
   Thank you for your review.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [nifi] alopresto commented on a change in pull request #4183: NIFI-7176 - InvokeHTTP - timeout supported expression language

Posted by GitBox <gi...@apache.org>.
alopresto commented on a change in pull request #4183: NIFI-7176 - InvokeHTTP - timeout supported expression language
URL: https://github.com/apache/nifi/pull/4183#discussion_r403541877
 
 

 ##########
 File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/InvokeHTTP.java
 ##########
 @@ -638,8 +637,12 @@ public void setUpClient(final ProcessContext context) throws IOException, Unreco
         }
 
         // Set timeouts
-        okHttpClientBuilder.connectTimeout((context.getProperty(PROP_CONNECT_TIMEOUT).asTimePeriod(TimeUnit.MILLISECONDS).intValue()), TimeUnit.MILLISECONDS);
-        okHttpClientBuilder.readTimeout(context.getProperty(PROP_READ_TIMEOUT).asTimePeriod(TimeUnit.MILLISECONDS).intValue(), TimeUnit.MILLISECONDS);
+        okHttpClientBuilder.connectTimeout((context.getProperty(PROP_CONNECT_TIMEOUT).evaluateAttributeExpressions().asTimePeriod(TimeUnit.MILLISECONDS).intValue()), TimeUnit.MILLISECONDS);
+
+        if (context.getProperty(PROP_READ_TIMEOUT).isExpressionLanguagePresent())
+            okHttpClientBuilder.addInterceptor(new TimeoutInterceptor());
 
 Review comment:
   Can you explain why an interceptor is added here rather than passing the configured value to the builder?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [nifi] guvencenanguvenal commented on a change in pull request #4183: NIFI-7176 - InvokeHTTP - timeout supported expression language

Posted by GitBox <gi...@apache.org>.
guvencenanguvenal commented on a change in pull request #4183: NIFI-7176 - InvokeHTTP - timeout supported expression language
URL: https://github.com/apache/nifi/pull/4183#discussion_r403754382
 
 

 ##########
 File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/InvokeHTTP.java
 ##########
 @@ -66,14 +66,8 @@
 import javax.net.ssl.TrustManager;
 import javax.net.ssl.TrustManagerFactory;
 import javax.net.ssl.X509TrustManager;
-import okhttp3.Cache;
-import okhttp3.Credentials;
-import okhttp3.MediaType;
-import okhttp3.OkHttpClient;
-import okhttp3.Request;
-import okhttp3.RequestBody;
-import okhttp3.Response;
-import okhttp3.ResponseBody;
+
+import okhttp3.*;
 
 Review comment:
   First of all thanks for your review and sorry for my english spelling. you are right, It was auto import with shortcut. I fix it. I download checkstyle.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [nifi] alopresto commented on issue #4183: NIFI-7176 - InvokeHTTP - timeout supported expression language

Posted by GitBox <gi...@apache.org>.
alopresto commented on issue #4183: NIFI-7176 - InvokeHTTP - timeout supported expression language
URL: https://github.com/apache/nifi/pull/4183#issuecomment-609096836
 
 
   Thanks for your first contribution to the project. I have added some questions/comments. There is a template in the PR request which describes basic contribution requirements and expectations, but this seems to be missing. In addition, 3 of the 4 CI checks are failing. Were you able to build the complete project locally with tests and checkstyle passing before submitting the PR?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [nifi] guvencenanguvenal commented on a change in pull request #4183: NIFI-7176 - InvokeHTTP - timeout supported expression language

Posted by GitBox <gi...@apache.org>.
guvencenanguvenal commented on a change in pull request #4183: NIFI-7176 - InvokeHTTP - timeout supported expression language
URL: https://github.com/apache/nifi/pull/4183#discussion_r406519400
 
 

 ##########
 File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/InvokeHTTP.java
 ##########
 @@ -638,8 +637,12 @@ public void setUpClient(final ProcessContext context) throws IOException, Unreco
         }
 
         // Set timeouts
-        okHttpClientBuilder.connectTimeout((context.getProperty(PROP_CONNECT_TIMEOUT).asTimePeriod(TimeUnit.MILLISECONDS).intValue()), TimeUnit.MILLISECONDS);
-        okHttpClientBuilder.readTimeout(context.getProperty(PROP_READ_TIMEOUT).asTimePeriod(TimeUnit.MILLISECONDS).intValue(), TimeUnit.MILLISECONDS);
+        okHttpClientBuilder.connectTimeout((context.getProperty(PROP_CONNECT_TIMEOUT).evaluateAttributeExpressions().asTimePeriod(TimeUnit.MILLISECONDS).intValue()), TimeUnit.MILLISECONDS);
+
+        if (context.getProperty(PROP_READ_TIMEOUT).isExpressionLanguagePresent())
+            okHttpClientBuilder.addInterceptor(new TimeoutInterceptor());
 
 Review comment:
   This interceptor set timeout for every request(if timeout is a expression language). Timeout value is different for every request so i think there is no reason to initialize.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [nifi] alopresto commented on a change in pull request #4183: NIFI-7176 - InvokeHTTP - timeout supported expression language

Posted by GitBox <gi...@apache.org>.
alopresto commented on a change in pull request #4183: NIFI-7176 - InvokeHTTP - timeout supported expression language
URL: https://github.com/apache/nifi/pull/4183#discussion_r403540675
 
 

 ##########
 File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/InvokeHTTP.java
 ##########
 @@ -66,14 +66,8 @@
 import javax.net.ssl.TrustManager;
 import javax.net.ssl.TrustManagerFactory;
 import javax.net.ssl.X509TrustManager;
-import okhttp3.Cache;
-import okhttp3.Credentials;
-import okhttp3.MediaType;
-import okhttp3.OkHttpClient;
-import okhttp3.Request;
-import okhttp3.RequestBody;
-import okhttp3.Response;
-import okhttp3.ResponseBody;
+
+import okhttp3.*;
 
 Review comment:
   Our checkstyle prohibits wildcard imports. You can download the checkstyle definitions for your IDE from the [Contributor Guide](https://cwiki.apache.org/confluence/display/NIFI/Contributor+Guide) and run the Maven build locally with `-Pcontrib-check` to see and resolve any issues. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [nifi] guvencenanguvenal commented on issue #4183: NIFI-7176 - InvokeHTTP - timeout supported expression language

Posted by GitBox <gi...@apache.org>.
guvencenanguvenal commented on issue #4183: NIFI-7176 - InvokeHTTP - timeout supported expression language
URL: https://github.com/apache/nifi/pull/4183#issuecomment-611793525
 
 
   > Thanks for your first contribution to the project. I have added some questions/comments. There is a template in the PR request which describes basic contribution requirements and expectations, but this seems to be missing. In addition, 3 of the 4 CI checks are failing. Were you able to build the complete project locally with tests and checkstyle passing before submitting the PR?
   
   Thanks for your review. I build project locally. Especially i build nifi-standard-nar.jar and add my local nifi than start and test with my flow for all cases. 
   
   I run checkstyle on project and there is no error.
   
   I dont know why checks are failing because i check logs and it doesn't depend with my commits.
   
   [ERROR] Failed to execute goal on project nifi-splunk-processors: Could not resolve dependencies for project org.apache.nifi:nifi-splunk-processors:jar:1.12.0-SNAPSHOT: Could not find artifact com.splunk:splunk:jar:1.6.5.0 in splunk (https://splunk.artifactoryonline.com/splunk/ext-releases-local/) -> [Help 1]

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [nifi] alopresto commented on a change in pull request #4183: NIFI-7176 - InvokeHTTP - timeout supported expression language

Posted by GitBox <gi...@apache.org>.
alopresto commented on a change in pull request #4183: NIFI-7176 - InvokeHTTP - timeout supported expression language
URL: https://github.com/apache/nifi/pull/4183#discussion_r403540955
 
 

 ##########
 File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/InvokeHTTP.java
 ##########
 @@ -120,20 +115,20 @@
 @CapabilityDescription("An HTTP client processor which can interact with a configurable HTTP Endpoint. The destination URL and HTTP Method are configurable."
     + " FlowFile attributes are converted to HTTP headers and the FlowFile contents are included as the body of the request (if the HTTP Method is PUT, POST or PATCH).")
 @WritesAttributes({
-    @WritesAttribute(attribute = "invokehttp.status.code", description = "The status code that is returned"),
-    @WritesAttribute(attribute = "invokehttp.status.message", description = "The status message that is returned"),
-    @WritesAttribute(attribute = "invokehttp.response.body", description = "In the instance where the status code received is not a success (2xx) "
-        + "then the response body will be put to the 'invokehttp.response.body' attribute of the request FlowFile."),
-    @WritesAttribute(attribute = "invokehttp.request.url", description = "The request URL"),
-    @WritesAttribute(attribute = "invokehttp.tx.id", description = "The transaction ID that is returned after reading the response"),
-    @WritesAttribute(attribute = "invokehttp.remote.dn", description = "The DN of the remote server"),
-    @WritesAttribute(attribute = "invokehttp.java.exception.class", description = "The Java exception class raised when the processor fails"),
-    @WritesAttribute(attribute = "invokehttp.java.exception.message", description = "The Java exception message raised when the processor fails"),
-    @WritesAttribute(attribute = "user-defined", description = "If the 'Put Response Body In Attribute' property is set then whatever it is set to "
-        + "will become the attribute key and the value would be the body of the HTTP response.")})
+        @WritesAttribute(attribute = "invokehttp.status.code", description = "The status code that is returned"),
+        @WritesAttribute(attribute = "invokehttp.status.message", description = "The status message that is returned"),
+        @WritesAttribute(attribute = "invokehttp.response.body", description = "In the instance where the status code received is not a success (2xx) "
+                + "then the response body will be put to the 'invokehttp.response.body' attribute of the request FlowFile."),
+        @WritesAttribute(attribute = "invokehttp.request.url", description = "The request URL"),
+        @WritesAttribute(attribute = "invokehttp.tx.id", description = "The transaction ID that is returned after reading the response"),
+        @WritesAttribute(attribute = "invokehttp.remote.dn", description = "The DN of the remote server"),
+        @WritesAttribute(attribute = "invokehttp.java.exception.class", description = "The Java exception class raised when the processor fails"),
+        @WritesAttribute(attribute = "invokehttp.java.exception.message", description = "The Java exception message raised when the processor fails"),
+        @WritesAttribute(attribute = "user-defined", description = "If the 'Put Response Body In Attribute' property is set then whatever it is set to "
+                + "will become the attribute key and the value would be the body of the HTTP response.")})
 
 Review comment:
   I think your IDE is making whitespace changes here as well. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [nifi] guvencenanguvenal commented on a change in pull request #4183: NIFI-7176 - InvokeHTTP - timeout supported expression language

Posted by GitBox <gi...@apache.org>.
guvencenanguvenal commented on a change in pull request #4183: NIFI-7176 - InvokeHTTP - timeout supported expression language
URL: https://github.com/apache/nifi/pull/4183#discussion_r403757866
 
 

 ##########
 File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/InvokeHTTP.java
 ##########
 @@ -187,6 +182,7 @@
             .description("Max wait time for connection to remote service.")
             .required(true)
             .defaultValue("5 secs")
+            .expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY)
 
 Review comment:
   READ_TIMEOUT and CONNECTION_TIMEOUT are initialized before onTrigger method.
   
   I think CONNECTION_TIMEOUT might be static for every request so i use only VARIABLE_REGISTRY for this property because of i mentioned above, but READ_TIMEOUT should be different for every single request so I use FLOWFILE_REGISTRY for this property.
   
   I assign READ_TIMEOUT value via interceptor(TimeoutInterceptor) on onTrigger method because okHttpClient does not allow to change timeout parameter.
   
   I don't mark as resolved. If i have a wrong information please send comment.
   
   Thank you.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [nifi] guvencenanguvenal commented on a change in pull request #4183: NIFI-7176 - InvokeHTTP - timeout supported expression language

Posted by GitBox <gi...@apache.org>.
guvencenanguvenal commented on a change in pull request #4183: NIFI-7176 - InvokeHTTP - timeout supported expression language
URL: https://github.com/apache/nifi/pull/4183#discussion_r403754160
 
 

 ##########
 File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/InvokeHTTP.java
 ##########
 @@ -120,20 +115,20 @@
 @CapabilityDescription("An HTTP client processor which can interact with a configurable HTTP Endpoint. The destination URL and HTTP Method are configurable."
     + " FlowFile attributes are converted to HTTP headers and the FlowFile contents are included as the body of the request (if the HTTP Method is PUT, POST or PATCH).")
 @WritesAttributes({
-    @WritesAttribute(attribute = "invokehttp.status.code", description = "The status code that is returned"),
-    @WritesAttribute(attribute = "invokehttp.status.message", description = "The status message that is returned"),
-    @WritesAttribute(attribute = "invokehttp.response.body", description = "In the instance where the status code received is not a success (2xx) "
-        + "then the response body will be put to the 'invokehttp.response.body' attribute of the request FlowFile."),
-    @WritesAttribute(attribute = "invokehttp.request.url", description = "The request URL"),
-    @WritesAttribute(attribute = "invokehttp.tx.id", description = "The transaction ID that is returned after reading the response"),
-    @WritesAttribute(attribute = "invokehttp.remote.dn", description = "The DN of the remote server"),
-    @WritesAttribute(attribute = "invokehttp.java.exception.class", description = "The Java exception class raised when the processor fails"),
-    @WritesAttribute(attribute = "invokehttp.java.exception.message", description = "The Java exception message raised when the processor fails"),
-    @WritesAttribute(attribute = "user-defined", description = "If the 'Put Response Body In Attribute' property is set then whatever it is set to "
-        + "will become the attribute key and the value would be the body of the HTTP response.")})
+        @WritesAttribute(attribute = "invokehttp.status.code", description = "The status code that is returned"),
+        @WritesAttribute(attribute = "invokehttp.status.message", description = "The status message that is returned"),
+        @WritesAttribute(attribute = "invokehttp.response.body", description = "In the instance where the status code received is not a success (2xx) "
+                + "then the response body will be put to the 'invokehttp.response.body' attribute of the request FlowFile."),
+        @WritesAttribute(attribute = "invokehttp.request.url", description = "The request URL"),
+        @WritesAttribute(attribute = "invokehttp.tx.id", description = "The transaction ID that is returned after reading the response"),
+        @WritesAttribute(attribute = "invokehttp.remote.dn", description = "The DN of the remote server"),
+        @WritesAttribute(attribute = "invokehttp.java.exception.class", description = "The Java exception class raised when the processor fails"),
+        @WritesAttribute(attribute = "invokehttp.java.exception.message", description = "The Java exception message raised when the processor fails"),
+        @WritesAttribute(attribute = "user-defined", description = "If the 'Put Response Body In Attribute' property is set then whatever it is set to "
+                + "will become the attribute key and the value would be the body of the HTTP response.")})
 
 Review comment:
   First of all thanks for your review and sorry for my english spelling. you are right, It was auto import with shortcut. I fix it. I download checkstyle.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [nifi] alopresto commented on a change in pull request #4183: NIFI-7176 - InvokeHTTP - timeout supported expression language

Posted by GitBox <gi...@apache.org>.
alopresto commented on a change in pull request #4183: NIFI-7176 - InvokeHTTP - timeout supported expression language
URL: https://github.com/apache/nifi/pull/4183#discussion_r403541321
 
 

 ##########
 File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/InvokeHTTP.java
 ##########
 @@ -187,6 +182,7 @@
             .description("Max wait time for connection to remote service.")
             .required(true)
             .defaultValue("5 secs")
+            .expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY)
 
 Review comment:
   Is there a reason this property descriptor will only support variable registry values rather than flowfile attributes as done in `PROP_READ_TIMEOUT`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [nifi] guvencenanguvenal commented on a change in pull request #4183: NIFI-7176 - InvokeHTTP - timeout supported expression language

Posted by GitBox <gi...@apache.org>.
guvencenanguvenal commented on a change in pull request #4183: NIFI-7176 - InvokeHTTP - timeout supported expression language
URL: https://github.com/apache/nifi/pull/4183#discussion_r403754446
 
 

 ##########
 File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/InvokeHTTP.java
 ##########
 @@ -120,20 +115,20 @@
 @CapabilityDescription("An HTTP client processor which can interact with a configurable HTTP Endpoint. The destination URL and HTTP Method are configurable."
     + " FlowFile attributes are converted to HTTP headers and the FlowFile contents are included as the body of the request (if the HTTP Method is PUT, POST or PATCH).")
 @WritesAttributes({
-    @WritesAttribute(attribute = "invokehttp.status.code", description = "The status code that is returned"),
-    @WritesAttribute(attribute = "invokehttp.status.message", description = "The status message that is returned"),
-    @WritesAttribute(attribute = "invokehttp.response.body", description = "In the instance where the status code received is not a success (2xx) "
-        + "then the response body will be put to the 'invokehttp.response.body' attribute of the request FlowFile."),
-    @WritesAttribute(attribute = "invokehttp.request.url", description = "The request URL"),
-    @WritesAttribute(attribute = "invokehttp.tx.id", description = "The transaction ID that is returned after reading the response"),
-    @WritesAttribute(attribute = "invokehttp.remote.dn", description = "The DN of the remote server"),
-    @WritesAttribute(attribute = "invokehttp.java.exception.class", description = "The Java exception class raised when the processor fails"),
-    @WritesAttribute(attribute = "invokehttp.java.exception.message", description = "The Java exception message raised when the processor fails"),
-    @WritesAttribute(attribute = "user-defined", description = "If the 'Put Response Body In Attribute' property is set then whatever it is set to "
-        + "will become the attribute key and the value would be the body of the HTTP response.")})
+        @WritesAttribute(attribute = "invokehttp.status.code", description = "The status code that is returned"),
+        @WritesAttribute(attribute = "invokehttp.status.message", description = "The status message that is returned"),
+        @WritesAttribute(attribute = "invokehttp.response.body", description = "In the instance where the status code received is not a success (2xx) "
+                + "then the response body will be put to the 'invokehttp.response.body' attribute of the request FlowFile."),
+        @WritesAttribute(attribute = "invokehttp.request.url", description = "The request URL"),
+        @WritesAttribute(attribute = "invokehttp.tx.id", description = "The transaction ID that is returned after reading the response"),
+        @WritesAttribute(attribute = "invokehttp.remote.dn", description = "The DN of the remote server"),
+        @WritesAttribute(attribute = "invokehttp.java.exception.class", description = "The Java exception class raised when the processor fails"),
+        @WritesAttribute(attribute = "invokehttp.java.exception.message", description = "The Java exception message raised when the processor fails"),
+        @WritesAttribute(attribute = "user-defined", description = "If the 'Put Response Body In Attribute' property is set then whatever it is set to "
+                + "will become the attribute key and the value would be the body of the HTTP response.")})
 
 Review comment:
   Yes, IDE did this :) (IntelliJ CE 2019.3)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [nifi] guvencenanguvenal commented on a change in pull request #4183: NIFI-7176 - InvokeHTTP - timeout supported expression language

Posted by GitBox <gi...@apache.org>.
guvencenanguvenal commented on a change in pull request #4183: NIFI-7176 - InvokeHTTP - timeout supported expression language
URL: https://github.com/apache/nifi/pull/4183#discussion_r403754160
 
 

 ##########
 File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/InvokeHTTP.java
 ##########
 @@ -120,20 +115,20 @@
 @CapabilityDescription("An HTTP client processor which can interact with a configurable HTTP Endpoint. The destination URL and HTTP Method are configurable."
     + " FlowFile attributes are converted to HTTP headers and the FlowFile contents are included as the body of the request (if the HTTP Method is PUT, POST or PATCH).")
 @WritesAttributes({
-    @WritesAttribute(attribute = "invokehttp.status.code", description = "The status code that is returned"),
-    @WritesAttribute(attribute = "invokehttp.status.message", description = "The status message that is returned"),
-    @WritesAttribute(attribute = "invokehttp.response.body", description = "In the instance where the status code received is not a success (2xx) "
-        + "then the response body will be put to the 'invokehttp.response.body' attribute of the request FlowFile."),
-    @WritesAttribute(attribute = "invokehttp.request.url", description = "The request URL"),
-    @WritesAttribute(attribute = "invokehttp.tx.id", description = "The transaction ID that is returned after reading the response"),
-    @WritesAttribute(attribute = "invokehttp.remote.dn", description = "The DN of the remote server"),
-    @WritesAttribute(attribute = "invokehttp.java.exception.class", description = "The Java exception class raised when the processor fails"),
-    @WritesAttribute(attribute = "invokehttp.java.exception.message", description = "The Java exception message raised when the processor fails"),
-    @WritesAttribute(attribute = "user-defined", description = "If the 'Put Response Body In Attribute' property is set then whatever it is set to "
-        + "will become the attribute key and the value would be the body of the HTTP response.")})
+        @WritesAttribute(attribute = "invokehttp.status.code", description = "The status code that is returned"),
+        @WritesAttribute(attribute = "invokehttp.status.message", description = "The status message that is returned"),
+        @WritesAttribute(attribute = "invokehttp.response.body", description = "In the instance where the status code received is not a success (2xx) "
+                + "then the response body will be put to the 'invokehttp.response.body' attribute of the request FlowFile."),
+        @WritesAttribute(attribute = "invokehttp.request.url", description = "The request URL"),
+        @WritesAttribute(attribute = "invokehttp.tx.id", description = "The transaction ID that is returned after reading the response"),
+        @WritesAttribute(attribute = "invokehttp.remote.dn", description = "The DN of the remote server"),
+        @WritesAttribute(attribute = "invokehttp.java.exception.class", description = "The Java exception class raised when the processor fails"),
+        @WritesAttribute(attribute = "invokehttp.java.exception.message", description = "The Java exception message raised when the processor fails"),
+        @WritesAttribute(attribute = "user-defined", description = "If the 'Put Response Body In Attribute' property is set then whatever it is set to "
+                + "will become the attribute key and the value would be the body of the HTTP response.")})
 
 Review comment:
   First of all thanks for your review and sorry for my english spelling. you are right, It was auto import with shortcut. I fix it. I download checkstyle.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services