[jira] [Commented] (CAMEL-6819) Use exceptionHandler on Xmpp Consumer

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CAMEL-6819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13996862#comment-13996862 ] 

ASF GitHub Bot commented on CAMEL-6819:
---------------------------------------

GitHub user ancosen opened a pull request:

    https://github.com/apache/camel/pull/150

    [CAMEL-6819] Use exceptionHandler on Xmpp Consumer

    Hi
    
    I've just added the idea of  bounkong khamphousone of CAMEL-6819 issue.
    
    Just one new row.
    
    Bye.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ancosen/camel camel-6819-exceptionhandler

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/camel/pull/150.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #150
    
----
commit 7b96bde38f16b4c42af543d9a3d4b94913af26f3
Author: ancosen <an...@gmail.com>
Date:   2014-05-09T10:06:02Z

    Added new Properties Component Test related to concatenation of properties. First test fails because of unsupported parsing properties.

commit 8fe696c02738baaf4d299a01386a4018c1e0c6e4
Author: ancosen <an...@gmail.com>
Date:   2014-05-09T10:14:56Z

    Reload Pom.xml

commit 6e59877da99ef208e699284c05221f0c318e1c33
Author: ancosen <an...@gmail.com>
Date:   2014-05-10T15:48:13Z

    Fixes Camel-6716: ServiceInterfaceStrategy fails to create with interface containing multiple methods without parameters

commit 15d292318be916335abc4092c5c3346a5cfce813
Author: ancosen <an...@gmail.com>
Date:   2014-05-11T12:56:56Z

    Merge remote-tracking branch 'upstream/master'

commit 7be3571a3f252e3bb33862be2e6e79da3531feed
Author: ancosen <an...@gmail.com>
Date:   2014-05-11T13:36:47Z

    Rebase master

commit 9fda7e3486e789485969ad4ac09128fc717235ff
Author: ancosen <an...@gmail.com>
Date:   2014-05-11T13:38:50Z

    Remove test class

commit 93993afaf5d095669db9254b41453cb8a034dfe2
Author: ancosen <an...@gmail.com>
Date:   2014-05-13T20:27:14Z

    Fixes CAMEL-6819 Use exceptionHandler on Xmpp Consumer

----


> Use exceptionHandler on Xmpp Consumer
> -------------------------------------
>
>                 Key: CAMEL-6819
>                 URL: https://issues.apache.org/jira/browse/CAMEL-6819
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-xmpp
>    Affects Versions: 2.12.1
>         Environment: all
>            Reporter: bounkong khamphousone
>            Priority: Minor
>
> Hi!
> What do you think about adding a call to the exceptionHandler in the doStart() method of XmppConsumer class ?
> It would looks like : 
> try {
>             connection = endpoint.createConnection();
>         } catch (XMPPException e) {
>             if (endpoint.isTestConnectionOnStartup()) {
>                 throw new RuntimeException("Could not connect to XMPP server.", e);
>             }  else {
>             	final String xmppExceptionLogMessage = XmppEndpoint.getXmppExceptionLogMessage(e);
>                 LOG.warn(xmppExceptionLogMessage);
>                 getExceptionHandler().handleException(xmppExceptionLogMessage,e);
>                 scheduleDelayedStart();
>                 return;
>             }
>         }
> This allowed an exceptionHandler to be notified of failure connection.
> The testConnectionOnStartup doesn't call exceptionHandler because the exception is thrown while starting the consumer.



--
This message was sent by Atlassian JIRA
(v6.2#6252)