[jira] [Commented] (HADOOP-15875) S3AInputStream.seek should throw EOFException if seeking past the end of file

["Steve Loughran (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-15875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16662472#comment-16662472 ] 

Steve Loughran commented on HADOOP-15875:
-----------------------------------------

Doesn't it do this? I guess with lazy seek it might be postponing the check until the first read()

seek() is a special case: https://hadoop.apache.org/docs/stable/hadoop-project-dist/hadoop-common/filesystem/fsdatainputstream.html#Seekable.seeks

Posix filesystems don't fail on the seek() either, because you are allowed to append beyond the EOF. There's also the fact that the EOF can move about dynamically.

Which means: you can't rely on seek failing if you go past the EOF, even though HDFS does.

I'll take a patch (which will have to change the s3a.xml contract options), but it's not something I view as that significant precisely because it's consistent with posix 

> S3AInputStream.seek should throw EOFException if seeking past the end of file
> -----------------------------------------------------------------------------
>
>                 Key: HADOOP-15875
>                 URL: https://issues.apache.org/jira/browse/HADOOP-15875
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3
>    Affects Versions: 3.2.0
>            Reporter: Shixiong Zhu
>            Priority: Major
>
> I read the javadoc of `Seekable.seek` but it doesn't say what should be done when seeking past the end of file. Right now, DFSInputStream throws new EOFException, but S3AInputStream doesn't throw any error.
> I think it's better to have consistent behavior in `seek.`



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org