You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2022/03/09 06:09:11 UTC

[GitHub] [druid] jihoonson opened a new pull request #12322: Git hooks should fail on errors; pass args to git hooks

jihoonson opened a new pull request #12322:
URL: https://github.com/apache/druid/pull/12322


   ### Description
   
   Fixes two bugs in the script added in #12300. 
   
   - It should fail when one of the scripts it calls fails.
   - Arguments should pass to the script especially when it is called in the `pre-push` hook.
   
   <hr>
   
   This PR has:
   - [x] been self-reviewed.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org

[GitHub] [druid] jihoonson commented on pull request #12322: Git hooks should fail on errors; pass args to git hooks

Posted by GitBox <gi...@apache.org>.
jihoonson commented on pull request #12322:
URL: https://github.com/apache/druid/pull/12322#issuecomment-1063503520


   Thanks @maytasm for the review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org

[GitHub] [druid] jihoonson merged pull request #12322: Git hooks should fail on errors; pass args to git hooks

Posted by GitBox <gi...@apache.org>.
jihoonson merged pull request #12322:
URL: https://github.com/apache/druid/pull/12322


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org