You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jetspeed-dev@portals.apache.org by "Weaver, Scott" <Sw...@rippe.com> on 2002/07/19 19:14:42 UTC
RE: [PATCH] Fixed tabs not always rendering based on the "positio
n" attribute
David,
Hi David,
I have another patch for VelocityPortletSetControl that correctly implements the new Jetspeed security over tabs. However, the patch shows changes from the previous patch I submitted.
Scott
> -----Original Message-----
> From: David Sean Taylor [mailto:david@bluesunrise.com]
> Sent: Friday, July 19, 2002 11:50 AM
> To: Jetspeed Developers List
> Subject: RE: [PATCH] Fixed tabs not always rendering based on the
> "position" attribute
>
> Patched. Thanks Scott.
> -----Original Message-----
> From: Weaver, Scott [mailto:Sweaver@rippe.com]
> Sent: Thursday, July 18, 2002 2:36 PM
> To: 'Jetspeed Developers List'
> Subject: [PATCH] Fixed tabs not always rendering based on the "position"
> attribute
>
>
> I noticed, with moderate re-ordering, that the tab order did not always
> reflect that of the psml file. I have 5 tabs, and they did not always
> come
> out in the order that they should have after re-ordering through the
> layout
> customizer. However, all my tabs were always ordered correctly within
> the
> layout customizer.
>
>
>
> By adding the PortletTabs created within VelocityPortletSetControl to
> TreeSet rather than a Vector and using a custom comparator,
> PortletTabComparator, to order the TreeSet, my tabs are now ordered
> correctly 100% of the time.
>
>
>
> This may be more of an issue with the way BasePortletSet is handling
> portlets, however this fix works pretty well and was easy to implement.
>
>
>
> Scott
RE: [PATCH] Fixed tabs not always rendering based on the "position" attribute
Posted by David Sean Taylor <da...@bluesunrise.com>.
RE: [PATCH] Fixed tabs not always rendering based on the "position"
attributeScott,
Would it be too much trouble to apply the patch to the current cvs?
Thanks,
David
-----Original Message-----
From: Weaver, Scott [mailto:Sweaver@rippe.com]
Sent: Friday, July 19, 2002 10:15 AM
To: 'Jetspeed Developers List'
Subject: RE: [PATCH] Fixed tabs not always rendering based on the
"position" attribute
David,
Hi David,
I have another patch for VelocityPortletSetControl that correctly
implements the new Jetspeed security over tabs. However, the patch shows
changes from the previous patch I submitted.
Scott
> -----Original Message-----
> From: David Sean Taylor [mailto:david@bluesunrise.com]
> Sent: Friday, July 19, 2002 11:50 AM
> To: Jetspeed Developers List
> Subject: RE: [PATCH] Fixed tabs not always rendering based on the
> "position" attribute
>
> Patched. Thanks Scott.
> -----Original Message-----
> From: Weaver, Scott [mailto:Sweaver@rippe.com]
> Sent: Thursday, July 18, 2002 2:36 PM
> To: 'Jetspeed Developers List'
> Subject: [PATCH] Fixed tabs not always rendering based on the
"position"
> attribute
>
>
> I noticed, with moderate re-ordering, that the tab order did not
always
> reflect that of the psml file. I have 5 tabs, and they did not always
> come
> out in the order that they should have after re-ordering through the
> layout
> customizer. However, all my tabs were always ordered correctly within
> the
> layout customizer.
>
>
>
> By adding the PortletTabs created within VelocityPortletSetControl to
> TreeSet rather than a Vector and using a custom comparator,
> PortletTabComparator, to order the TreeSet, my tabs are now ordered
> correctly 100% of the time.
>
>
>
> This may be more of an issue with the way BasePortletSet is handling
> portlets, however this fix works pretty well and was easy to implement.
>
>
>
> Scott