[jira] [Comment Edited] (ZOOKEEPER-2579) ZooKeeper server should verify that dataDir and snapDir are writeable before starting

["Abraham Fine (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15494457#comment-15494457 ] 

Abraham Fine edited comment on ZOOKEEPER-2579 at 9/15/16 8:42 PM:
------------------------------------------------------------------

[~eribeiro] Thanks for the feedback. 

The reason that I went with the more brittle test that involves checking to see if the server starts up is because I felt that type of test better verifies the behavior that I wanted to achieve with this jira. The tests that I wrote verify that incorrect permissioning prevents the server from starting, as opposed to just verifying the behavior of the FileTxnLog (we do something similar with testWithoutAutoCreateDataLogDir).

I guess it would be reasonable to say that the tests that I wrote are more like integration tests while the tests that you attached are true unit tests. I guess it could be argued that most of the tests in ZooKeeperServerMainTest are really integration tests.

It would be possible to include both types of test instead of needing to choose. What do you think?




was (Author: abrahamfine):
[~eribeiro] Thanks for the feedback. 

The reason that I went with the more brittle test that involves checking to see if the server starts up is because I felt that type of test better verifies the behavior that I wanted to achieve with this jira. The tests that I wrote verify that incorrect permissioning prevents the server from starting, as opposed to just verifying the behavior of the FileTxnLog.

I guess it would be reasonable to say that the tests that I wrote are more like integration tests while the tests that you attached are true unit tests. I guess it could be argued that most of the tests in ZooKeeperServerMainTest are really integration tests.

It would be possible to include both types of test instead of needing to choose. What do you think?



> ZooKeeper server should verify that dataDir and snapDir are writeable before starting
> -------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-2579
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2579
>             Project: ZooKeeper
>          Issue Type: Bug
>    Affects Versions: 3.4.9, 3.5.2
>            Reporter: Abraham Fine
>            Assignee: Abraham Fine
>             Fix For: 3.4.10, 3.5.3
>
>         Attachments: FileTxnSnapLogTest.java, ZOOKEEPER-2579.patch, ZOOKEEPER-2579_3.4.patch
>
>
> If the directories specified for the dataDir or the snapDir are not writeable, the server does not fail until it actually tries to write there. It should fail when it starts.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)