You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "dpogue (via GitHub)" <gi...@apache.org> on 2026/03/11 16:33:43 UTC
[PR] chore: Bump patch level for ongoing dev work [cordova-ios]
dpogue opened a new pull request, #1633:
URL: https://github.com/apache/cordova-ios/pull/1633
### Platforms affected
iOS
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
Bump version to reflect that ongoing work is for a future release
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] chore: Bump patch level for ongoing dev work [cordova-ios]
Posted by "GitToTheHub (via GitHub)" <gi...@apache.org>.
GitToTheHub commented on PR #1633:
URL: https://github.com/apache/cordova-ios/pull/1633#issuecomment-4040550843
Uups, did I merge to early #1631? I see you added the milestone 8.1.0. I think this wrong, sorry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] chore: Bump patch level for ongoing dev work [cordova-ios]
Posted by "erisu (via GitHub)" <gi...@apache.org>.
erisu commented on PR #1633:
URL: https://github.com/apache/cordova-ios/pull/1633#issuecomment-4040617589
> Uups, did I merge to early https://github.com/apache/cordova-ios/issues/1631? I see you added the milestone 8.1.0. I think this was wrong, sorry.
Also, I think in this case it might not be an issue, since the PR was a fix that could technically go into a patch release. So if the vote did fail, it could simply be included in the next submission.
> or we could re-tag 8.0.1 off the 8.0.x branch.
I haven’t personally done this before, but I believe it should also be possible. Technically, if we needed to release an older major version, I believe it would have to be based on its feature branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] chore: Bump patch level for ongoing dev work [cordova-ios]
Posted by "dpogue (via GitHub)" <gi...@apache.org>.
dpogue merged PR #1633:
URL: https://github.com/apache/cordova-ios/pull/1633
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] chore: Bump patch level for ongoing dev work [cordova-ios]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #1633:
URL: https://github.com/apache/cordova-ios/pull/1633#issuecomment-4040533847
## [Codecov](https://app.codecov.io/gh/apache/cordova-ios/pull/1633?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 74.10%. Comparing base ([`fb0f572`](https://app.codecov.io/gh/apache/cordova-ios/commit/fb0f572fce5b11564dd1779257b9abe0154bc3c2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4df9212`](https://app.codecov.io/gh/apache/cordova-ios/commit/4df9212c3f628b1025735daf5a551abc6d9985bc?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
> :exclamation: There is a different number of reports uploaded between BASE (fb0f572) and HEAD (4df9212). Click for more details.
>
> <details><summary>HEAD has 9 uploads less than BASE</summary>
>
>| Flag | BASE (fb0f572) | HEAD (4df9212) |
>|------|------|------|
>||10|1|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #1633 +/- ##
==========================================
- Coverage 80.21% 74.10% -6.12%
==========================================
Files 18 17 -1
Lines 5312 5217 -95
==========================================
- Hits 4261 3866 -395
- Misses 1051 1351 +300
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cordova-ios/pull/1633?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] chore: Bump patch level for ongoing dev work [cordova-ios]
Posted by "dpogue (via GitHub)" <gi...@apache.org>.
dpogue commented on PR #1633:
URL: https://github.com/apache/cordova-ios/pull/1633#issuecomment-4040569530
If the vote fails, we could skip 8.0.1 and do 8.0.2 with this fix, or we could re-tag 8.0.1 off the `8.0.x` branch. We have flexibility, and we can discuss what to do if it comes to that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] chore: Bump patch level for ongoing dev work [cordova-ios]
Posted by "GitToTheHub (via GitHub)" <gi...@apache.org>.
GitToTheHub commented on PR #1633:
URL: https://github.com/apache/cordova-ios/pull/1633#issuecomment-4040685340
> Its OK, you didn't do anything wrong. I was just asking a what-if question.
>
> I think in this case it might not be an issue, since the PR was a fix that could technically go into a patch release. So if the vote did fail, it could simply be included in the re-submission.
Ok, thanks for clearing that up :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org