You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Zeke Harris <zh...@twitter.com> on 2015/05/01 02:06:49 UTC
Review Request 33739: Enable GC executor to gc STARTING tasks which
don't exist on the host
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33739/
-----------------------------------------------------------
Review request for Aurora.
Repository: aurora
Description
-------
Enable GC executor to cause the scheduler to kill tasks that it thinks should be STARTING but which don't exist on the host.
Diffs
-----
src/main/python/apache/aurora/executor/gc_executor.py a7776b599f5fc028ec2ce7712856e080381e84a6
src/test/python/apache/aurora/executor/test_gc_executor.py 856483d9ef7e89a03bb0780d81510bf60928219a
Diff: https://reviews.apache.org/r/33739/diff/
Testing
-------
$ ./pants test src/test/python/apache/aurora/executor:gc_executor
...
SUCCESS
Thanks,
Zeke Harris
Re: Review Request 33739: Enable GC executor to gc STARTING tasks
which don't exist on the host
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33739/#review82228
-----------------------------------------------------------
Ship it!
Master (f9b60c6) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On May 1, 2015, 12:06 a.m., Zeke Harris wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33739/
> -----------------------------------------------------------
>
> (Updated May 1, 2015, 12:06 a.m.)
>
>
> Review request for Aurora.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Enable GC executor to cause the scheduler to kill tasks that it thinks should be STARTING but which don't exist on the host.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/executor/gc_executor.py a7776b599f5fc028ec2ce7712856e080381e84a6
> src/test/python/apache/aurora/executor/test_gc_executor.py 856483d9ef7e89a03bb0780d81510bf60928219a
>
> Diff: https://reviews.apache.org/r/33739/diff/
>
>
> Testing
> -------
>
> $ ./pants test src/test/python/apache/aurora/executor:gc_executor
> ...
> SUCCESS
>
>
> Thanks,
>
> Zeke Harris
>
>
Re: Review Request 33739: Enable GC executor to gc STARTING tasks
which don't exist on the host
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33739/#review82252
-----------------------------------------------------------
LGTM! Just needs some variable names updated.
src/main/python/apache/aurora/executor/gc_executor.py
<https://reviews.apache.org/r/33739/#comment132948>
s/starting/assigned/
src/main/python/apache/aurora/executor/gc_executor.py
<https://reviews.apache.org/r/33739/#comment132947>
Please rename `starting`.
src/main/python/apache/aurora/executor/gc_executor.py
<https://reviews.apache.org/r/33739/#comment132949>
s/starting/assigned/
src/test/python/apache/aurora/executor/test_gc_executor.py
<https://reviews.apache.org/r/33739/#comment132946>
Rename `STARTING_STATES` to reduce confusion.
- Bill Farner
On May 1, 2015, 12:06 a.m., Zeke Harris wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33739/
> -----------------------------------------------------------
>
> (Updated May 1, 2015, 12:06 a.m.)
>
>
> Review request for Aurora.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Enable GC executor to cause the scheduler to kill tasks that it thinks should be STARTING but which don't exist on the host.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/executor/gc_executor.py a7776b599f5fc028ec2ce7712856e080381e84a6
> src/test/python/apache/aurora/executor/test_gc_executor.py 856483d9ef7e89a03bb0780d81510bf60928219a
>
> Diff: https://reviews.apache.org/r/33739/diff/
>
>
> Testing
> -------
>
> $ ./pants test src/test/python/apache/aurora/executor:gc_executor
> ...
> SUCCESS
>
>
> Thanks,
>
> Zeke Harris
>
>
Re: Review Request 33739: Enable GC executor to gc STARTING tasks
which don't exist on the host
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33739/#review82263
-----------------------------------------------------------
Ship it!
Master (f3da5ae) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On May 1, 2015, 5:49 p.m., Zeke Harris wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33739/
> -----------------------------------------------------------
>
> (Updated May 1, 2015, 5:49 p.m.)
>
>
> Review request for Aurora.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Enable GC executor to cause the scheduler to kill tasks that it thinks should be STARTING but which don't exist on the host.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/executor/gc_executor.py a7776b599f5fc028ec2ce7712856e080381e84a6
> src/test/python/apache/aurora/executor/test_gc_executor.py 856483d9ef7e89a03bb0780d81510bf60928219a
>
> Diff: https://reviews.apache.org/r/33739/diff/
>
>
> Testing
> -------
>
> $ ./pants test src/test/python/apache/aurora/executor:gc_executor
> ...
> SUCCESS
>
>
> Thanks,
>
> Zeke Harris
>
>
Re: Review Request 33739: Enable GC executor to gc STARTING tasks
which don't exist on the host
Posted by Zeke Harris <zh...@twitter.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33739/
-----------------------------------------------------------
(Updated May 1, 2015, 5:49 p.m.)
Review request for Aurora.
Changes
-------
Updated to address Bill's comments.
Repository: aurora
Description
-------
Enable GC executor to cause the scheduler to kill tasks that it thinks should be STARTING but which don't exist on the host.
Diffs (updated)
-----
src/main/python/apache/aurora/executor/gc_executor.py a7776b599f5fc028ec2ce7712856e080381e84a6
src/test/python/apache/aurora/executor/test_gc_executor.py 856483d9ef7e89a03bb0780d81510bf60928219a
Diff: https://reviews.apache.org/r/33739/diff/
Testing
-------
$ ./pants test src/test/python/apache/aurora/executor:gc_executor
...
SUCCESS
Thanks,
Zeke Harris