You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "onursatici (via GitHub)" <gi...@apache.org> on 2024/11/01 10:31:10 UTC

Re: [PR] fix q35 [datafusion-benchmarks]

onursatici commented on code in PR #17:
URL: https://github.com/apache/datafusion-benchmarks/pull/17#discussion_r1825678308


##########
tpcds/queries-spark/q35.sql:
##########
@@ -7,19 +7,19 @@ select
   cd_marital_status,
   cd_dep_count,
   count(*) cnt1,
+  min(cd_dep_count),
   max(cd_dep_count),
-  stddev_samp(cd_dep_count),
-  stddev_samp(cd_dep_count),
+  avg(cd_dep_count),

Review Comment:
   I think the query generator has a bug in this case, see https://github.com/apache/datafusion/blob/main/datafusion/core/tests/tpc-ds/35.sql as another generated version that correctly substituted the aggregations



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org