[GitHub] attilapiros commented on a change in pull request #23000: [SPARK-26002][SQL] Fix day of year calculation for Julian calendar days

[GitBox <gi...@apache.org>]

attilapiros commented on a change in pull request #23000: [SPARK-26002][SQL] Fix day of year calculation for Julian calendar days
URL: https://github.com/apache/spark/pull/23000#discussion_r242408206
 
 

 ##########
 File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/DateTimeUtilsSuite.scala
 ##########
 @@ -410,6 +410,32 @@ class DateTimeUtilsSuite extends SparkFunSuite {
     assert(getDayInYear(getInUTCDays(c.getTimeInMillis)) === 78)
   }
 
+  test("SPARK-26002: correct day of year calculations for Julian calendar years") {
 
 Review comment:
   @cloud-fan 
   Do you mean adding a new test to [datetime.sql](https://github.com/apache/spark/blob/421673a4f6ae8820b57bb1fb92d9fe03dc646cde/sql/core/src/test/resources/sql-tests/inputs/datetime.sql)? 
   
   What about adding the ones I used as a manual testing (from the PR description)?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org