svn commit: r985491 - /axis/axis2/java/core/trunk/modules/addressing/src/org/apache/axis2/handlers/addressing/AddressingInHandler.java

[sc...@apache.org]

Author: scheu
Date: Sat Aug 14 13:49:22 2010
New Revision: 985491

URL: http://svn.apache.org/viewvc?rev=985491&view=rev
Log:
Debug trace changes only.

Modified:
    axis/axis2/java/core/trunk/modules/addressing/src/org/apache/axis2/handlers/addressing/AddressingInHandler.java

Modified: axis/axis2/java/core/trunk/modules/addressing/src/org/apache/axis2/handlers/addressing/AddressingInHandler.java
URL: http://svn.apache.org/viewvc/axis/axis2/java/core/trunk/modules/addressing/src/org/apache/axis2/handlers/addressing/AddressingInHandler.java?rev=985491&r1=985490&r2=985491&view=diff
==============================================================================
--- axis/axis2/java/core/trunk/modules/addressing/src/org/apache/axis2/handlers/addressing/AddressingInHandler.java (original)
+++ axis/axis2/java/core/trunk/modules/addressing/src/org/apache/axis2/handlers/addressing/AddressingInHandler.java Sat Aug 14 13:49:22 2010
@@ -264,6 +264,9 @@ public class AddressingInHandler extends
         // Now that all the valid wsa headers have been read, throw an exception if there was an invalid cardinality
         // This means that if for example there are multiple MessageIDs and a FaultTo, the FaultTo will be respected.
         if (!duplicateHeaderNames.isEmpty()) {
+            if (log.isDebugEnabled()) {
+                log.debug("Duplicate header names found:" + duplicateHeaderNames.get(0));
+            }
             // Simply choose the first problem header we came across as we can only fault for one of them.
             AddressingFaultsHelper.triggerInvalidCardinalityFault(messageContext,
                                                                   (String) duplicateHeaderNames
@@ -512,12 +515,16 @@ public class AddressingInHandler extends
         String wsaAction = soapHeaderBlock.getText();
 
         if (LoggingControl.debugLoggingAllowed && log.isTraceEnabled()) {
-            log.trace("extractActionInformation: soapAction='" + soapAction + "' wsa:Action='" +
-                      wsaAction + "'");
+            log.trace("extractActionInformation: HTTP soapAction or action ='" + soapAction + 
+                    "' wsa:Action='" + wsaAction + "'");
         }
 
         // Need to validate that the content of the wsa:Action header is not null or whitespace
         if ((wsaAction == null) || "".equals(wsaAction.trim())) {
+            if (log.isDebugEnabled()) {
+                log.debug("The wsa:Action header is present but its contents are empty.  This violates " +
+                        "rules in the WS-A specification.  The SOAP node that sent this message must be changed.");
+            }
             AddressingFaultsHelper.triggerActionNotSupportedFault(messageContext, wsaAction);
         }
 
@@ -529,6 +536,11 @@ public class AddressingInHandler extends
         // check that soapAction==wsa:Action
         if (soapAction != null && !"".equals(soapAction) && messageContext.isServerSide()) {
             if (!soapAction.equals(wsaAction)) {
+                if (log.isDebugEnabled()) {
+                    log.debug("The wsa:Action header is (" + wsaAction + ") which conflicts with the HTTP soapAction or action " +
+                            "(" + soapAction + ").  This is a violation of the WS-A specification.  The SOAP node that sent this message " +
+                            " must be changed.");
+                }
                 AddressingFaultsHelper.triggerActionMismatchFault(messageContext, soapAction, wsaAction);
             }
         } else {