[GitHub] [flink] vthinkxie commented on a change in pull request #8542: [FLINK-10707][web-dashboard] flink cluster overview dashboard improvements

[GitBox <gi...@apache.org>]

vthinkxie commented on a change in pull request #8542: [FLINK-10707][web-dashboard] flink cluster overview dashboard improvements
URL: https://github.com/apache/flink/pull/8542#discussion_r292371917
 
 

 ##########
 File path: flink-runtime-web/web-dashboard/src/app/pages/overview/statistic/overview-statistic.component.html
 ##########
 @@ -58,4 +66,42 @@
       </ng-container>
     </nz-card>
   </div>
+  <div nz-col [nzXs]="24" [nzSm]="24" [nzMd]="24" [nzLg]="24" [nzXl]="24" class="col">
+    <nz-card [nzBordered]="false" nzTitle="Task Manager Overview" [nzLoading]="!listOfTaskManager">
+      <ng-container *ngFor="let manager of listOfTaskManager;">
 
 Review comment:
   ```suggestion
         <ng-container *ngFor="let manager of listOfTaskManager;trackBy:trackByFunc">
   ```
   should add `trackBy` function here to avoid the dom rerender after refresh
   
   the `trackByFunc` could be
   
   ```typescript
     trackByFunc(_: number, item: TaskmanagersItemInterface) {
       return item.id;
     }
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services