You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/03/30 22:37:03 UTC
[GitHub] [airflow] kaxil opened a new pull request #8021: Allow setting
Airflow Variable values to empty string ('')
kaxil opened a new pull request #8021: Allow setting Airflow Variable values to empty string ('')
URL: https://github.com/apache/airflow/pull/8021
This will allow users to set a Variable with empty string.
It is related to https://github.com/apache/airflow/pull/6084 which was only included in 1.10.5 but not in master
---
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil commented on issue #8021: Allow setting Airflow
Variable values to empty string ('')
Posted by GitBox <gi...@apache.org>.
kaxil commented on issue #8021: Allow setting Airflow Variable values to empty string ('')
URL: https://github.com/apache/airflow/pull/8021#issuecomment-606542641
> Should not we make a comment in UPDATING.md? That is a breaking change IMHO
Yup, agree. Will add it later today
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] RosterIn commented on issue #8021: Allow setting Airflow
Variable values to empty string ('')
Posted by GitBox <gi...@apache.org>.
RosterIn commented on issue #8021: Allow setting Airflow Variable values to empty string ('')
URL: https://github.com/apache/airflow/pull/8021#issuecomment-606755738
Why does it need to be mentioned in updating.md of master if this was already release in 1.10.5?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil merged pull request #8021: Allow setting Airflow
Variable values to empty string ('')
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #8021: Allow setting Airflow Variable values to empty string ('')
URL: https://github.com/apache/airflow/pull/8021
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil commented on issue #8021: Allow setting Airflow
Variable values to empty string ('')
Posted by GitBox <gi...@apache.org>.
kaxil commented on issue #8021: Allow setting Airflow Variable values to empty string ('')
URL: https://github.com/apache/airflow/pull/8021#issuecomment-606609645
> Should not we make a comment in UPDATING.md? That is a breaking change IMHO
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services