You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/10/27 15:02:24 UTC

[GitHub] [flink] MartijnVisser opened a new pull request, #21176: [FLINK-29740][Scala] Mark all Scala APIs as `@Deprecated`

MartijnVisser opened a new pull request, #21176:
URL: https://github.com/apache/flink/pull/21176

   ## What is the purpose of the change
   
   * Mark all Scala APIs as deprecated as the outcome of FLIP-265
   
   ## Brief change log
   
   * Mark all Scala APIs as `@Deprecated`
   * Remove Scala quickstarts, walkthroughs and examples
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] MartijnVisser commented on pull request #21176: [FLINK-29740][Scala] Mark all Scala APIs as `@Deprecated`

Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on PR #21176:
URL: https://github.com/apache/flink/pull/21176#issuecomment-1297130694

   > If at all, we should only deprecate the entry point of the API.
   
   Following our offline sync on this, I've gone with marking the package (which is what you see if you visit https://nightlies.apache.org/flink/flink-docs-master/api/scala/org/apache/flink/api/scala/index.html) and the ExecutionEnvironment https://nightlies.apache.org/flink/flink-docs-master/api/scala/org/apache/flink/api/scala/ExecutionEnvironment.html as `@Deprecated`
   
   The one thing I'm still doubting a bit is about the Scala documentation examples: should we add a hint warning to all examples (feels like overkill), a generic hint for each page that contains a Scala example or should we remove the Scala examples? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zentol commented on pull request #21176: [FLINK-29740][Scala] Mark all Scala APIs as `@Deprecated`

Posted by GitBox <gi...@apache.org>.
zentol commented on PR #21176:
URL: https://github.com/apache/flink/pull/21176#issuecomment-1298301022

   > The one thing I'm still doubting a bit is about the Scala documentation examples: should we add a hint warning to all examples (feels like overkill), a generic hint for each page that contains a Scala example or should we remove the Scala examples?
   
   I'd remove the Scala examples and add a warning all pages that are specifically about Scala (like https://nightlies.apache.org/flink/flink-docs-release-1.16/docs/dev/datastream/scala_api_extensions/).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] MartijnVisser commented on pull request #21176: [FLINK-29740][Scala] Mark all Scala APIs as `@Deprecated`

Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on PR #21176:
URL: https://github.com/apache/flink/pull/21176#issuecomment-1298147082

   > Does this mean that flink won't support Scala by default?
   
   See https://cwiki.apache.org/confluence/display/FLINK/FLIP-265+Deprecate+and+remove+Scala+API+support -> There won't be dedicated Scala APIs in Flink anymore, but you can still use Scala to write your Flink applications. That's explained in https://flink.apache.org/2022/02/22/scala-free.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #21176: [FLINK-29740][Scala] Mark all Scala APIs as `@Deprecated`

Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #21176:
URL: https://github.com/apache/flink/pull/21176#issuecomment-1293673313

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "8fcdf71558ada13795883289840e9caba0b40a88",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "8fcdf71558ada13795883289840e9caba0b40a88",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8fcdf71558ada13795883289840e9caba0b40a88 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] syhily commented on pull request #21176: [FLINK-29740][Scala] Mark all Scala APIs as `@Deprecated`

Posted by GitBox <gi...@apache.org>.
syhily commented on PR #21176:
URL: https://github.com/apache/flink/pull/21176#issuecomment-1297528986

   Does this mean that flink won't support Scala by default?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] MartijnVisser commented on pull request #21176: [FLINK-29740][Scala] Mark all Scala APIs as `@Deprecated`

Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on PR #21176:
URL: https://github.com/apache/flink/pull/21176#issuecomment-1301715942

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] MartijnVisser merged pull request #21176: [FLINK-29740][Scala] Mark all Scala APIs as `@Deprecated`

Posted by GitBox <gi...@apache.org>.
MartijnVisser merged PR #21176:
URL: https://github.com/apache/flink/pull/21176


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org