You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by st...@apache.org on 2023/02/14 01:06:43 UTC
[impala] branch master updated: IMPALA-11895: Need accessor methods for third party extension
This is an automated email from the ASF dual-hosted git repository.
stigahuang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git
The following commit(s) were added to refs/heads/master by this push:
new 94889b164 IMPALA-11895: Need accessor methods for third party extension
94889b164 is described below
commit 94889b1644be905e3427ee155bff36ccb9698a49
Author: Steve Carlin <sc...@cloudera.com>
AuthorDate: Thu Feb 2 08:51:18 2023 -0800
IMPALA-11895: Need accessor methods for third party extension
Changed the visibility of some methods needed for a third
party extension.
The methods included in this are for the statements 'compute stats',
'create function', and 'refresh/invalidate'.
Change-Id: Iaea15ef8a96c9509b9cd79df595868fd1db47e83
Reviewed-on: http://gerrit.cloudera.org:8080/19469
Reviewed-by: Aman Sinha <am...@cloudera.com>
Tested-by: Aman Sinha <am...@cloudera.com>
---
.../java/org/apache/impala/analysis/ComputeStatsStmt.java | 12 ++++++++++++
.../org/apache/impala/analysis/CreateFunctionStmtBase.java | 9 ++++++++-
.../java/org/apache/impala/analysis/CreateTableStmt.java | 4 ++--
.../java/org/apache/impala/analysis/ResetMetadataStmt.java | 2 ++
4 files changed, 24 insertions(+), 3 deletions(-)
diff --git a/fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java b/fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java
index 13f154256..fe2ada49e 100644
--- a/fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java
+++ b/fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java
@@ -1021,6 +1021,18 @@ public class ComputeStatsStmt extends StatementBase {
return false;
}
+ public PartitionSet getPartitionSet() {
+ return partitionSet_;
+ }
+
+ public TableName getTableName() {
+ return tableName_;
+ }
+
+ public boolean isIncremental() {
+ return isIncremental_;
+ }
+
@Override
public String toSql(ToSqlOptions options) {
if (!isIncremental_) {
diff --git a/fe/src/main/java/org/apache/impala/analysis/CreateFunctionStmtBase.java b/fe/src/main/java/org/apache/impala/analysis/CreateFunctionStmtBase.java
index e1fa567d9..6f82ac58e 100644
--- a/fe/src/main/java/org/apache/impala/analysis/CreateFunctionStmtBase.java
+++ b/fe/src/main/java/org/apache/impala/analysis/CreateFunctionStmtBase.java
@@ -90,7 +90,7 @@ public abstract class CreateFunctionStmtBase extends StatementBase {
}
// Returns optArg[key], first validating that it is set.
- protected String checkAndGetOptArg(OptArg key)
+ public String checkAndGetOptArg(OptArg key)
throws AnalysisException {
if (!optArgs_.containsKey(key)) {
throw new AnalysisException("Argument '" + key + "' must be set.");
@@ -186,6 +186,13 @@ public abstract class CreateFunctionStmtBase extends StatementBase {
}
}
+ public FunctionName getFunctionName() {
+ return fnName_;
+ }
+
+ public HdfsUri getLocation() {
+ return location_;
+ }
/**
* Creates a concrete function.
*/
diff --git a/fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java b/fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java
index 47c1f3b58..bc378c5d5 100644
--- a/fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java
+++ b/fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java
@@ -91,7 +91,7 @@ public class CreateTableStmt extends StatementBase {
/**
* Copy c'tor.
*/
- CreateTableStmt(CreateTableStmt other) {
+ public CreateTableStmt(CreateTableStmt other) {
this(other.tableDef_);
owner_ = other.owner_;
}
@@ -129,7 +129,7 @@ public class CreateTableStmt extends StatementBase {
public List<String> getSortColumns() { return tableDef_.getSortColumns(); }
public TSortingOrder getSortingOrder() { return tableDef_.getSortingOrder(); }
public String getComment() { return tableDef_.getComment(); }
- Map<String, String> getTblProperties() { return tableDef_.getTblProperties(); }
+ public Map<String, String> getTblProperties() { return tableDef_.getTblProperties(); }
private HdfsCachingOp getCachingOp() { return tableDef_.getCachingOp(); }
public HdfsUri getLocation() { return tableDef_.getLocation(); }
Map<String, String> getSerdeProperties() { return tableDef_.getSerdeProperties(); }
diff --git a/fe/src/main/java/org/apache/impala/analysis/ResetMetadataStmt.java b/fe/src/main/java/org/apache/impala/analysis/ResetMetadataStmt.java
index 73c78b335..29f9393c3 100644
--- a/fe/src/main/java/org/apache/impala/analysis/ResetMetadataStmt.java
+++ b/fe/src/main/java/org/apache/impala/analysis/ResetMetadataStmt.java
@@ -122,6 +122,8 @@ public class ResetMetadataStmt extends StatementBase {
public TableName getTableName() { return tableName_; }
+ public PartitionSpec getPartitionSpec() { return partitionSpec_; }
+
@VisibleForTesting
protected Action getAction() { return action_; }