You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "rambleraptor (via GitHub)" <gi...@apache.org> on 2026/01/22 19:21:21 UTC

[PR] docs: Add missing methods for table and namespace manipulation [iceberg-python]

rambleraptor opened a new pull request, #2942:
URL: https://github.com/apache/iceberg-python/pull/2942

   <!--
   Thanks for opening a pull request!
   -->
   
   <!-- In the case this PR will resolve an issue, please replace ${GITHUB_ISSUE_ID} below with the actual Github issue id. -->
   <!-- Closes #${GITHUB_ISSUE_ID} -->
   
   # Rationale for this change
   We have some methods for working with tables + namespaces on catalogs that we haven't properly documented. This documentation is super helpful for new users to understand what they can use PyIceberg for. It's also helpful for our LLM...friends? to help understand the project.
   
   ## Are these changes tested?
   Docs only.
   
   ## Are there any user-facing changes?
   Docs only.
   
   <!-- In the case of user-facing changes, please add the changelog label. -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] docs: Add missing methods for table and namespace manipulation [iceberg-python]

Posted by "rambleraptor (via GitHub)" <gi...@apache.org>.
rambleraptor commented on code in PR #2942:
URL: https://github.com/apache/iceberg-python/pull/2942#discussion_r2733348022


##########
mkdocs/docs/api.md:
##########
@@ -80,6 +80,15 @@ Or, list existing namespaces:
 ns = catalog.list_namespaces()
 
 assert ns == [("docs_example",)]
+
+# Load namespace properties
+properties = catalog.load_namespace_properties("docs_example")
+
+# Update namespace properties
+catalog.update_namespace_properties("docs_example", updates={"owner": "iceberg"})

Review Comment:
   Yep, gotta love Vim. Thanks for that!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] docs: Add missing methods for table and namespace manipulation [iceberg-python]

Posted by "rambleraptor (via GitHub)" <gi...@apache.org>.
rambleraptor commented on PR #2942:
URL: https://github.com/apache/iceberg-python/pull/2942#issuecomment-3807306768

   <img width="1087" height="604" alt="Screenshot 2026-01-27 at 12 09 59 PM" src="https://github.com/user-attachments/assets/aca441f9-4f65-440d-8afe-d9e3b69975e5" />
   <img width="1070" height="558" alt="Screenshot 2026-01-27 at 12 10 25 PM" src="https://github.com/user-attachments/assets/758d1fec-5922-4fdc-afa2-5cf08e5be4e1" />
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] docs: Add missing methods for table and namespace manipulation [iceberg-python]

Posted by "rambleraptor (via GitHub)" <gi...@apache.org>.
rambleraptor commented on PR #2942:
URL: https://github.com/apache/iceberg-python/pull/2942#issuecomment-3807103009

   <img width="1071" height="440" alt="Screenshot 2026-01-27 at 11 27 12 AM" src="https://github.com/user-attachments/assets/3158c50f-569a-4fcd-a35e-9c901478e7bc" />
   <img width="1105" height="565" alt="Screenshot 2026-01-27 at 11 27 40 AM" src="https://github.com/user-attachments/assets/bb57e0b6-a003-4857-a1d9-a9e9d72c7138" />
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] docs: Add missing methods for table and namespace manipulation [iceberg-python]

Posted by "rambleraptor (via GitHub)" <gi...@apache.org>.
rambleraptor commented on PR #2942:
URL: https://github.com/apache/iceberg-python/pull/2942#issuecomment-3807104771

   @kevinjqliu let me know if there's other screenshots you want!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] docs: Add missing methods for table and namespace manipulation [iceberg-python]

Posted by "geruh (via GitHub)" <gi...@apache.org>.
geruh commented on code in PR #2942:
URL: https://github.com/apache/iceberg-python/pull/2942#discussion_r2733590641


##########
mkdocs/docs/api.md:
##########
@@ -80,6 +80,15 @@ Or, list existing namespaces:
 ns = catalog.list_namespaces()
 
 assert ns == [("docs_example",)]
+
+# Load namespace properties
+properties = catalog.load_namespace_properties("docs_example")
+
+# Update namespace properties with additions and removals.
+catalog.update_namespace_properties("docs_example", removals={"remove-meee!"}, updates={"owner": "iceberg"})
+
+# Drop a namespace
+# catalog.drop_namespace("docs_example")

Review Comment:
   did you mean to have a comment before this drop ns?



##########
mkdocs/docs/api.md:
##########
@@ -165,6 +174,16 @@ with catalog.create_table_transaction(identifier="docs_example.bids", schema=sch
         update_spec.add_identity("symbol")
 
     txn.set_properties(test_a="test_aa", test_b="test_b", test_c="test_c")
+

Review Comment:
   still need backticks here:
   
   <img width="1116" height="626" alt="Image" src="https://github.com/user-attachments/assets/ebe1beaa-8db3-40e6-9d2b-a40001bf71d3" />



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] docs: Add missing methods for table and namespace manipulation [iceberg-python]

Posted by "rambleraptor (via GitHub)" <gi...@apache.org>.
rambleraptor commented on PR #2942:
URL: https://github.com/apache/iceberg-python/pull/2942#issuecomment-3807308912

   thanks @kevinjqliu @geruh for the review!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] docs: Add missing methods for table and namespace manipulation [iceberg-python]

Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu merged PR #2942:
URL: https://github.com/apache/iceberg-python/pull/2942


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] docs: Add missing methods for table and namespace manipulation [iceberg-python]

Posted by "rambleraptor (via GitHub)" <gi...@apache.org>.
rambleraptor commented on code in PR #2942:
URL: https://github.com/apache/iceberg-python/pull/2942#discussion_r2733347415


##########
mkdocs/docs/api.md:
##########
@@ -165,8 +174,20 @@ with catalog.create_table_transaction(identifier="docs_example.bids", schema=sch
         update_spec.add_identity("symbol")
 
     txn.set_properties(test_a="test_aa", test_b="test_b", test_c="test_c")
+

Review Comment:
   Whoops, thanks for that. Checked the docs, they look good.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] docs: Add missing methods for table and namespace manipulation [iceberg-python]

Posted by "geruh (via GitHub)" <gi...@apache.org>.
geruh commented on code in PR #2942:
URL: https://github.com/apache/iceberg-python/pull/2942#discussion_r2730507009


##########
mkdocs/docs/api.md:
##########
@@ -80,6 +80,15 @@ Or, list existing namespaces:
 ns = catalog.list_namespaces()
 
 assert ns == [("docs_example",)]
+
+# Load namespace properties
+properties = catalog.load_namespace_properties("docs_example")
+
+# Update namespace properties
+catalog.update_namespace_properties("docs_example", updates={"owner": "iceberg"})

Review Comment:
   Nit: not blocking but maybe we can add that we can remove properties with the `removals` param:
   
   ```
   catalog.update_namespace_properties("docs_example", removals={"remove-meee!"}, updates={"owner": "iceberg"})
   ```



##########
mkdocs/docs/api.md:
##########
@@ -165,8 +174,20 @@ with catalog.create_table_transaction(identifier="docs_example.bids", schema=sch
         update_spec.add_identity("symbol")
 
     txn.set_properties(test_a="test_aa", test_b="test_b", test_c="test_c")
+
+## Register a table
+
+To register a table using existing metadata:
+
+```python
+catalog.register_table(
+    identifier="docs_example.bids",
+    metadata_location="s3://warehouse/path/to/metadata.json"
+)
 ```
 
+```python

Review Comment:
   I think there is an orphaned code block here
   
   <img width="932" height="348" alt="Image" src="https://github.com/user-attachments/assets/327ffbe9-5340-4fb0-b3ec-a7b38df81167" />



##########
mkdocs/docs/api.md:
##########
@@ -165,8 +174,20 @@ with catalog.create_table_transaction(identifier="docs_example.bids", schema=sch
         update_spec.add_identity("symbol")
 
     txn.set_properties(test_a="test_aa", test_b="test_b", test_c="test_c")
+

Review Comment:
   You lost the closing code block back ticks



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] docs: Add missing methods for table and namespace manipulation [iceberg-python]

Posted by "geruh (via GitHub)" <gi...@apache.org>.
geruh commented on code in PR #2942:
URL: https://github.com/apache/iceberg-python/pull/2942#discussion_r2730491350


##########
mkdocs/docs/api.md:
##########
@@ -165,8 +174,20 @@ with catalog.create_table_transaction(identifier="docs_example.bids", schema=sch
         update_spec.add_identity("symbol")
 
     txn.set_properties(test_a="test_aa", test_b="test_b", test_c="test_c")
+

Review Comment:
   There's a markdown syntax issue here, and we lost the closing back ticks. I'd suggest deploying the docs and comparing to current site



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] docs: Add missing methods for table and namespace manipulation [iceberg-python]

Posted by "rambleraptor (via GitHub)" <gi...@apache.org>.
rambleraptor commented on code in PR #2942:
URL: https://github.com/apache/iceberg-python/pull/2942#discussion_r2734191536


##########
mkdocs/docs/api.md:
##########
@@ -80,6 +80,15 @@ Or, list existing namespaces:
 ns = catalog.list_namespaces()
 
 assert ns == [("docs_example",)]
+
+# Load namespace properties
+properties = catalog.load_namespace_properties("docs_example")
+
+# Update namespace properties with additions and removals.
+catalog.update_namespace_properties("docs_example", removals={"remove-meee!"}, updates={"owner": "iceberg"})
+
+# Drop a namespace
+# catalog.drop_namespace("docs_example")

Review Comment:
   Oh sorry, I completely misunderstood what you were asking! Removed the comment. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] docs: Add missing methods for table and namespace manipulation [iceberg-python]

Posted by "rambleraptor (via GitHub)" <gi...@apache.org>.
rambleraptor commented on code in PR #2942:
URL: https://github.com/apache/iceberg-python/pull/2942#discussion_r2733642099


##########
mkdocs/docs/api.md:
##########
@@ -80,6 +80,15 @@ Or, list existing namespaces:
 ns = catalog.list_namespaces()
 
 assert ns == [("docs_example",)]
+
+# Load namespace properties
+properties = catalog.load_namespace_properties("docs_example")
+
+# Update namespace properties with additions and removals.
+catalog.update_namespace_properties("docs_example", removals={"remove-meee!"}, updates={"owner": "iceberg"})
+
+# Drop a namespace
+# catalog.drop_namespace("docs_example")

Review Comment:
   I was doing that to match the other comments, but I did a quick fix to better match the "example" flow we're going for.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] docs: Add missing methods for table and namespace manipulation [iceberg-python]

Posted by "geruh (via GitHub)" <gi...@apache.org>.
geruh commented on code in PR #2942:
URL: https://github.com/apache/iceberg-python/pull/2942#discussion_r2734131897


##########
mkdocs/docs/api.md:
##########
@@ -80,6 +80,15 @@ Or, list existing namespaces:
 ns = catalog.list_namespaces()
 
 assert ns == [("docs_example",)]
+
+# Load namespace properties
+properties = catalog.load_namespace_properties("docs_example")
+
+# Update namespace properties with additions and removals.
+catalog.update_namespace_properties("docs_example", removals={"remove-meee!"}, updates={"owner": "iceberg"})
+
+# Drop a namespace
+# catalog.drop_namespace("docs_example")

Review Comment:
   Are you saying since the flow uses this namespace and the command is commented because it would technically break the other functions



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org