You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/04/10 11:31:18 UTC
[GitHub] [flink] godfreyhe opened a new pull request #11700: [FLINK-16366]
[table] Introduce executeSql method in TableEnvironment and support many
statements
godfreyhe opened a new pull request #11700: [FLINK-16366] [table] Introduce executeSql method in TableEnvironment and support many statements
URL: https://github.com/apache/flink/pull/11700
## What is the purpose of the change
*Introduce executeSql method in TableEnvironment and support many statements: DDL, USE, SHOW. This PR does not involve EXPLAIN, DESCRIBE, INSERT and SELECT, which will be implemented in other PRs*
## Brief change log
- *Introduce executeSql method in TableEnvironment*
- *implement each statement for executeSql*
## Verifying this change
This change added tests and can be verified as follows:
- *each statement is tested in TableEnvironmentTest for stream TableEnvironment and in BatchTableEnvironmentTest for BatchTableEnvironment*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (**yes** / no)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (**yes** / no)
- If yes, how is the feature documented? (not applicable / docs / **JavaDocs** / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] godfreyhe commented on a change in pull request #11700:
[FLINK-16366] [table] Introduce executeSql method in TableEnvironment and
support many statements
Posted by GitBox <gi...@apache.org>.
godfreyhe commented on a change in pull request #11700: [FLINK-16366] [table] Introduce executeSql method in TableEnvironment and support many statements
URL: https://github.com/apache/flink/pull/11700#discussion_r408027710
##########
File path: flink-table/flink-table-api-java/src/main/resources/META-INF/NOTICE
##########
@@ -0,0 +1,10 @@
+flink-table
+Copyright 2014-2020 The Apache Software Foundation
+
+This product includes software developed at
+The Apache Software Foundation (http://www.apache.org/).
+
+This project bundles the following dependencies under the BSD license.
+See bundled license files for details.
+
+- com.ibm.icu:icu4j:65.1
Review comment:
It's also my concern.
one approach is we does not support this feature in `TableResult.print`. consider that the most uses case of `TableResult.print` is used in IDE for debug and demo. In IDEA, even we use `icu4j` to get word width, the result also looks irregular when the content contain CJK.
see the comment in [CliTableauResultViewTest#testStreamingResult](https://github.com/apache/flink/blob/master/flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/cli/CliTableauResultViewTest.java#L290)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] godfreyhe commented on issue #11700: [FLINK-16366] [table]
Introduce executeSql method in TableEnvironment and support many statements
Posted by GitBox <gi...@apache.org>.
godfreyhe commented on issue #11700: [FLINK-16366] [table] Introduce executeSql method in TableEnvironment and support many statements
URL: https://github.com/apache/flink/pull/11700#issuecomment-612721799
@flinkbot run travis
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] KurtYoung commented on a change in pull request #11700:
[FLINK-16366] [table] Introduce executeSql method in TableEnvironment and
support many statements
Posted by GitBox <gi...@apache.org>.
KurtYoung commented on a change in pull request #11700: [FLINK-16366] [table] Introduce executeSql method in TableEnvironment and support many statements
URL: https://github.com/apache/flink/pull/11700#discussion_r407985708
##########
File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/TableResultImpl.java
##########
@@ -0,0 +1,334 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.api.internal;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.core.execution.JobClient;
+import org.apache.flink.table.api.DataTypes;
+import org.apache.flink.table.api.ResultKind;
+import org.apache.flink.table.api.TableColumn;
+import org.apache.flink.table.api.TableResult;
+import org.apache.flink.table.api.TableSchema;
+import org.apache.flink.table.utils.EncodingUtils;
+import org.apache.flink.types.Row;
+import org.apache.flink.util.Preconditions;
+
+import com.ibm.icu.lang.UCharacter;
+import com.ibm.icu.lang.UProperty;
+import org.apache.commons.lang3.StringUtils;
+
+import javax.annotation.Nullable;
+
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.Iterator;
+import java.util.List;
+import java.util.Optional;
+
+/**
+ * Implementation for {@link TableResult}.
+ */
+@Internal
+public class TableResultImpl implements TableResult {
+ public static final TableResult TABLE_RESULT_OK = TableResultImpl.builder()
+ .resultKind(ResultKind.SUCCESS)
+ .tableSchema(TableSchema.builder().field("result", DataTypes.STRING()).build())
+ .data(Collections.singletonList(Row.of("OK")))
+ .build();
+
+ // constants for printing
+ private static final String NULL_COLUMN = "(NULL)";
+ private static final int MAX_COLUMN_WIDTH = 30;
+ private static final String COLUMN_TRUNCATED_FLAG = "...";
+
+ private final JobClient jobClient;
+ private final TableSchema tableSchema;
+ private final ResultKind resultKind;
+ private final Iterator<Row> data;
+
+ private TableResultImpl(
+ @Nullable JobClient jobClient,
+ TableSchema tableSchema,
+ ResultKind resultKind,
+ Iterator<Row> data) {
+ this.jobClient = jobClient;
+ this.tableSchema = Preconditions.checkNotNull(tableSchema, "tableSchema should not be null");
+ this.resultKind = Preconditions.checkNotNull(resultKind, "resultKind should not be null");
+ this.data = Preconditions.checkNotNull(data, "data should not be null");
+ }
+
+ @Override
+ public Optional<JobClient> getJobClient() {
+ return Optional.ofNullable(jobClient);
+ }
+
+ @Override
+ public TableSchema getTableSchema() {
+ return tableSchema;
+ }
+
+ @Override
+ public ResultKind getResultKind() {
+ return resultKind;
+ }
+
+ @Override
+ public Iterator<Row> collect() {
+ return data;
+ }
+
+ @Override
+ public void print() {
+ Iterator<Row> it = collect();
+ doPrint(it);
+ }
+
+ public static Builder builder() {
+ return new Builder();
+ }
+
+ /**
+ * Builder for creating a {@link TableResultImpl}.
+ */
+ public static class Builder {
+ private JobClient jobClient = null;
+ private TableSchema tableSchema = null;
+ private ResultKind resultKind = null;
+ private Iterator<Row> data = null;
+
+ private Builder() {
+ }
+
+ /**
+ * Specifies job client which associates the submitted Flink job.
+ *
+ * @param jobClient a {@link JobClient} for the submitted Flink job.
+ */
+ public Builder jobClient(JobClient jobClient) {
+ this.jobClient = jobClient;
+ return this;
+ }
+
+ /**
+ * Specifies table schema of the execution result.
+ *
+ * @param tableSchema a {@link TableSchema} for the execution result.
+ */
+ public Builder tableSchema(TableSchema tableSchema) {
+ Preconditions.checkNotNull(tableSchema, "tableSchema should not be null");
+ this.tableSchema = tableSchema;
+ return this;
+ }
+
+ /**
+ * Specifies result kind of the execution result.
+ *
+ * @param resultKind a {@link ResultKind} for the execution result.
+ */
+ public Builder resultKind(ResultKind resultKind) {
+ Preconditions.checkNotNull(resultKind, "resultKind should not be null");
+ this.resultKind = resultKind;
+ return this;
+ }
+
+ /**
+ * Specifies an row iterator as the execution result .
+ *
+ * @param rowIterator a row iterator as the execution result.
+ */
+ public Builder data(Iterator<Row> rowIterator) {
+ Preconditions.checkNotNull(rowIterator, "rowIterator should not be null");
+ this.data = rowIterator;
+ return this;
+ }
+
+ /**
+ * Specifies an row list as the execution result .
+ *
+ * @param rowList a row list as the execution result.
+ */
+ public Builder data(List<Row> rowList) {
+ Preconditions.checkNotNull(rowList, "listRows should not be null");
+ this.data = rowList.iterator();
+ return this;
+ }
+
+ /**
+ * Returns a {@link TableResult} instance.
+ */
+ public TableResult build() {
+ return new TableResultImpl(jobClient, tableSchema, resultKind, data);
+ }
+ }
+
+ /**
+ * Displays the result in a tableau form.
+ * For example:
+ * +-------------+---------+-------------+
+ * | boolean_col | int_col | varchar_col |
+ * +-------------+---------+-------------+
+ * | true | 1 | abc |
+ * | false | 2 | def |
+ * | (NULL) | (NULL) | (NULL) |
+ * +-------------+---------+-------------+
+ * 3 row(s) in result
+ *
+ * <p>Changelog is not supported until FLINK-16998 is finished.
+ */
+ private void doPrint(Iterator<Row> it) {
Review comment:
Find a way to reuse codes instead of copying them?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] KurtYoung commented on a change in pull request #11700:
[FLINK-16366] [table] Introduce executeSql method in TableEnvironment and
support many statements
Posted by GitBox <gi...@apache.org>.
KurtYoung commented on a change in pull request #11700: [FLINK-16366] [table] Introduce executeSql method in TableEnvironment and support many statements
URL: https://github.com/apache/flink/pull/11700#discussion_r410676055
##########
File path: flink-table/flink-table-common/src/main/resources/META-INF/NOTICE
##########
@@ -0,0 +1,10 @@
+flink-table
+Copyright 2014-2020 The Apache Software Foundation
+
+This product includes software developed at
+The Apache Software Foundation (http://www.apache.org/).
+
+This project bundles the following dependencies under the BSD license.
+See bundled license files for details.
+
+- com.ibm.icu:icu4j:65.1
Review comment:
If you don't bundle this dependency into this module's jar, I don't think you need to add this file
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11700: [FLINK-16366]
[table] Introduce executeSql method in TableEnvironment and support many
statements
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11700: [FLINK-16366] [table] Introduce executeSql method in TableEnvironment and support many statements
URL: https://github.com/apache/flink/pull/11700#issuecomment-612000686
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f52f4a10b99fa573ffeb63f16491d735cc157a4b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f52f4a10b99fa573ffeb63f16491d735cc157a4b",
"triggerType" : "PUSH"
}, {
"hash" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7333",
"triggerID" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"triggerType" : "PUSH"
}, {
"hash" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159777430",
"triggerID" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"triggerType" : "PUSH"
}, {
"hash" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f52f4a10b99fa573ffeb63f16491d735cc157a4b UNKNOWN
* 445558c0ecbaf13f24c6bcf7fa738fb9fb35d603 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/159777430) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7333)
* 95353b2b514d755a5da8b6bc222d5850c0354113 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11700: [FLINK-16366]
[table] Introduce executeSql method in TableEnvironment and support many
statements
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11700: [FLINK-16366] [table] Introduce executeSql method in TableEnvironment and support many statements
URL: https://github.com/apache/flink/pull/11700#issuecomment-612000686
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f52f4a10b99fa573ffeb63f16491d735cc157a4b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f52f4a10b99fa573ffeb63f16491d735cc157a4b",
"triggerType" : "PUSH"
}, {
"hash" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7333",
"triggerID" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"triggerType" : "PUSH"
}, {
"hash" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159777430",
"triggerID" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"triggerType" : "PUSH"
}, {
"hash" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159895426",
"triggerID" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"triggerType" : "PUSH"
}, {
"hash" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7350",
"triggerID" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"triggerType" : "PUSH"
}, {
"hash" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159895426",
"triggerID" : "612721799",
"triggerType" : "MANUAL"
}, {
"hash" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7350",
"triggerID" : "612721799",
"triggerType" : "MANUAL"
}, {
"hash" : "4d4d973d7e1916f6f4d66e720bcc94488e4efda0",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160167037",
"triggerID" : "4d4d973d7e1916f6f4d66e720bcc94488e4efda0",
"triggerType" : "PUSH"
}, {
"hash" : "4d4d973d7e1916f6f4d66e720bcc94488e4efda0",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7438",
"triggerID" : "4d4d973d7e1916f6f4d66e720bcc94488e4efda0",
"triggerType" : "PUSH"
}, {
"hash" : "32354a866dcb787e5118ce59b908e4947c6ecc77",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7510",
"triggerID" : "32354a866dcb787e5118ce59b908e4947c6ecc77",
"triggerType" : "PUSH"
}, {
"hash" : "32354a866dcb787e5118ce59b908e4947c6ecc77",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160362240",
"triggerID" : "32354a866dcb787e5118ce59b908e4947c6ecc77",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f52f4a10b99fa573ffeb63f16491d735cc157a4b UNKNOWN
* 32354a866dcb787e5118ce59b908e4947c6ecc77 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/160362240) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7510)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11700: [FLINK-16366]
[table] Introduce executeSql method in TableEnvironment and support many
statements
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11700: [FLINK-16366] [table] Introduce executeSql method in TableEnvironment and support many statements
URL: https://github.com/apache/flink/pull/11700#issuecomment-612000686
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f52f4a10b99fa573ffeb63f16491d735cc157a4b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f52f4a10b99fa573ffeb63f16491d735cc157a4b",
"triggerType" : "PUSH"
}, {
"hash" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7333",
"triggerID" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"triggerType" : "PUSH"
}, {
"hash" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159777430",
"triggerID" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"triggerType" : "PUSH"
}, {
"hash" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159895426",
"triggerID" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"triggerType" : "PUSH"
}, {
"hash" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7350",
"triggerID" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"triggerType" : "PUSH"
}, {
"hash" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159895426",
"triggerID" : "612721799",
"triggerType" : "MANUAL"
}, {
"hash" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7350",
"triggerID" : "612721799",
"triggerType" : "MANUAL"
}, {
"hash" : "4d4d973d7e1916f6f4d66e720bcc94488e4efda0",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160167037",
"triggerID" : "4d4d973d7e1916f6f4d66e720bcc94488e4efda0",
"triggerType" : "PUSH"
}, {
"hash" : "4d4d973d7e1916f6f4d66e720bcc94488e4efda0",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7438",
"triggerID" : "4d4d973d7e1916f6f4d66e720bcc94488e4efda0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f52f4a10b99fa573ffeb63f16491d735cc157a4b UNKNOWN
* 95353b2b514d755a5da8b6bc222d5850c0354113 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/159895426) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7350)
* 4d4d973d7e1916f6f4d66e720bcc94488e4efda0 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/160167037) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7438)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11700: [FLINK-16366]
[table] Introduce executeSql method in TableEnvironment and support many
statements
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11700: [FLINK-16366] [table] Introduce executeSql method in TableEnvironment and support many statements
URL: https://github.com/apache/flink/pull/11700#issuecomment-612000686
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f52f4a10b99fa573ffeb63f16491d735cc157a4b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f52f4a10b99fa573ffeb63f16491d735cc157a4b",
"triggerType" : "PUSH"
}, {
"hash" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f52f4a10b99fa573ffeb63f16491d735cc157a4b UNKNOWN
* 445558c0ecbaf13f24c6bcf7fa738fb9fb35d603 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] KurtYoung commented on a change in pull request #11700:
[FLINK-16366] [table] Introduce executeSql method in TableEnvironment and
support many statements
Posted by GitBox <gi...@apache.org>.
KurtYoung commented on a change in pull request #11700: [FLINK-16366] [table] Introduce executeSql method in TableEnvironment and support many statements
URL: https://github.com/apache/flink/pull/11700#discussion_r407849169
##########
File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/TableResultImpl.java
##########
@@ -0,0 +1,170 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.api.internal;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.core.execution.JobClient;
+import org.apache.flink.table.api.DataTypes;
+import org.apache.flink.table.api.ResultKind;
+import org.apache.flink.table.api.TableResult;
+import org.apache.flink.table.api.TableSchema;
+import org.apache.flink.types.Row;
+import org.apache.flink.util.Preconditions;
+
+import javax.annotation.Nullable;
+
+import java.util.Collections;
+import java.util.Iterator;
+import java.util.List;
+import java.util.Optional;
+
+/**
+ * Implementation for {@link TableResult}.
+ */
+@Internal
+public class TableResultImpl implements TableResult {
+ public static final TableResult TABLE_RESULT_OK = TableResultImpl.builder()
+ .resultKind(ResultKind.SUCCESS)
+ .tableSchema(TableSchema.builder().field("result", DataTypes.STRING()).build())
+ .data(Collections.singletonList(Row.of("OK")))
+ .build();
+
+ private final JobClient jobClient;
+ private final TableSchema tableSchema;
+ private final ResultKind resultKind;
+ private final Iterator<Row> data;
+
+ private TableResultImpl(
+ @Nullable JobClient jobClient,
+ TableSchema tableSchema,
+ ResultKind resultKind,
+ Iterator<Row> data) {
+ this.jobClient = jobClient;
+ this.tableSchema = Preconditions.checkNotNull(tableSchema, "tableSchema should not be null");
+ this.resultKind = Preconditions.checkNotNull(resultKind, "resultKind should not be null");
+ this.data = Preconditions.checkNotNull(data, "data should not be null");
+ }
+
+ @Override
+ public Optional<JobClient> getJobClient() {
+ return Optional.ofNullable(jobClient);
+ }
+
+ @Override
+ public TableSchema getTableSchema() {
+ return tableSchema;
+ }
+
+ @Override
+ public ResultKind getResultKind() {
+ return resultKind;
+ }
+
+ @Override
+ public Iterator<Row> collect() {
+ return data;
+ }
+
+ @Override
+ public void print() {
Review comment:
how about reusing some logic with tableau format in SQL CLI, which you can find in `CliTableauResultView`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11700: [FLINK-16366]
[table] Introduce executeSql method in TableEnvironment and support many
statements
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11700: [FLINK-16366] [table] Introduce executeSql method in TableEnvironment and support many statements
URL: https://github.com/apache/flink/pull/11700#issuecomment-612000686
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f52f4a10b99fa573ffeb63f16491d735cc157a4b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f52f4a10b99fa573ffeb63f16491d735cc157a4b",
"triggerType" : "PUSH"
}, {
"hash" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7333",
"triggerID" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"triggerType" : "PUSH"
}, {
"hash" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159777430",
"triggerID" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"triggerType" : "PUSH"
}, {
"hash" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159895426",
"triggerID" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"triggerType" : "PUSH"
}, {
"hash" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7350",
"triggerID" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"triggerType" : "PUSH"
}, {
"hash" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159895426",
"triggerID" : "612721799",
"triggerType" : "MANUAL"
}, {
"hash" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7350",
"triggerID" : "612721799",
"triggerType" : "MANUAL"
}, {
"hash" : "4d4d973d7e1916f6f4d66e720bcc94488e4efda0",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160167037",
"triggerID" : "4d4d973d7e1916f6f4d66e720bcc94488e4efda0",
"triggerType" : "PUSH"
}, {
"hash" : "4d4d973d7e1916f6f4d66e720bcc94488e4efda0",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7438",
"triggerID" : "4d4d973d7e1916f6f4d66e720bcc94488e4efda0",
"triggerType" : "PUSH"
}, {
"hash" : "32354a866dcb787e5118ce59b908e4947c6ecc77",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7510",
"triggerID" : "32354a866dcb787e5118ce59b908e4947c6ecc77",
"triggerType" : "PUSH"
}, {
"hash" : "32354a866dcb787e5118ce59b908e4947c6ecc77",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160362240",
"triggerID" : "32354a866dcb787e5118ce59b908e4947c6ecc77",
"triggerType" : "PUSH"
}, {
"hash" : "0ac7518a59d0205c3fe65d8bf636f6a8229663bb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0ac7518a59d0205c3fe65d8bf636f6a8229663bb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f52f4a10b99fa573ffeb63f16491d735cc157a4b UNKNOWN
* 32354a866dcb787e5118ce59b908e4947c6ecc77 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/160362240) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7510)
* 0ac7518a59d0205c3fe65d8bf636f6a8229663bb UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] KurtYoung commented on a change in pull request #11700:
[FLINK-16366] [table] Introduce executeSql method in TableEnvironment and
support many statements
Posted by GitBox <gi...@apache.org>.
KurtYoung commented on a change in pull request #11700: [FLINK-16366] [table] Introduce executeSql method in TableEnvironment and support many statements
URL: https://github.com/apache/flink/pull/11700#discussion_r410676087
##########
File path: flink-table/flink-table-common/src/main/resources/META-INF/NOTICE
##########
@@ -0,0 +1,10 @@
+flink-table
+Copyright 2014-2020 The Apache Software Foundation
+
+This product includes software developed at
+The Apache Software Foundation (http://www.apache.org/).
+
+This project bundles the following dependencies under the BSD license.
+See bundled license files for details.
+
+- com.ibm.icu:icu4j:65.1
Review comment:
Same applies to LICENSE.icu4j
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11700: [FLINK-16366]
[table] Introduce executeSql method in TableEnvironment and support many
statements
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11700: [FLINK-16366] [table] Introduce executeSql method in TableEnvironment and support many statements
URL: https://github.com/apache/flink/pull/11700#issuecomment-612000686
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f52f4a10b99fa573ffeb63f16491d735cc157a4b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f52f4a10b99fa573ffeb63f16491d735cc157a4b",
"triggerType" : "PUSH"
}, {
"hash" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7333",
"triggerID" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"triggerType" : "PUSH"
}, {
"hash" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159777430",
"triggerID" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"triggerType" : "PUSH"
}, {
"hash" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159895426",
"triggerID" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"triggerType" : "PUSH"
}, {
"hash" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7350",
"triggerID" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"triggerType" : "PUSH"
}, {
"hash" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159895426",
"triggerID" : "612721799",
"triggerType" : "MANUAL"
}, {
"hash" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7350",
"triggerID" : "612721799",
"triggerType" : "MANUAL"
}, {
"hash" : "4d4d973d7e1916f6f4d66e720bcc94488e4efda0",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4d4d973d7e1916f6f4d66e720bcc94488e4efda0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f52f4a10b99fa573ffeb63f16491d735cc157a4b UNKNOWN
* 95353b2b514d755a5da8b6bc222d5850c0354113 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/159895426) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7350)
* 4d4d973d7e1916f6f4d66e720bcc94488e4efda0 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11700: [FLINK-16366]
[table] Introduce executeSql method in TableEnvironment and support many
statements
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11700: [FLINK-16366] [table] Introduce executeSql method in TableEnvironment and support many statements
URL: https://github.com/apache/flink/pull/11700#issuecomment-612000686
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f52f4a10b99fa573ffeb63f16491d735cc157a4b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f52f4a10b99fa573ffeb63f16491d735cc157a4b",
"triggerType" : "PUSH"
}, {
"hash" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7333",
"triggerID" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"triggerType" : "PUSH"
}, {
"hash" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159777430",
"triggerID" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"triggerType" : "PUSH"
}, {
"hash" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159895426",
"triggerID" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"triggerType" : "PUSH"
}, {
"hash" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7350",
"triggerID" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"triggerType" : "PUSH"
}, {
"hash" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159895426",
"triggerID" : "612721799",
"triggerType" : "MANUAL"
}, {
"hash" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7350",
"triggerID" : "612721799",
"triggerType" : "MANUAL"
}, {
"hash" : "4d4d973d7e1916f6f4d66e720bcc94488e4efda0",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160167037",
"triggerID" : "4d4d973d7e1916f6f4d66e720bcc94488e4efda0",
"triggerType" : "PUSH"
}, {
"hash" : "4d4d973d7e1916f6f4d66e720bcc94488e4efda0",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7438",
"triggerID" : "4d4d973d7e1916f6f4d66e720bcc94488e4efda0",
"triggerType" : "PUSH"
}, {
"hash" : "32354a866dcb787e5118ce59b908e4947c6ecc77",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7510",
"triggerID" : "32354a866dcb787e5118ce59b908e4947c6ecc77",
"triggerType" : "PUSH"
}, {
"hash" : "32354a866dcb787e5118ce59b908e4947c6ecc77",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160362240",
"triggerID" : "32354a866dcb787e5118ce59b908e4947c6ecc77",
"triggerType" : "PUSH"
}, {
"hash" : "0ac7518a59d0205c3fe65d8bf636f6a8229663bb",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7711",
"triggerID" : "0ac7518a59d0205c3fe65d8bf636f6a8229663bb",
"triggerType" : "PUSH"
}, {
"hash" : "0ac7518a59d0205c3fe65d8bf636f6a8229663bb",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160843171",
"triggerID" : "0ac7518a59d0205c3fe65d8bf636f6a8229663bb",
"triggerType" : "PUSH"
}, {
"hash" : "1688545ed8f78a69806dc7b27410abd85b70319d",
"status" : "CANCELED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160887539",
"triggerID" : "1688545ed8f78a69806dc7b27410abd85b70319d",
"triggerType" : "PUSH"
}, {
"hash" : "1688545ed8f78a69806dc7b27410abd85b70319d",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7725",
"triggerID" : "1688545ed8f78a69806dc7b27410abd85b70319d",
"triggerType" : "PUSH"
}, {
"hash" : "15b7686a0b5f781e91c7cc50448f689d08ca38aa",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "15b7686a0b5f781e91c7cc50448f689d08ca38aa",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f52f4a10b99fa573ffeb63f16491d735cc157a4b UNKNOWN
* 1688545ed8f78a69806dc7b27410abd85b70319d Travis: [CANCELED](https://travis-ci.com/github/flink-ci/flink/builds/160887539) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7725)
* 15b7686a0b5f781e91c7cc50448f689d08ca38aa UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11700: [FLINK-16366]
[table] Introduce executeSql method in TableEnvironment and support many
statements
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11700: [FLINK-16366] [table] Introduce executeSql method in TableEnvironment and support many statements
URL: https://github.com/apache/flink/pull/11700#issuecomment-612000686
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f52f4a10b99fa573ffeb63f16491d735cc157a4b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f52f4a10b99fa573ffeb63f16491d735cc157a4b",
"triggerType" : "PUSH"
}, {
"hash" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7333",
"triggerID" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"triggerType" : "PUSH"
}, {
"hash" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159777430",
"triggerID" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"triggerType" : "PUSH"
}, {
"hash" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159895426",
"triggerID" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"triggerType" : "PUSH"
}, {
"hash" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7350",
"triggerID" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f52f4a10b99fa573ffeb63f16491d735cc157a4b UNKNOWN
* 95353b2b514d755a5da8b6bc222d5850c0354113 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/159895426) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7350)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11700: [FLINK-16366]
[table] Introduce executeSql method in TableEnvironment and support many
statements
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11700: [FLINK-16366] [table] Introduce executeSql method in TableEnvironment and support many statements
URL: https://github.com/apache/flink/pull/11700#issuecomment-612000686
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f52f4a10b99fa573ffeb63f16491d735cc157a4b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f52f4a10b99fa573ffeb63f16491d735cc157a4b",
"triggerType" : "PUSH"
}, {
"hash" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7333",
"triggerID" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"triggerType" : "PUSH"
}, {
"hash" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159777430",
"triggerID" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"triggerType" : "PUSH"
}, {
"hash" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159895426",
"triggerID" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"triggerType" : "PUSH"
}, {
"hash" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7350",
"triggerID" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"triggerType" : "PUSH"
}, {
"hash" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159895426",
"triggerID" : "612721799",
"triggerType" : "MANUAL"
}, {
"hash" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7350",
"triggerID" : "612721799",
"triggerType" : "MANUAL"
}, {
"hash" : "4d4d973d7e1916f6f4d66e720bcc94488e4efda0",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160167037",
"triggerID" : "4d4d973d7e1916f6f4d66e720bcc94488e4efda0",
"triggerType" : "PUSH"
}, {
"hash" : "4d4d973d7e1916f6f4d66e720bcc94488e4efda0",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7438",
"triggerID" : "4d4d973d7e1916f6f4d66e720bcc94488e4efda0",
"triggerType" : "PUSH"
}, {
"hash" : "32354a866dcb787e5118ce59b908e4947c6ecc77",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7510",
"triggerID" : "32354a866dcb787e5118ce59b908e4947c6ecc77",
"triggerType" : "PUSH"
}, {
"hash" : "32354a866dcb787e5118ce59b908e4947c6ecc77",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160362240",
"triggerID" : "32354a866dcb787e5118ce59b908e4947c6ecc77",
"triggerType" : "PUSH"
}, {
"hash" : "0ac7518a59d0205c3fe65d8bf636f6a8229663bb",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7711",
"triggerID" : "0ac7518a59d0205c3fe65d8bf636f6a8229663bb",
"triggerType" : "PUSH"
}, {
"hash" : "0ac7518a59d0205c3fe65d8bf636f6a8229663bb",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160843171",
"triggerID" : "0ac7518a59d0205c3fe65d8bf636f6a8229663bb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f52f4a10b99fa573ffeb63f16491d735cc157a4b UNKNOWN
* 32354a866dcb787e5118ce59b908e4947c6ecc77 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/160362240) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7510)
* 0ac7518a59d0205c3fe65d8bf636f6a8229663bb Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/160843171) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7711)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] godfreyhe commented on a change in pull request #11700:
[FLINK-16366] [table] Introduce executeSql method in TableEnvironment and
support many statements
Posted by GitBox <gi...@apache.org>.
godfreyhe commented on a change in pull request #11700: [FLINK-16366] [table] Introduce executeSql method in TableEnvironment and support many statements
URL: https://github.com/apache/flink/pull/11700#discussion_r410701769
##########
File path: flink-table/flink-table-uber-blink/pom.xml
##########
@@ -113,6 +113,13 @@ under the License.
<include>org.apache.flink:flink-cep_${scala.binary.version}</include>
</includes>
</artifactSet>
+ <relocations>
+ <relocation>
+ <!-- icu4j's dependencies -->
Review comment:
because `flink-table-planner-blink` does not package `table-common` into jar. If we relocate `icu4j` here and users depends on `flink-table-planner-blink` in their project for developing. (that means `table-common` will indirectly dependent on) `ClassNotFoundException` will occur if user executes `TableResult.print()` in IDE.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] godfreyhe commented on a change in pull request #11700:
[FLINK-16366] [table] Introduce executeSql method in TableEnvironment and
support many statements
Posted by GitBox <gi...@apache.org>.
godfreyhe commented on a change in pull request #11700: [FLINK-16366] [table] Introduce executeSql method in TableEnvironment and support many statements
URL: https://github.com/apache/flink/pull/11700#discussion_r407858281
##########
File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/TableEnvironmentImpl.java
##########
@@ -130,7 +139,12 @@
"Unsupported SQL query! sqlUpdate() only accepts a single SQL statement of type " +
"INSERT, CREATE TABLE, DROP TABLE, ALTER TABLE, USE CATALOG, USE [CATALOG.]DATABASE, " +
"CREATE DATABASE, DROP DATABASE, ALTER DATABASE, CREATE FUNCTION, " +
- "DROP FUNCTION, ALTER FUNCTION";
+ "DROP FUNCTION, ALTER FUNCTION, CREATE CATALOG.";
+ private static final String UNSUPPORTED_QUERY_IN_EXECUTE_SQL_MSG =
Review comment:
`INSERT` and `EXPLAIN` will be supported after we correct batch table environment execution behavior which contains two parts: one is "Introduce PlanGenerator" which is [reviewing](https://github.com/apache/flink/pull/11671), and another is "Correct the execution behavior of BatchTableEnvironment" ([FLINK-17126](https://issues.apache.org/jira/browse/FLINK-17126)). `SELECT` will be supported after the design of `FLINK-14807` is ready (depend on `OperatorCoordinator`). If `FLINK-14807` is not ready in the later this month, we can support `SELECT` based on the approach of sql client (get batch result from accumulator , and get streaming result through socket)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] KurtYoung commented on a change in pull request #11700:
[FLINK-16366] [table] Introduce executeSql method in TableEnvironment and
support many statements
Posted by GitBox <gi...@apache.org>.
KurtYoung commented on a change in pull request #11700: [FLINK-16366] [table] Introduce executeSql method in TableEnvironment and support many statements
URL: https://github.com/apache/flink/pull/11700#discussion_r407986520
##########
File path: flink-table/flink-table-api-java/src/main/resources/META-INF/NOTICE
##########
@@ -0,0 +1,10 @@
+flink-table
+Copyright 2014-2020 The Apache Software Foundation
+
+This product includes software developed at
+The Apache Software Foundation (http://www.apache.org/).
+
+This project bundles the following dependencies under the BSD license.
+See bundled license files for details.
+
+- com.ibm.icu:icu4j:65.1
Review comment:
This is only needed when the module bundled such dependency. I don't think `flink-table-api-java` would bundle this, maybe `flink-table-planner` and `flink-table-planner-blink` should do such thing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11700: [FLINK-16366]
[table] Introduce executeSql method in TableEnvironment and support many
statements
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11700: [FLINK-16366] [table] Introduce executeSql method in TableEnvironment and support many statements
URL: https://github.com/apache/flink/pull/11700#issuecomment-612000686
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f52f4a10b99fa573ffeb63f16491d735cc157a4b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f52f4a10b99fa573ffeb63f16491d735cc157a4b",
"triggerType" : "PUSH"
}, {
"hash" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7333",
"triggerID" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"triggerType" : "PUSH"
}, {
"hash" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159777430",
"triggerID" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"triggerType" : "PUSH"
}, {
"hash" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159895426",
"triggerID" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"triggerType" : "PUSH"
}, {
"hash" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7350",
"triggerID" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"triggerType" : "PUSH"
}, {
"hash" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159895426",
"triggerID" : "612721799",
"triggerType" : "MANUAL"
}, {
"hash" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7350",
"triggerID" : "612721799",
"triggerType" : "MANUAL"
}, {
"hash" : "4d4d973d7e1916f6f4d66e720bcc94488e4efda0",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160167037",
"triggerID" : "4d4d973d7e1916f6f4d66e720bcc94488e4efda0",
"triggerType" : "PUSH"
}, {
"hash" : "4d4d973d7e1916f6f4d66e720bcc94488e4efda0",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7438",
"triggerID" : "4d4d973d7e1916f6f4d66e720bcc94488e4efda0",
"triggerType" : "PUSH"
}, {
"hash" : "32354a866dcb787e5118ce59b908e4947c6ecc77",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7510",
"triggerID" : "32354a866dcb787e5118ce59b908e4947c6ecc77",
"triggerType" : "PUSH"
}, {
"hash" : "32354a866dcb787e5118ce59b908e4947c6ecc77",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160362240",
"triggerID" : "32354a866dcb787e5118ce59b908e4947c6ecc77",
"triggerType" : "PUSH"
}, {
"hash" : "0ac7518a59d0205c3fe65d8bf636f6a8229663bb",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7711",
"triggerID" : "0ac7518a59d0205c3fe65d8bf636f6a8229663bb",
"triggerType" : "PUSH"
}, {
"hash" : "0ac7518a59d0205c3fe65d8bf636f6a8229663bb",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160843171",
"triggerID" : "0ac7518a59d0205c3fe65d8bf636f6a8229663bb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f52f4a10b99fa573ffeb63f16491d735cc157a4b UNKNOWN
* 0ac7518a59d0205c3fe65d8bf636f6a8229663bb Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/160843171) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7711)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] KurtYoung commented on a change in pull request #11700:
[FLINK-16366] [table] Introduce executeSql method in TableEnvironment and
support many statements
Posted by GitBox <gi...@apache.org>.
KurtYoung commented on a change in pull request #11700: [FLINK-16366] [table] Introduce executeSql method in TableEnvironment and support many statements
URL: https://github.com/apache/flink/pull/11700#discussion_r407847079
##########
File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/TableEnvironmentImpl.java
##########
@@ -552,6 +566,39 @@ public Table sqlQuery(String query) {
}
}
+ @Override
+ public TableResult executeSql(String statement) {
+ List<Operation> operations = parser.parse(statement);
+
+ if (operations.size() != 1) {
+ throw new TableException(UNSUPPORTED_QUERY_IN_EXECUTE_SQL_MSG);
+ }
+
+ Operation operation = operations.get(0);
+ if (operation instanceof CreateTableOperation ||
Review comment:
duplicated check with the ones inside `executeOperation `
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] godfreyhe commented on a change in pull request #11700:
[FLINK-16366] [table] Introduce executeSql method in TableEnvironment and
support many statements
Posted by GitBox <gi...@apache.org>.
godfreyhe commented on a change in pull request #11700: [FLINK-16366] [table] Introduce executeSql method in TableEnvironment and support many statements
URL: https://github.com/apache/flink/pull/11700#discussion_r408142864
##########
File path: flink-table/flink-table-api-java/src/main/resources/META-INF/NOTICE
##########
@@ -0,0 +1,10 @@
+flink-table
+Copyright 2014-2020 The Apache Software Foundation
+
+This product includes software developed at
+The Apache Software Foundation (http://www.apache.org/).
+
+This project bundles the following dependencies under the BSD license.
+See bundled license files for details.
+
+- com.ibm.icu:icu4j:65.1
Review comment:
do you mean we set its scope as `provided`, and package this jar into uber jar ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] KurtYoung commented on a change in pull request #11700:
[FLINK-16366] [table] Introduce executeSql method in TableEnvironment and
support many statements
Posted by GitBox <gi...@apache.org>.
KurtYoung commented on a change in pull request #11700: [FLINK-16366] [table] Introduce executeSql method in TableEnvironment and support many statements
URL: https://github.com/apache/flink/pull/11700#discussion_r410676182
##########
File path: flink-table/flink-table-common/src/main/resources/META-INF/NOTICE
##########
@@ -0,0 +1,10 @@
+flink-table
+Copyright 2014-2020 The Apache Software Foundation
+
+This product includes software developed at
+The Apache Software Foundation (http://www.apache.org/).
+
+This project bundles the following dependencies under the BSD license.
+See bundled license files for details.
+
+- com.ibm.icu:icu4j:65.1
Review comment:
Seems you need to add these to both planner's module, not here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] KurtYoung commented on a change in pull request #11700:
[FLINK-16366] [table] Introduce executeSql method in TableEnvironment and
support many statements
Posted by GitBox <gi...@apache.org>.
KurtYoung commented on a change in pull request #11700: [FLINK-16366] [table] Introduce executeSql method in TableEnvironment and support many statements
URL: https://github.com/apache/flink/pull/11700#discussion_r407846591
##########
File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/TableEnvironmentImpl.java
##########
@@ -130,7 +139,12 @@
"Unsupported SQL query! sqlUpdate() only accepts a single SQL statement of type " +
"INSERT, CREATE TABLE, DROP TABLE, ALTER TABLE, USE CATALOG, USE [CATALOG.]DATABASE, " +
"CREATE DATABASE, DROP DATABASE, ALTER DATABASE, CREATE FUNCTION, " +
- "DROP FUNCTION, ALTER FUNCTION";
+ "DROP FUNCTION, ALTER FUNCTION, CREATE CATALOG.";
+ private static final String UNSUPPORTED_QUERY_IN_EXECUTE_SQL_MSG =
Review comment:
no `INSERT INTO` support?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11700: [FLINK-16366]
[table] Introduce executeSql method in TableEnvironment and support many
statements
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11700: [FLINK-16366] [table] Introduce executeSql method in TableEnvironment and support many statements
URL: https://github.com/apache/flink/pull/11700#issuecomment-612000686
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f52f4a10b99fa573ffeb63f16491d735cc157a4b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f52f4a10b99fa573ffeb63f16491d735cc157a4b",
"triggerType" : "PUSH"
}, {
"hash" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7333",
"triggerID" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"triggerType" : "PUSH"
}, {
"hash" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159777430",
"triggerID" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"triggerType" : "PUSH"
}, {
"hash" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159895426",
"triggerID" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"triggerType" : "PUSH"
}, {
"hash" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7350",
"triggerID" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"triggerType" : "PUSH"
}, {
"hash" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159895426",
"triggerID" : "612721799",
"triggerType" : "MANUAL"
}, {
"hash" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7350",
"triggerID" : "612721799",
"triggerType" : "MANUAL"
}, {
"hash" : "4d4d973d7e1916f6f4d66e720bcc94488e4efda0",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160167037",
"triggerID" : "4d4d973d7e1916f6f4d66e720bcc94488e4efda0",
"triggerType" : "PUSH"
}, {
"hash" : "4d4d973d7e1916f6f4d66e720bcc94488e4efda0",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7438",
"triggerID" : "4d4d973d7e1916f6f4d66e720bcc94488e4efda0",
"triggerType" : "PUSH"
}, {
"hash" : "32354a866dcb787e5118ce59b908e4947c6ecc77",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7510",
"triggerID" : "32354a866dcb787e5118ce59b908e4947c6ecc77",
"triggerType" : "PUSH"
}, {
"hash" : "32354a866dcb787e5118ce59b908e4947c6ecc77",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160362240",
"triggerID" : "32354a866dcb787e5118ce59b908e4947c6ecc77",
"triggerType" : "PUSH"
}, {
"hash" : "0ac7518a59d0205c3fe65d8bf636f6a8229663bb",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7711",
"triggerID" : "0ac7518a59d0205c3fe65d8bf636f6a8229663bb",
"triggerType" : "PUSH"
}, {
"hash" : "0ac7518a59d0205c3fe65d8bf636f6a8229663bb",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160843171",
"triggerID" : "0ac7518a59d0205c3fe65d8bf636f6a8229663bb",
"triggerType" : "PUSH"
}, {
"hash" : "1688545ed8f78a69806dc7b27410abd85b70319d",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160887539",
"triggerID" : "1688545ed8f78a69806dc7b27410abd85b70319d",
"triggerType" : "PUSH"
}, {
"hash" : "1688545ed8f78a69806dc7b27410abd85b70319d",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7725",
"triggerID" : "1688545ed8f78a69806dc7b27410abd85b70319d",
"triggerType" : "PUSH"
}, {
"hash" : "15b7686a0b5f781e91c7cc50448f689d08ca38aa",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "15b7686a0b5f781e91c7cc50448f689d08ca38aa",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f52f4a10b99fa573ffeb63f16491d735cc157a4b UNKNOWN
* 0ac7518a59d0205c3fe65d8bf636f6a8229663bb Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/160843171) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7711)
* 1688545ed8f78a69806dc7b27410abd85b70319d Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/160887539) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7725)
* 15b7686a0b5f781e91c7cc50448f689d08ca38aa UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11700: [FLINK-16366]
[table] Introduce executeSql method in TableEnvironment and support many
statements
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11700: [FLINK-16366] [table] Introduce executeSql method in TableEnvironment and support many statements
URL: https://github.com/apache/flink/pull/11700#issuecomment-612000686
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f52f4a10b99fa573ffeb63f16491d735cc157a4b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f52f4a10b99fa573ffeb63f16491d735cc157a4b",
"triggerType" : "PUSH"
}, {
"hash" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7333",
"triggerID" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"triggerType" : "PUSH"
}, {
"hash" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159777430",
"triggerID" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"triggerType" : "PUSH"
}, {
"hash" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159895426",
"triggerID" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"triggerType" : "PUSH"
}, {
"hash" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7350",
"triggerID" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"triggerType" : "PUSH"
}, {
"hash" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159895426",
"triggerID" : "612721799",
"triggerType" : "MANUAL"
}, {
"hash" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7350",
"triggerID" : "612721799",
"triggerType" : "MANUAL"
}, {
"hash" : "4d4d973d7e1916f6f4d66e720bcc94488e4efda0",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160167037",
"triggerID" : "4d4d973d7e1916f6f4d66e720bcc94488e4efda0",
"triggerType" : "PUSH"
}, {
"hash" : "4d4d973d7e1916f6f4d66e720bcc94488e4efda0",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7438",
"triggerID" : "4d4d973d7e1916f6f4d66e720bcc94488e4efda0",
"triggerType" : "PUSH"
}, {
"hash" : "32354a866dcb787e5118ce59b908e4947c6ecc77",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7510",
"triggerID" : "32354a866dcb787e5118ce59b908e4947c6ecc77",
"triggerType" : "PUSH"
}, {
"hash" : "32354a866dcb787e5118ce59b908e4947c6ecc77",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160362240",
"triggerID" : "32354a866dcb787e5118ce59b908e4947c6ecc77",
"triggerType" : "PUSH"
}, {
"hash" : "0ac7518a59d0205c3fe65d8bf636f6a8229663bb",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7711",
"triggerID" : "0ac7518a59d0205c3fe65d8bf636f6a8229663bb",
"triggerType" : "PUSH"
}, {
"hash" : "0ac7518a59d0205c3fe65d8bf636f6a8229663bb",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160843171",
"triggerID" : "0ac7518a59d0205c3fe65d8bf636f6a8229663bb",
"triggerType" : "PUSH"
}, {
"hash" : "1688545ed8f78a69806dc7b27410abd85b70319d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1688545ed8f78a69806dc7b27410abd85b70319d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f52f4a10b99fa573ffeb63f16491d735cc157a4b UNKNOWN
* 0ac7518a59d0205c3fe65d8bf636f6a8229663bb Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/160843171) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7711)
* 1688545ed8f78a69806dc7b27410abd85b70319d UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] KurtYoung commented on a change in pull request #11700:
[FLINK-16366] [table] Introduce executeSql method in TableEnvironment and
support many statements
Posted by GitBox <gi...@apache.org>.
KurtYoung commented on a change in pull request #11700: [FLINK-16366] [table] Introduce executeSql method in TableEnvironment and support many statements
URL: https://github.com/apache/flink/pull/11700#discussion_r410676356
##########
File path: flink-table/flink-table-uber-blink/pom.xml
##########
@@ -113,6 +113,13 @@ under the License.
<include>org.apache.flink:flink-cep_${scala.binary.version}</include>
</includes>
</artifactSet>
+ <relocations>
+ <relocation>
+ <!-- icu4j's dependencies -->
Review comment:
Why don't do this in `flink-table-planner-blink` module?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] KurtYoung commented on issue #11700: [FLINK-16366] [table]
Introduce executeSql method in TableEnvironment and support many statements
Posted by GitBox <gi...@apache.org>.
KurtYoung commented on issue #11700: [FLINK-16366] [table] Introduce executeSql method in TableEnvironment and support many statements
URL: https://github.com/apache/flink/pull/11700#issuecomment-616013579
There is an e2e tests failure: "Dependency shading of table modules test"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11700: [FLINK-16366]
[table] Introduce executeSql method in TableEnvironment and support many
statements
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11700: [FLINK-16366] [table] Introduce executeSql method in TableEnvironment and support many statements
URL: https://github.com/apache/flink/pull/11700#issuecomment-612000686
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f52f4a10b99fa573ffeb63f16491d735cc157a4b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f52f4a10b99fa573ffeb63f16491d735cc157a4b",
"triggerType" : "PUSH"
}, {
"hash" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7333",
"triggerID" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"triggerType" : "PUSH"
}, {
"hash" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159777430",
"triggerID" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"triggerType" : "PUSH"
}, {
"hash" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159895426",
"triggerID" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"triggerType" : "PUSH"
}, {
"hash" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7350",
"triggerID" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"triggerType" : "PUSH"
}, {
"hash" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159895426",
"triggerID" : "612721799",
"triggerType" : "MANUAL"
}, {
"hash" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7350",
"triggerID" : "612721799",
"triggerType" : "MANUAL"
}, {
"hash" : "4d4d973d7e1916f6f4d66e720bcc94488e4efda0",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160167037",
"triggerID" : "4d4d973d7e1916f6f4d66e720bcc94488e4efda0",
"triggerType" : "PUSH"
}, {
"hash" : "4d4d973d7e1916f6f4d66e720bcc94488e4efda0",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7438",
"triggerID" : "4d4d973d7e1916f6f4d66e720bcc94488e4efda0",
"triggerType" : "PUSH"
}, {
"hash" : "32354a866dcb787e5118ce59b908e4947c6ecc77",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7510",
"triggerID" : "32354a866dcb787e5118ce59b908e4947c6ecc77",
"triggerType" : "PUSH"
}, {
"hash" : "32354a866dcb787e5118ce59b908e4947c6ecc77",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160362240",
"triggerID" : "32354a866dcb787e5118ce59b908e4947c6ecc77",
"triggerType" : "PUSH"
}, {
"hash" : "0ac7518a59d0205c3fe65d8bf636f6a8229663bb",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7711",
"triggerID" : "0ac7518a59d0205c3fe65d8bf636f6a8229663bb",
"triggerType" : "PUSH"
}, {
"hash" : "0ac7518a59d0205c3fe65d8bf636f6a8229663bb",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160843171",
"triggerID" : "0ac7518a59d0205c3fe65d8bf636f6a8229663bb",
"triggerType" : "PUSH"
}, {
"hash" : "1688545ed8f78a69806dc7b27410abd85b70319d",
"status" : "CANCELED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160887539",
"triggerID" : "1688545ed8f78a69806dc7b27410abd85b70319d",
"triggerType" : "PUSH"
}, {
"hash" : "1688545ed8f78a69806dc7b27410abd85b70319d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7725",
"triggerID" : "1688545ed8f78a69806dc7b27410abd85b70319d",
"triggerType" : "PUSH"
}, {
"hash" : "15b7686a0b5f781e91c7cc50448f689d08ca38aa",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "15b7686a0b5f781e91c7cc50448f689d08ca38aa",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f52f4a10b99fa573ffeb63f16491d735cc157a4b UNKNOWN
* 1688545ed8f78a69806dc7b27410abd85b70319d Travis: [CANCELED](https://travis-ci.com/github/flink-ci/flink/builds/160887539) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7725)
* 15b7686a0b5f781e91c7cc50448f689d08ca38aa UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] KurtYoung closed pull request #11700: [FLINK-16366] [table]
Introduce executeSql method in TableEnvironment and support many statements
Posted by GitBox <gi...@apache.org>.
KurtYoung closed pull request #11700: [FLINK-16366] [table] Introduce executeSql method in TableEnvironment and support many statements
URL: https://github.com/apache/flink/pull/11700
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11700: [FLINK-16366]
[table] Introduce executeSql method in TableEnvironment and support many
statements
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11700: [FLINK-16366] [table] Introduce executeSql method in TableEnvironment and support many statements
URL: https://github.com/apache/flink/pull/11700#issuecomment-612000686
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f52f4a10b99fa573ffeb63f16491d735cc157a4b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f52f4a10b99fa573ffeb63f16491d735cc157a4b",
"triggerType" : "PUSH"
}, {
"hash" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7333",
"triggerID" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"triggerType" : "PUSH"
}, {
"hash" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159777430",
"triggerID" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"triggerType" : "PUSH"
}, {
"hash" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159895426",
"triggerID" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"triggerType" : "PUSH"
}, {
"hash" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7350",
"triggerID" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f52f4a10b99fa573ffeb63f16491d735cc157a4b UNKNOWN
* 445558c0ecbaf13f24c6bcf7fa738fb9fb35d603 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/159777430) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7333)
* 95353b2b514d755a5da8b6bc222d5850c0354113 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/159895426) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7350)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11700: [FLINK-16366]
[table] Introduce executeSql method in TableEnvironment and support many
statements
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11700: [FLINK-16366] [table] Introduce executeSql method in TableEnvironment and support many statements
URL: https://github.com/apache/flink/pull/11700#issuecomment-612000686
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f52f4a10b99fa573ffeb63f16491d735cc157a4b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f52f4a10b99fa573ffeb63f16491d735cc157a4b",
"triggerType" : "PUSH"
}, {
"hash" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7333",
"triggerID" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"triggerType" : "PUSH"
}, {
"hash" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159777430",
"triggerID" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f52f4a10b99fa573ffeb63f16491d735cc157a4b UNKNOWN
* 445558c0ecbaf13f24c6bcf7fa738fb9fb35d603 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/159777430) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7333)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11700: [FLINK-16366]
[table] Introduce executeSql method in TableEnvironment and support many
statements
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11700: [FLINK-16366] [table] Introduce executeSql method in TableEnvironment and support many statements
URL: https://github.com/apache/flink/pull/11700#issuecomment-612000686
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f52f4a10b99fa573ffeb63f16491d735cc157a4b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f52f4a10b99fa573ffeb63f16491d735cc157a4b",
"triggerType" : "PUSH"
}, {
"hash" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7333",
"triggerID" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"triggerType" : "PUSH"
}, {
"hash" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159777430",
"triggerID" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"triggerType" : "PUSH"
}, {
"hash" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159895426",
"triggerID" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"triggerType" : "PUSH"
}, {
"hash" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7350",
"triggerID" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"triggerType" : "PUSH"
}, {
"hash" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159895426",
"triggerID" : "612721799",
"triggerType" : "MANUAL"
}, {
"hash" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7350",
"triggerID" : "612721799",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* f52f4a10b99fa573ffeb63f16491d735cc157a4b UNKNOWN
* 95353b2b514d755a5da8b6bc222d5850c0354113 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/159895426) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7350)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11700: [FLINK-16366]
[table] Introduce executeSql method in TableEnvironment and support many
statements
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11700: [FLINK-16366] [table] Introduce executeSql method in TableEnvironment and support many statements
URL: https://github.com/apache/flink/pull/11700#issuecomment-612000686
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f52f4a10b99fa573ffeb63f16491d735cc157a4b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f52f4a10b99fa573ffeb63f16491d735cc157a4b",
"triggerType" : "PUSH"
}, {
"hash" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7333",
"triggerID" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"triggerType" : "PUSH"
}, {
"hash" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159777430",
"triggerID" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"triggerType" : "PUSH"
}, {
"hash" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159895426",
"triggerID" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"triggerType" : "PUSH"
}, {
"hash" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7350",
"triggerID" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"triggerType" : "PUSH"
}, {
"hash" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159895426",
"triggerID" : "612721799",
"triggerType" : "MANUAL"
}, {
"hash" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7350",
"triggerID" : "612721799",
"triggerType" : "MANUAL"
}, {
"hash" : "4d4d973d7e1916f6f4d66e720bcc94488e4efda0",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160167037",
"triggerID" : "4d4d973d7e1916f6f4d66e720bcc94488e4efda0",
"triggerType" : "PUSH"
}, {
"hash" : "4d4d973d7e1916f6f4d66e720bcc94488e4efda0",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7438",
"triggerID" : "4d4d973d7e1916f6f4d66e720bcc94488e4efda0",
"triggerType" : "PUSH"
}, {
"hash" : "32354a866dcb787e5118ce59b908e4947c6ecc77",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7510",
"triggerID" : "32354a866dcb787e5118ce59b908e4947c6ecc77",
"triggerType" : "PUSH"
}, {
"hash" : "32354a866dcb787e5118ce59b908e4947c6ecc77",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160362240",
"triggerID" : "32354a866dcb787e5118ce59b908e4947c6ecc77",
"triggerType" : "PUSH"
}, {
"hash" : "0ac7518a59d0205c3fe65d8bf636f6a8229663bb",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7711",
"triggerID" : "0ac7518a59d0205c3fe65d8bf636f6a8229663bb",
"triggerType" : "PUSH"
}, {
"hash" : "0ac7518a59d0205c3fe65d8bf636f6a8229663bb",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160843171",
"triggerID" : "0ac7518a59d0205c3fe65d8bf636f6a8229663bb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f52f4a10b99fa573ffeb63f16491d735cc157a4b UNKNOWN
* 0ac7518a59d0205c3fe65d8bf636f6a8229663bb Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/160843171) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7711)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] godfreyhe commented on a change in pull request #11700:
[FLINK-16366] [table] Introduce executeSql method in TableEnvironment and
support many statements
Posted by GitBox <gi...@apache.org>.
godfreyhe commented on a change in pull request #11700: [FLINK-16366] [table] Introduce executeSql method in TableEnvironment and support many statements
URL: https://github.com/apache/flink/pull/11700#discussion_r407859387
##########
File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/TableEnvironmentImpl.java
##########
@@ -552,6 +566,39 @@ public Table sqlQuery(String query) {
}
}
+ @Override
+ public TableResult executeSql(String statement) {
+ List<Operation> operations = parser.parse(statement);
+
+ if (operations.size() != 1) {
+ throw new TableException(UNSUPPORTED_QUERY_IN_EXECUTE_SQL_MSG);
+ }
+
+ Operation operation = operations.get(0);
+ if (operation instanceof CreateTableOperation ||
Review comment:
we can simplify this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11700: [FLINK-16366]
[table] Introduce executeSql method in TableEnvironment and support many
statements
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11700: [FLINK-16366] [table] Introduce executeSql method in TableEnvironment and support many statements
URL: https://github.com/apache/flink/pull/11700#issuecomment-612000686
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f52f4a10b99fa573ffeb63f16491d735cc157a4b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f52f4a10b99fa573ffeb63f16491d735cc157a4b",
"triggerType" : "PUSH"
}, {
"hash" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7333",
"triggerID" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"triggerType" : "PUSH"
}, {
"hash" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159777430",
"triggerID" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"triggerType" : "PUSH"
}, {
"hash" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159895426",
"triggerID" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"triggerType" : "PUSH"
}, {
"hash" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7350",
"triggerID" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"triggerType" : "PUSH"
}, {
"hash" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159895426",
"triggerID" : "612721799",
"triggerType" : "MANUAL"
}, {
"hash" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7350",
"triggerID" : "612721799",
"triggerType" : "MANUAL"
}, {
"hash" : "4d4d973d7e1916f6f4d66e720bcc94488e4efda0",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160167037",
"triggerID" : "4d4d973d7e1916f6f4d66e720bcc94488e4efda0",
"triggerType" : "PUSH"
}, {
"hash" : "4d4d973d7e1916f6f4d66e720bcc94488e4efda0",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7438",
"triggerID" : "4d4d973d7e1916f6f4d66e720bcc94488e4efda0",
"triggerType" : "PUSH"
}, {
"hash" : "32354a866dcb787e5118ce59b908e4947c6ecc77",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "32354a866dcb787e5118ce59b908e4947c6ecc77",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f52f4a10b99fa573ffeb63f16491d735cc157a4b UNKNOWN
* 4d4d973d7e1916f6f4d66e720bcc94488e4efda0 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/160167037) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7438)
* 32354a866dcb787e5118ce59b908e4947c6ecc77 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] godfreyhe commented on a change in pull request #11700:
[FLINK-16366] [table] Introduce executeSql method in TableEnvironment and
support many statements
Posted by GitBox <gi...@apache.org>.
godfreyhe commented on a change in pull request #11700: [FLINK-16366] [table] Introduce executeSql method in TableEnvironment and support many statements
URL: https://github.com/apache/flink/pull/11700#discussion_r410701824
##########
File path: flink-table/flink-table-common/src/main/resources/META-INF/NOTICE
##########
@@ -0,0 +1,10 @@
+flink-table
+Copyright 2014-2020 The Apache Software Foundation
+
+This product includes software developed at
+The Apache Software Foundation (http://www.apache.org/).
+
+This project bundles the following dependencies under the BSD license.
+See bundled license files for details.
+
+- com.ibm.icu:icu4j:65.1
Review comment:
make sense~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11700: [FLINK-16366] [table]
Introduce executeSql method in TableEnvironment and support many statements
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11700: [FLINK-16366] [table] Introduce executeSql method in TableEnvironment and support many statements
URL: https://github.com/apache/flink/pull/11700#issuecomment-611992925
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit f52f4a10b99fa573ffeb63f16491d735cc157a4b (Fri Apr 10 11:33:22 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-16366).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] godfreyhe commented on a change in pull request #11700:
[FLINK-16366] [table] Introduce executeSql method in TableEnvironment and
support many statements
Posted by GitBox <gi...@apache.org>.
godfreyhe commented on a change in pull request #11700: [FLINK-16366] [table] Introduce executeSql method in TableEnvironment and support many statements
URL: https://github.com/apache/flink/pull/11700#discussion_r407858281
##########
File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/TableEnvironmentImpl.java
##########
@@ -130,7 +139,12 @@
"Unsupported SQL query! sqlUpdate() only accepts a single SQL statement of type " +
"INSERT, CREATE TABLE, DROP TABLE, ALTER TABLE, USE CATALOG, USE [CATALOG.]DATABASE, " +
"CREATE DATABASE, DROP DATABASE, ALTER DATABASE, CREATE FUNCTION, " +
- "DROP FUNCTION, ALTER FUNCTION";
+ "DROP FUNCTION, ALTER FUNCTION, CREATE CATALOG.";
+ private static final String UNSUPPORTED_QUERY_IN_EXECUTE_SQL_MSG =
Review comment:
`INSERT` and `EXPLAIN` will be supported after we correct batch table environment execution behavior which contains two parts: one is "Introduce PlanGenerator" which is [reviewing](https://github.com/apache/flink/pull/11671), and another is "Correct the execution behavior of BatchTableEnvironment" ([FLINK-17126](https://issues.apache.org/jira/browse/FLINK-17126)).
`SELECT` will be supported after the design of `FLINK-14807` is ready (depend on `OperatorCoordinator`). If `FLINK-14807` is not ready in the later this month, we can support `SELECT` based on the approach of sql client (get batch result from accumulator , and get streaming result through socket)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11700: [FLINK-16366] [table]
Introduce executeSql method in TableEnvironment and support many statements
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11700: [FLINK-16366] [table] Introduce executeSql method in TableEnvironment and support many statements
URL: https://github.com/apache/flink/pull/11700#issuecomment-612000686
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f52f4a10b99fa573ffeb63f16491d735cc157a4b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f52f4a10b99fa573ffeb63f16491d735cc157a4b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f52f4a10b99fa573ffeb63f16491d735cc157a4b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11700: [FLINK-16366]
[table] Introduce executeSql method in TableEnvironment and support many
statements
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11700: [FLINK-16366] [table] Introduce executeSql method in TableEnvironment and support many statements
URL: https://github.com/apache/flink/pull/11700#issuecomment-612000686
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f52f4a10b99fa573ffeb63f16491d735cc157a4b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f52f4a10b99fa573ffeb63f16491d735cc157a4b",
"triggerType" : "PUSH"
}, {
"hash" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7333",
"triggerID" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"triggerType" : "PUSH"
}, {
"hash" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159777430",
"triggerID" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"triggerType" : "PUSH"
}, {
"hash" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159895426",
"triggerID" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"triggerType" : "PUSH"
}, {
"hash" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7350",
"triggerID" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"triggerType" : "PUSH"
}, {
"hash" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159895426",
"triggerID" : "612721799",
"triggerType" : "MANUAL"
}, {
"hash" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7350",
"triggerID" : "612721799",
"triggerType" : "MANUAL"
}, {
"hash" : "4d4d973d7e1916f6f4d66e720bcc94488e4efda0",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160167037",
"triggerID" : "4d4d973d7e1916f6f4d66e720bcc94488e4efda0",
"triggerType" : "PUSH"
}, {
"hash" : "4d4d973d7e1916f6f4d66e720bcc94488e4efda0",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7438",
"triggerID" : "4d4d973d7e1916f6f4d66e720bcc94488e4efda0",
"triggerType" : "PUSH"
}, {
"hash" : "32354a866dcb787e5118ce59b908e4947c6ecc77",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7510",
"triggerID" : "32354a866dcb787e5118ce59b908e4947c6ecc77",
"triggerType" : "PUSH"
}, {
"hash" : "32354a866dcb787e5118ce59b908e4947c6ecc77",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160362240",
"triggerID" : "32354a866dcb787e5118ce59b908e4947c6ecc77",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f52f4a10b99fa573ffeb63f16491d735cc157a4b UNKNOWN
* 4d4d973d7e1916f6f4d66e720bcc94488e4efda0 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/160167037) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7438)
* 32354a866dcb787e5118ce59b908e4947c6ecc77 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/160362240) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7510)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11700: [FLINK-16366]
[table] Introduce executeSql method in TableEnvironment and support many
statements
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11700: [FLINK-16366] [table] Introduce executeSql method in TableEnvironment and support many statements
URL: https://github.com/apache/flink/pull/11700#issuecomment-612000686
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f52f4a10b99fa573ffeb63f16491d735cc157a4b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f52f4a10b99fa573ffeb63f16491d735cc157a4b",
"triggerType" : "PUSH"
}, {
"hash" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7333",
"triggerID" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"triggerType" : "PUSH"
}, {
"hash" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159777430",
"triggerID" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"triggerType" : "PUSH"
}, {
"hash" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159895426",
"triggerID" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"triggerType" : "PUSH"
}, {
"hash" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7350",
"triggerID" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"triggerType" : "PUSH"
}, {
"hash" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159895426",
"triggerID" : "612721799",
"triggerType" : "MANUAL"
}, {
"hash" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7350",
"triggerID" : "612721799",
"triggerType" : "MANUAL"
}, {
"hash" : "4d4d973d7e1916f6f4d66e720bcc94488e4efda0",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160167037",
"triggerID" : "4d4d973d7e1916f6f4d66e720bcc94488e4efda0",
"triggerType" : "PUSH"
}, {
"hash" : "4d4d973d7e1916f6f4d66e720bcc94488e4efda0",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7438",
"triggerID" : "4d4d973d7e1916f6f4d66e720bcc94488e4efda0",
"triggerType" : "PUSH"
}, {
"hash" : "32354a866dcb787e5118ce59b908e4947c6ecc77",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7510",
"triggerID" : "32354a866dcb787e5118ce59b908e4947c6ecc77",
"triggerType" : "PUSH"
}, {
"hash" : "32354a866dcb787e5118ce59b908e4947c6ecc77",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160362240",
"triggerID" : "32354a866dcb787e5118ce59b908e4947c6ecc77",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f52f4a10b99fa573ffeb63f16491d735cc157a4b UNKNOWN
* 32354a866dcb787e5118ce59b908e4947c6ecc77 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/160362240) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7510)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] godfreyhe commented on a change in pull request #11700:
[FLINK-16366] [table] Introduce executeSql method in TableEnvironment and
support many statements
Posted by GitBox <gi...@apache.org>.
godfreyhe commented on a change in pull request #11700: [FLINK-16366] [table] Introduce executeSql method in TableEnvironment and support many statements
URL: https://github.com/apache/flink/pull/11700#discussion_r408028219
##########
File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/TableResultImpl.java
##########
@@ -0,0 +1,334 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.api.internal;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.core.execution.JobClient;
+import org.apache.flink.table.api.DataTypes;
+import org.apache.flink.table.api.ResultKind;
+import org.apache.flink.table.api.TableColumn;
+import org.apache.flink.table.api.TableResult;
+import org.apache.flink.table.api.TableSchema;
+import org.apache.flink.table.utils.EncodingUtils;
+import org.apache.flink.types.Row;
+import org.apache.flink.util.Preconditions;
+
+import com.ibm.icu.lang.UCharacter;
+import com.ibm.icu.lang.UProperty;
+import org.apache.commons.lang3.StringUtils;
+
+import javax.annotation.Nullable;
+
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.Iterator;
+import java.util.List;
+import java.util.Optional;
+
+/**
+ * Implementation for {@link TableResult}.
+ */
+@Internal
+public class TableResultImpl implements TableResult {
+ public static final TableResult TABLE_RESULT_OK = TableResultImpl.builder()
+ .resultKind(ResultKind.SUCCESS)
+ .tableSchema(TableSchema.builder().field("result", DataTypes.STRING()).build())
+ .data(Collections.singletonList(Row.of("OK")))
+ .build();
+
+ // constants for printing
+ private static final String NULL_COLUMN = "(NULL)";
+ private static final int MAX_COLUMN_WIDTH = 30;
+ private static final String COLUMN_TRUNCATED_FLAG = "...";
+
+ private final JobClient jobClient;
+ private final TableSchema tableSchema;
+ private final ResultKind resultKind;
+ private final Iterator<Row> data;
+
+ private TableResultImpl(
+ @Nullable JobClient jobClient,
+ TableSchema tableSchema,
+ ResultKind resultKind,
+ Iterator<Row> data) {
+ this.jobClient = jobClient;
+ this.tableSchema = Preconditions.checkNotNull(tableSchema, "tableSchema should not be null");
+ this.resultKind = Preconditions.checkNotNull(resultKind, "resultKind should not be null");
+ this.data = Preconditions.checkNotNull(data, "data should not be null");
+ }
+
+ @Override
+ public Optional<JobClient> getJobClient() {
+ return Optional.ofNullable(jobClient);
+ }
+
+ @Override
+ public TableSchema getTableSchema() {
+ return tableSchema;
+ }
+
+ @Override
+ public ResultKind getResultKind() {
+ return resultKind;
+ }
+
+ @Override
+ public Iterator<Row> collect() {
+ return data;
+ }
+
+ @Override
+ public void print() {
+ Iterator<Row> it = collect();
+ doPrint(it);
+ }
+
+ public static Builder builder() {
+ return new Builder();
+ }
+
+ /**
+ * Builder for creating a {@link TableResultImpl}.
+ */
+ public static class Builder {
+ private JobClient jobClient = null;
+ private TableSchema tableSchema = null;
+ private ResultKind resultKind = null;
+ private Iterator<Row> data = null;
+
+ private Builder() {
+ }
+
+ /**
+ * Specifies job client which associates the submitted Flink job.
+ *
+ * @param jobClient a {@link JobClient} for the submitted Flink job.
+ */
+ public Builder jobClient(JobClient jobClient) {
+ this.jobClient = jobClient;
+ return this;
+ }
+
+ /**
+ * Specifies table schema of the execution result.
+ *
+ * @param tableSchema a {@link TableSchema} for the execution result.
+ */
+ public Builder tableSchema(TableSchema tableSchema) {
+ Preconditions.checkNotNull(tableSchema, "tableSchema should not be null");
+ this.tableSchema = tableSchema;
+ return this;
+ }
+
+ /**
+ * Specifies result kind of the execution result.
+ *
+ * @param resultKind a {@link ResultKind} for the execution result.
+ */
+ public Builder resultKind(ResultKind resultKind) {
+ Preconditions.checkNotNull(resultKind, "resultKind should not be null");
+ this.resultKind = resultKind;
+ return this;
+ }
+
+ /**
+ * Specifies an row iterator as the execution result .
+ *
+ * @param rowIterator a row iterator as the execution result.
+ */
+ public Builder data(Iterator<Row> rowIterator) {
+ Preconditions.checkNotNull(rowIterator, "rowIterator should not be null");
+ this.data = rowIterator;
+ return this;
+ }
+
+ /**
+ * Specifies an row list as the execution result .
+ *
+ * @param rowList a row list as the execution result.
+ */
+ public Builder data(List<Row> rowList) {
+ Preconditions.checkNotNull(rowList, "listRows should not be null");
+ this.data = rowList.iterator();
+ return this;
+ }
+
+ /**
+ * Returns a {@link TableResult} instance.
+ */
+ public TableResult build() {
+ return new TableResultImpl(jobClient, tableSchema, resultKind, data);
+ }
+ }
+
+ /**
+ * Displays the result in a tableau form.
+ * For example:
+ * +-------------+---------+-------------+
+ * | boolean_col | int_col | varchar_col |
+ * +-------------+---------+-------------+
+ * | true | 1 | abc |
+ * | false | 2 | def |
+ * | (NULL) | (NULL) | (NULL) |
+ * +-------------+---------+-------------+
+ * 3 row(s) in result
+ *
+ * <p>Changelog is not supported until FLINK-16998 is finished.
+ */
+ private void doPrint(Iterator<Row> it) {
Review comment:
Maybe we can move this to `flink-table-common`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] godfreyhe commented on issue #11700: [FLINK-16366] [table]
Introduce executeSql method in TableEnvironment and support many statements
Posted by GitBox <gi...@apache.org>.
godfreyhe commented on issue #11700: [FLINK-16366] [table] Introduce executeSql method in TableEnvironment and support many statements
URL: https://github.com/apache/flink/pull/11700#issuecomment-615882267
I will merge the last three commits into the first one once it's approved
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11700: [FLINK-16366]
[table] Introduce executeSql method in TableEnvironment and support many
statements
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11700: [FLINK-16366] [table] Introduce executeSql method in TableEnvironment and support many statements
URL: https://github.com/apache/flink/pull/11700#issuecomment-612000686
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f52f4a10b99fa573ffeb63f16491d735cc157a4b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f52f4a10b99fa573ffeb63f16491d735cc157a4b",
"triggerType" : "PUSH"
}, {
"hash" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7333",
"triggerID" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"triggerType" : "PUSH"
}, {
"hash" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159777430",
"triggerID" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"triggerType" : "PUSH"
}, {
"hash" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159895426",
"triggerID" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"triggerType" : "PUSH"
}, {
"hash" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7350",
"triggerID" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f52f4a10b99fa573ffeb63f16491d735cc157a4b UNKNOWN
* 95353b2b514d755a5da8b6bc222d5850c0354113 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/159895426) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7350)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11700: [FLINK-16366]
[table] Introduce executeSql method in TableEnvironment and support many
statements
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11700: [FLINK-16366] [table] Introduce executeSql method in TableEnvironment and support many statements
URL: https://github.com/apache/flink/pull/11700#issuecomment-612000686
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f52f4a10b99fa573ffeb63f16491d735cc157a4b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f52f4a10b99fa573ffeb63f16491d735cc157a4b",
"triggerType" : "PUSH"
}, {
"hash" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7333",
"triggerID" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"triggerType" : "PUSH"
}, {
"hash" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159777430",
"triggerID" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"triggerType" : "PUSH"
}, {
"hash" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159895426",
"triggerID" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"triggerType" : "PUSH"
}, {
"hash" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7350",
"triggerID" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"triggerType" : "PUSH"
}, {
"hash" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159895426",
"triggerID" : "612721799",
"triggerType" : "MANUAL"
}, {
"hash" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7350",
"triggerID" : "612721799",
"triggerType" : "MANUAL"
}, {
"hash" : "4d4d973d7e1916f6f4d66e720bcc94488e4efda0",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160167037",
"triggerID" : "4d4d973d7e1916f6f4d66e720bcc94488e4efda0",
"triggerType" : "PUSH"
}, {
"hash" : "4d4d973d7e1916f6f4d66e720bcc94488e4efda0",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7438",
"triggerID" : "4d4d973d7e1916f6f4d66e720bcc94488e4efda0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f52f4a10b99fa573ffeb63f16491d735cc157a4b UNKNOWN
* 4d4d973d7e1916f6f4d66e720bcc94488e4efda0 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/160167037) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7438)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] KurtYoung commented on a change in pull request #11700:
[FLINK-16366] [table] Introduce executeSql method in TableEnvironment and
support many statements
Posted by GitBox <gi...@apache.org>.
KurtYoung commented on a change in pull request #11700: [FLINK-16366] [table] Introduce executeSql method in TableEnvironment and support many statements
URL: https://github.com/apache/flink/pull/11700#discussion_r407844732
##########
File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/TableResult.java
##########
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.api;
+
+import org.apache.flink.core.execution.JobClient;
+import org.apache.flink.types.Row;
+
+import java.util.Iterator;
+import java.util.Optional;
+
+/**
+ * A TableResult is the representation of the statement execution result.
+ */
Review comment:
add `@PublicEvolving`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11700: [FLINK-16366]
[table] Introduce executeSql method in TableEnvironment and support many
statements
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11700: [FLINK-16366] [table] Introduce executeSql method in TableEnvironment and support many statements
URL: https://github.com/apache/flink/pull/11700#issuecomment-612000686
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f52f4a10b99fa573ffeb63f16491d735cc157a4b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f52f4a10b99fa573ffeb63f16491d735cc157a4b",
"triggerType" : "PUSH"
}, {
"hash" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7333",
"triggerID" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"triggerType" : "PUSH"
}, {
"hash" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159777430",
"triggerID" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"triggerType" : "PUSH"
}, {
"hash" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159895426",
"triggerID" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"triggerType" : "PUSH"
}, {
"hash" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7350",
"triggerID" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"triggerType" : "PUSH"
}, {
"hash" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159895426",
"triggerID" : "612721799",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* f52f4a10b99fa573ffeb63f16491d735cc157a4b UNKNOWN
* 95353b2b514d755a5da8b6bc222d5850c0354113 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/159895426) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7350)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11700: [FLINK-16366]
[table] Introduce executeSql method in TableEnvironment and support many
statements
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11700: [FLINK-16366] [table] Introduce executeSql method in TableEnvironment and support many statements
URL: https://github.com/apache/flink/pull/11700#issuecomment-612000686
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f52f4a10b99fa573ffeb63f16491d735cc157a4b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f52f4a10b99fa573ffeb63f16491d735cc157a4b",
"triggerType" : "PUSH"
}, {
"hash" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7333",
"triggerID" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"triggerType" : "PUSH"
}, {
"hash" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159777430",
"triggerID" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"triggerType" : "PUSH"
}, {
"hash" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159895426",
"triggerID" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"triggerType" : "PUSH"
}, {
"hash" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7350",
"triggerID" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"triggerType" : "PUSH"
}, {
"hash" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159895426",
"triggerID" : "612721799",
"triggerType" : "MANUAL"
}, {
"hash" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7350",
"triggerID" : "612721799",
"triggerType" : "MANUAL"
}, {
"hash" : "4d4d973d7e1916f6f4d66e720bcc94488e4efda0",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160167037",
"triggerID" : "4d4d973d7e1916f6f4d66e720bcc94488e4efda0",
"triggerType" : "PUSH"
}, {
"hash" : "4d4d973d7e1916f6f4d66e720bcc94488e4efda0",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7438",
"triggerID" : "4d4d973d7e1916f6f4d66e720bcc94488e4efda0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f52f4a10b99fa573ffeb63f16491d735cc157a4b UNKNOWN
* 4d4d973d7e1916f6f4d66e720bcc94488e4efda0 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/160167037) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7438)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11700: [FLINK-16366]
[table] Introduce executeSql method in TableEnvironment and support many
statements
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11700: [FLINK-16366] [table] Introduce executeSql method in TableEnvironment and support many statements
URL: https://github.com/apache/flink/pull/11700#issuecomment-612000686
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f52f4a10b99fa573ffeb63f16491d735cc157a4b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f52f4a10b99fa573ffeb63f16491d735cc157a4b",
"triggerType" : "PUSH"
}, {
"hash" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7333",
"triggerID" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"triggerType" : "PUSH"
}, {
"hash" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159777430",
"triggerID" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"triggerType" : "PUSH"
}, {
"hash" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159895426",
"triggerID" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"triggerType" : "PUSH"
}, {
"hash" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7350",
"triggerID" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"triggerType" : "PUSH"
}, {
"hash" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159895426",
"triggerID" : "612721799",
"triggerType" : "MANUAL"
}, {
"hash" : "95353b2b514d755a5da8b6bc222d5850c0354113",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7350",
"triggerID" : "612721799",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* f52f4a10b99fa573ffeb63f16491d735cc157a4b UNKNOWN
* 95353b2b514d755a5da8b6bc222d5850c0354113 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/159895426) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7350)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] KurtYoung commented on a change in pull request #11700:
[FLINK-16366] [table] Introduce executeSql method in TableEnvironment and
support many statements
Posted by GitBox <gi...@apache.org>.
KurtYoung commented on a change in pull request #11700: [FLINK-16366] [table] Introduce executeSql method in TableEnvironment and support many statements
URL: https://github.com/apache/flink/pull/11700#discussion_r408116084
##########
File path: flink-table/flink-table-api-java/src/main/resources/META-INF/NOTICE
##########
@@ -0,0 +1,10 @@
+flink-table
+Copyright 2014-2020 The Apache Software Foundation
+
+This product includes software developed at
+The Apache Software Foundation (http://www.apache.org/).
+
+This project bundles the following dependencies under the BSD license.
+See bundled license files for details.
+
+- com.ibm.icu:icu4j:65.1
Review comment:
Could we have this dependency in `flink-table-api-java` but only bundle it in planner uber jar?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] KurtYoung commented on a change in pull request #11700:
[FLINK-16366] [table] Introduce executeSql method in TableEnvironment and
support many statements
Posted by GitBox <gi...@apache.org>.
KurtYoung commented on a change in pull request #11700: [FLINK-16366] [table] Introduce executeSql method in TableEnvironment and support many statements
URL: https://github.com/apache/flink/pull/11700#discussion_r407845053
##########
File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/TableEnvironmentImpl.java
##########
@@ -130,7 +139,12 @@
"Unsupported SQL query! sqlUpdate() only accepts a single SQL statement of type " +
"INSERT, CREATE TABLE, DROP TABLE, ALTER TABLE, USE CATALOG, USE [CATALOG.]DATABASE, " +
"CREATE DATABASE, DROP DATABASE, ALTER DATABASE, CREATE FUNCTION, " +
- "DROP FUNCTION, ALTER FUNCTION";
+ "DROP FUNCTION, ALTER FUNCTION, CREATE CATALOG.";
+ private static final String UNSUPPORTED_QUERY_IN_EXECUTE_SQL_MSG =
Review comment:
no `SELECT` query?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11700: [FLINK-16366]
[table] Introduce executeSql method in TableEnvironment and support many
statements
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11700: [FLINK-16366] [table] Introduce executeSql method in TableEnvironment and support many statements
URL: https://github.com/apache/flink/pull/11700#issuecomment-612000686
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f52f4a10b99fa573ffeb63f16491d735cc157a4b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f52f4a10b99fa573ffeb63f16491d735cc157a4b",
"triggerType" : "PUSH"
}, {
"hash" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7333",
"triggerID" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"triggerType" : "PUSH"
}, {
"hash" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/159777430",
"triggerID" : "445558c0ecbaf13f24c6bcf7fa738fb9fb35d603",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f52f4a10b99fa573ffeb63f16491d735cc157a4b UNKNOWN
* 445558c0ecbaf13f24c6bcf7fa738fb9fb35d603 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/159777430) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=7333)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services