[jira] [Updated] (STORM-3604) HealthChecker should print out error message when it fails

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/STORM-3604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

ASF GitHub Bot updated STORM-3604:
----------------------------------
    Labels: pull-request-available  (was: )

> HealthChecker should print out error message when it fails
> ----------------------------------------------------------
>
>                 Key: STORM-3604
>                 URL: https://issues.apache.org/jira/browse/STORM-3604
>             Project: Apache Storm
>          Issue Type: Improvement
>            Reporter: Ethan Li
>            Assignee: Ethan Li
>            Priority: Minor
>              Labels: pull-request-available
>
> Currently in the code https://github.com/apache/storm/blob/master/storm-server/src/main/java/org/apache/storm/healthcheck/HealthChecker.java#L122-L130
> {code:java}
>            if (process.exitValue() != 0) {
>                 String str;
>                 InputStream stdin = process.getInputStream();
>                 BufferedReader reader = new BufferedReader(new InputStreamReader(stdin));
>                 while ((str = reader.readLine()) != null) {
>                     if (str.startsWith("ERROR")) {
>                         LOG.warn("The healthcheck process {} exited with code {}", script, process.exitValue());
>                         return FAILED;
>                     }
>                 }
>                 return FAILED_WITH_EXIT_CODE;
>             }
> {code}
> The healthcheck doesn't really print out the error message so it's not easy to debug when healthcheck fails. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)