You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/07/30 04:34:06 UTC

[GitHub] [airflow] uranusjr commented on a change in pull request #17322: Added print statements for clarity in provider yaml checks

uranusjr commented on a change in pull request #17322:
URL: https://github.com/apache/airflow/pull/17322#discussion_r679640450



##########
File path: scripts/ci/pre_commit/pre_commit_check_provider_yaml_files.py
##########
@@ -119,13 +119,13 @@ def assert_sets_equal(set1, set2):
 
     lines = []
     if difference1:
-        lines.append('Items in the first set but not the second:')
+        lines.append('    -- Items in the left set but not the right:')
         for item in sorted(difference1):
-            lines.append(repr(item))
+            lines.append('       ' + repr(item))

Review comment:
       ```suggestion
               lines.append(f'       {item!r}')
   ```

##########
File path: scripts/ci/pre_commit/pre_commit_check_provider_yaml_files.py
##########
@@ -119,13 +119,13 @@ def assert_sets_equal(set1, set2):
 
     lines = []
     if difference1:
-        lines.append('Items in the first set but not the second:')
+        lines.append('    -- Items in the left set but not the right:')
         for item in sorted(difference1):
-            lines.append(repr(item))
+            lines.append('       ' + repr(item))
     if difference2:
-        lines.append('Items in the second set but not the first:')
+        lines.append('    -- Items in the right set but not the left:')
         for item in sorted(difference2):
-            lines.append(repr(item))
+            lines.append('       ' + repr(item))

Review comment:
       ```suggestion
               lines.append(f'       {item!r}')
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org