You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Daniel Siegmann (JIRA)" <ji...@codehaus.org> on 2007/08/23 21:36:47 UTC

[jira] Created: (MASSEMBLY-236) assembly:assembly resolves excluded artifacts

assembly:assembly resolves excluded artifacts
---------------------------------------------

                 Key: MASSEMBLY-236
                 URL: http://jira.codehaus.org/browse/MASSEMBLY-236
             Project: Maven 2.x Assembly Plugin
          Issue Type: Bug
            Reporter: Daniel Siegmann
            Priority: Minor


When creating an assembly, excluded dependencies are still resolved. If the artifact can't be resolved, the assembly fails, even though this artifact should be excluded.

This behavior can be seen in the test project attached to issue MASSEMBLY-235.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MASSEMBLY-236) assembly:assembly resolves excluded artifacts

Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MASSEMBLY-236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

John Casey updated MASSEMBLY-236:
---------------------------------

    Fix Version/s: 2.2-beta-2

> assembly:assembly resolves excluded artifacts
> ---------------------------------------------
>
>                 Key: MASSEMBLY-236
>                 URL: http://jira.codehaus.org/browse/MASSEMBLY-236
>             Project: Maven 2.x Assembly Plugin
>          Issue Type: Bug
>            Reporter: Daniel Siegmann
>            Priority: Minor
>             Fix For: 2.2-beta-2
>
>
> When creating an assembly, excluded dependencies are still resolved. If the artifact can't be resolved, the assembly fails, even though this artifact should be excluded.
> This behavior can be seen in the test project attached to issue MASSEMBLY-235.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MASSEMBLY-236) assembly:assembly resolves excluded artifacts

Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MASSEMBLY-236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_105780 ] 

John Casey commented on MASSEMBLY-236:
--------------------------------------

Did you mean to say that the assembly plugin is failing to respect the <exclusions/> section of a dependency specification? If so, this is not included in the test case attached to MASSEMBLY-235 (which has been integrated into the assembly plugin's integration tests).

Please clarify the problem you're having here, and I'll do my best to address it.

> assembly:assembly resolves excluded artifacts
> ---------------------------------------------
>
>                 Key: MASSEMBLY-236
>                 URL: http://jira.codehaus.org/browse/MASSEMBLY-236
>             Project: Maven 2.x Assembly Plugin
>          Issue Type: Bug
>            Reporter: Daniel Siegmann
>            Priority: Minor
>             Fix For: 2.2-beta-2
>
>
> When creating an assembly, excluded dependencies are still resolved. If the artifact can't be resolved, the assembly fails, even though this artifact should be excluded.
> This behavior can be seen in the test project attached to issue MASSEMBLY-235.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MASSEMBLY-236) assembly:assembly resolves excluded artifacts

Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MASSEMBLY-236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

John Casey updated MASSEMBLY-236:
---------------------------------

    Fix Version/s:     (was: 2.2)
                   2.2-beta-3

> assembly:assembly resolves excluded artifacts
> ---------------------------------------------
>
>                 Key: MASSEMBLY-236
>                 URL: http://jira.codehaus.org/browse/MASSEMBLY-236
>             Project: Maven 2.x Assembly Plugin
>          Issue Type: Bug
>            Reporter: Daniel Siegmann
>            Assignee: John Casey
>            Priority: Minor
>             Fix For: 2.2-beta-3
>
>
> When creating an assembly, excluded dependencies are still resolved. If the artifact can't be resolved, the assembly fails, even though this artifact should be excluded.
> This behavior can be seen in the test project attached to issue MASSEMBLY-235.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Issue Comment Edited: (MASSEMBLY-236) assembly:assembly resolves excluded artifacts

Posted by "Daniel Siegmann (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MASSEMBLY-236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_105797 ] 

Daniel Siegmann edited comment on MASSEMBLY-236 at 8/27/07 12:50 PM:
---------------------------------------------------------------------

In the test case from MASSEMBLY-235, the assembly included just three jars from a dependency set. This set did not include xmlenc, yet that dependency must have been resolved (since the resolution failed). There was no reason to be resolving the dependency in this case.

I don't think I should've filed this as a bug, since it's not wrong necessarily. However, MASSEMBLY-235 wouldn't have been exposed in my test case if only the included dependencies were resolved. Probably this is not very important anyway (except that it allowed MASSEMBLY-235 to be exposed).

Sorry for the lack of clarity.


 was:
In the test case from MASSEMBLY-235, we are included just three jars from a dependency set. This set did not include xmlenc, yet that dependency must have been resolved (since the resolution failed). There was no reason to be resolving the dependency in this case.

I don't think I should've filed this as a bug, since it's not wrong necessarily. However, MASSEMBLY-235 wouldn't have been exposed in my test case if only the included dependencies were resolved. Probably this is not very important anyway (except that it allowed MASSEMBLY-235 to be exposed).

Sorry for the lack of clarity.

> assembly:assembly resolves excluded artifacts
> ---------------------------------------------
>
>                 Key: MASSEMBLY-236
>                 URL: http://jira.codehaus.org/browse/MASSEMBLY-236
>             Project: Maven 2.x Assembly Plugin
>          Issue Type: Bug
>            Reporter: Daniel Siegmann
>            Priority: Minor
>             Fix For: 2.2-beta-2
>
>
> When creating an assembly, excluded dependencies are still resolved. If the artifact can't be resolved, the assembly fails, even though this artifact should be excluded.
> This behavior can be seen in the test project attached to issue MASSEMBLY-235.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (MASSEMBLY-236) assembly:assembly resolves excluded artifacts

Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MASSEMBLY-236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

John Casey closed MASSEMBLY-236.
--------------------------------

      Assignee: John Casey
    Resolution: Incomplete

If this is still happening in 2.2-beta-2, please attach a test project that will express the behavior, along with instructions on how to run it, then reopen this issue.

Thanks.


> assembly:assembly resolves excluded artifacts
> ---------------------------------------------
>
>                 Key: MASSEMBLY-236
>                 URL: http://jira.codehaus.org/browse/MASSEMBLY-236
>             Project: Maven 2.x Assembly Plugin
>          Issue Type: Bug
>            Reporter: Daniel Siegmann
>            Assignee: John Casey
>            Priority: Minor
>             Fix For: 2.2
>
>
> When creating an assembly, excluded dependencies are still resolved. If the artifact can't be resolved, the assembly fails, even though this artifact should be excluded.
> This behavior can be seen in the test project attached to issue MASSEMBLY-235.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MASSEMBLY-236) assembly:assembly resolves excluded artifacts

Posted by "Daniel Siegmann (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MASSEMBLY-236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_105797 ] 

Daniel Siegmann commented on MASSEMBLY-236:
-------------------------------------------

In the test case from MASSEMBLY-235, we are included just three jars from a dependency set. This set did not include xmlenc, yet that dependency must have been resolved (since the resolution failed). There was no reason to be resolving the dependency in this case.

I don't think I should've filed this as a bug, since it's not wrong necessarily. However, MASSEMBLY-235 wouldn't have been exposed in my test case if only the included dependencies were resolved. Probably this is not very important anyway (except that it allowed MASSEMBLY-235 to be exposed).

Sorry for the lack of clarity.

> assembly:assembly resolves excluded artifacts
> ---------------------------------------------
>
>                 Key: MASSEMBLY-236
>                 URL: http://jira.codehaus.org/browse/MASSEMBLY-236
>             Project: Maven 2.x Assembly Plugin
>          Issue Type: Bug
>            Reporter: Daniel Siegmann
>            Priority: Minor
>             Fix For: 2.2-beta-2
>
>
> When creating an assembly, excluded dependencies are still resolved. If the artifact can't be resolved, the assembly fails, even though this artifact should be excluded.
> This behavior can be seen in the test project attached to issue MASSEMBLY-235.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MASSEMBLY-236) assembly:assembly resolves excluded artifacts

Posted by "Keith Barlow (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MASSEMBLY-236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=188980#action_188980 ] 

Keith Barlow commented on MASSEMBLY-236:
----------------------------------------

I have tried versions 2.2-beta-3, and beta-4 and this still appears to be an issue... is there any idea when this might be addressed?

It looks like there is some confusion above so I thought this might clarify.  When a pom declares a dependency such as log4j which has dependencies that are not in the maven repository, one can add them to the exclusion listing... however the maven-assembly-plugin does not seem to be ignoring them as it should when running a the jar-with-dependencies task and the build fails:

		<dependency>
			<groupId>log4j</groupId>
			<artifactId>log4j</artifactId>
			<version>1.2.15</version>
			<exclusions>
				<exclusion>
					<artifactId>jms</artifactId>
					<groupId>javax.jms</groupId>
				</exclusion>
				<exclusion>
					<artifactId>jmxtools</artifactId>
					<groupId>com.sun.jdmk</groupId>
				</exclusion>
				<exclusion>
					<artifactId>jmxri</artifactId>
					<groupId>com.sun.jmx</groupId>
				</exclusion>
			</exclusions>
		</dependency>

Thanks.

Keith

> assembly:assembly resolves excluded artifacts
> ---------------------------------------------
>
>                 Key: MASSEMBLY-236
>                 URL: http://jira.codehaus.org/browse/MASSEMBLY-236
>             Project: Maven 2.x Assembly Plugin
>          Issue Type: Bug
>            Reporter: Daniel Siegmann
>            Assignee: John Casey
>            Priority: Minor
>             Fix For: 2.2-beta-3
>
>
> When creating an assembly, excluded dependencies are still resolved. If the artifact can't be resolved, the assembly fails, even though this artifact should be excluded.
> This behavior can be seen in the test project attached to issue MASSEMBLY-235.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira