You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/03/06 22:43:29 UTC

[GitHub] [spark] dongjoon-hyun opened a new pull request #31767: [SPARK-34650][BUILD][SS] Exclude zstd-jni transitive dependency from Kafka Client

dongjoon-hyun opened a new pull request #31767:
URL: https://github.com/apache/spark/pull/31767


   ### What changes were proposed in this pull request?
   
   This PR aims to exclude `zstd-jni` transitive dependency from kafka-client.
   
   ### Why are the changes needed?
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you propose a new API, clarify the use case for a new API.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   
   
   ### Does this PR introduce _any_ user-facing change?
   <!--
   Note that it means *any* user-facing change including all aspects such as the documentation fix.
   If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
   If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
   If no, write 'No'.
   -->
   
   
   ### How was this patch tested?
   <!--
   If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
   If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
   If tests were not added, please describe why they were not added and/or why it was difficult to add.
   -->
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] dongjoon-hyun commented on pull request #31767: [SPARK-34650][BUILD][SS] Exclude zstd-jni transitive dependency from Kafka Client

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #31767:
URL: https://github.com/apache/spark/pull/31767#issuecomment-792297641


   Thank you, @viirya and @HyukjinKwon .


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #31767: [SPARK-34650][BUILD][SS] Exclude zstd-jni transitive dependency from Kafka Client

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31767:
URL: https://github.com/apache/spark/pull/31767#issuecomment-792162069


   **[Test build #135837 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135837/testReport)** for PR 31767 at commit [`856a70b`](https://github.com/apache/spark/commit/856a70bf3c2c175f18cd58739737828033f1b948).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #31767: [SPARK-34650][BUILD][SS] Exclude zstd-jni transitive dependency from Kafka Client

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31767:
URL: https://github.com/apache/spark/pull/31767#issuecomment-792117851


   **[Test build #135837 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135837/testReport)** for PR 31767 at commit [`856a70b`](https://github.com/apache/spark/commit/856a70bf3c2c175f18cd58739737828033f1b948).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #31767: [SPARK-34650][BUILD][SS] Exclude zstd-jni transitive dependency from Kafka Client

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31767:
URL: https://github.com/apache/spark/pull/31767#issuecomment-792163050


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135837/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #31767: [SPARK-34650][BUILD][SS] Exclude zstd-jni transitive dependency from Kafka Client

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31767:
URL: https://github.com/apache/spark/pull/31767#issuecomment-792163050


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135837/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon closed pull request #31767: [SPARK-34650][BUILD][SS] Exclude zstd-jni transitive dependency from Kafka Client

Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #31767:
URL: https://github.com/apache/spark/pull/31767


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #31767: [SPARK-34650][BUILD][SS] Exclude zstd-jni transitive dependency from Kafka Client

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31767:
URL: https://github.com/apache/spark/pull/31767#issuecomment-792117851


   **[Test build #135837 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135837/testReport)** for PR 31767 at commit [`856a70b`](https://github.com/apache/spark/commit/856a70bf3c2c175f18cd58739737828033f1b948).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #31767: [SPARK-34650][BUILD][SS] Exclude zstd-jni transitive dependency from Kafka Client

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31767:
URL: https://github.com/apache/spark/pull/31767#issuecomment-792139097


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40419/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #31767: [SPARK-34650][BUILD][SS] Exclude zstd-jni transitive dependency from Kafka Client

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31767:
URL: https://github.com/apache/spark/pull/31767#issuecomment-792139097


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40419/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #31767: [SPARK-34650][BUILD][SS] Exclude zstd-jni transitive dependency from Kafka Client

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31767:
URL: https://github.com/apache/spark/pull/31767#issuecomment-792127521


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40419/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #31767: [SPARK-34650][BUILD][SS] Exclude zstd-jni transitive dependency from Kafka Client

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31767:
URL: https://github.com/apache/spark/pull/31767#issuecomment-792134141


   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40419/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] dongjoon-hyun commented on pull request #31767: [SPARK-34650][BUILD][SS] Exclude zstd-jni transitive dependency from Kafka Client

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #31767:
URL: https://github.com/apache/spark/pull/31767#issuecomment-792132564


   Could you review this please, @viirya ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on pull request #31767: [SPARK-34650][BUILD][SS] Exclude zstd-jni transitive dependency from Kafka Client

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #31767:
URL: https://github.com/apache/spark/pull/31767#issuecomment-792210139


   Merged to master.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org