[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #3984: ARTEMIS-3719 DLA and expiry incorrect w/temp-queue-namespace

[GitBox <gi...@apache.org>]

clebertsuconic commented on a change in pull request #3984:
URL: https://github.com/apache/activemq-artemis/pull/3984#discussion_r826103199



##########
File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java
##########
@@ -1975,19 +1970,14 @@ public void expire(final MessageReference ref) throws Exception {
 
    @Override
    public void expire(final MessageReference ref, final ServerConsumer consumer) throws Exception {
-      SimpleString messageExpiryAddress = expiryAddressFromMessageAddress(ref);
-      if (messageExpiryAddress == null) {
-         messageExpiryAddress = expiryAddressFromAddressSettings(ref);
-      }
-
-      if (messageExpiryAddress != null) {
+      if (addressSettings.getExpiryAddress() != null) {

Review comment:
       We used to get the address from the message because of original queue versus current queue.
   
   I believe we would have tests validating that.. (if no testa re failing, there's still a semantic change here I guess we need to be careful).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org