[GitHub] [arrow] milesgranger commented on a diff in pull request #14696: ARROW-18282: [C++][Python] Support step >= 1 in list_slice kernel

[GitBox <gi...@apache.org>]

milesgranger commented on code in PR #14696:
URL: https://github.com/apache/arrow/pull/14696#discussion_r1038298253


##########
cpp/src/arrow/compute/kernels/scalar_nested.cc:
##########
@@ -96,6 +97,15 @@ std::string ToString(const std::optional<T>& o) {
   return o.has_value() ? ToChars(*o) : "(nullopt)";
 }
 
+int64_t MaxSliceLength(const int64_t start, const int64_t stop, const int64_t step) {
+  const auto startf = static_cast<float>(start);
+  const auto stopf = static_cast<float>(stop);
+  const auto stepf = static_cast<float>(step);
+
+  auto length = std::ceil((stopf - startf) / stepf);
+  return static_cast<int64_t>(length);
+}

Review Comment:
   Hmm, I get a `Fatal Python error: Floating point exception` locally, when switching to that. Will try again later this weekend/early next week. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org