You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/04/27 11:02:45 UTC

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4705: Improve logs on KVMHAVMActivityChecker

sureshanaparti commented on a change in pull request #4705:
URL: https://github.com/apache/cloudstack/pull/4705#discussion_r621101431



##########
File path: plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/KVMHAVMActivityChecker.java
##########
@@ -52,11 +52,14 @@ public Boolean checkingHB() {
         cmd.add("-t", String.valueOf(String.valueOf(System.currentTimeMillis() / 1000)));
         cmd.add("-d", String.valueOf(suspectTimeInSeconds));
         OutputInterpreter.OneLineParser parser = new OutputInterpreter.OneLineParser();
+

Review comment:
       @GutoVeronezi may be you can also improve this method name,  `checkingHB()` => _checkingHeartBeat()_




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org