You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Sylvain Lebresne (JIRA)" <ji...@apache.org> on 2013/06/18 15:59:20 UTC

[jira] [Commented] (CASSANDRA-5639) Update CREATE CUSTOM INDEX syntax to match new CREATE TRIGGER syntax

    [ https://issues.apache.org/jira/browse/CASSANDRA-5639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13686731#comment-13686731 ] 

Sylvain Lebresne commented on CASSANDRA-5639:
---------------------------------------------

Code lgtm, though let's add a mention to the news file. And for the textile file, it might be worth a minor bump of the version with a mention in the file changelog section (Note that II think anyone is really using that syntax yet, but it'll be cleaner).
                
> Update CREATE CUSTOM INDEX syntax to match new CREATE TRIGGER syntax
> --------------------------------------------------------------------
>
>                 Key: CASSANDRA-5639
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-5639
>             Project: Cassandra
>          Issue Type: Improvement
>    Affects Versions: 1.2.5
>            Reporter: Aleksey Yeschenko
>            Assignee: Aleksey Yeschenko
>              Labels: cql3
>             Fix For: 1.2.6
>
>         Attachments: 5639.txt
>
>
> CASSANDRA-5484 introduced CREATE CUSTOM INDEX syntax for custom 2i and CASSANDRA-5576 will add CQL3 support for creating/dropping triggers (CREATE TRIGGER <name> ON <table> USING <classname>). For consistency' sake, CREATE CUSTOM INDEX should be updated to also use 'USING' keyword, e.g. CREATE CUSTOM INDEX ON <table>(<column>) USING <classname>.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira