You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Jonathan Gray (JIRA)" <ji...@apache.org> on 2010/09/01 00:48:53 UTC
[jira] Created: (HBASE-2943) major_compact (and other admin
commands) broken for .META.
major_compact (and other admin commands) broken for .META.
----------------------------------------------------------
Key: HBASE-2943
URL: https://issues.apache.org/jira/browse/HBASE-2943
Project: HBase
Issue Type: Bug
Reporter: Jonathan Gray
Priority: Critical
Fix For: 0.90.0
Table admin commands seem to be broken against META. Implementation is new in master rewrite branch so should wait until that goes in to see if this bug still exists.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-2943) major_compact (and other admin
commands) broken for .META.
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-2943:
-------------------------
Attachment: 2943-v2.txt
{code}
Bug fix was making MetaReader deal when passed .META. and -ROOT-; presumption
was for most methods that table referred to was always user table. This
made calls to compact, etc., break.
M src/test/java/org/apache/hadoop/hbase/catalog/TestMetaReaderEditor.java
Added a bunch of tests for MetaReader mostly.
M src/main/java/org/apache/hadoop/hbase/thrift/ThriftServer.java
M src/main/java/org/apache/hadoop/hbase/avro/AvroServer.java
Convert the IE that compact can now throw.
M src/main/java/org/apache/hadoop/hbase/master/handler/ServerShutdownHandler.java
Renamed method to better explain what it does.
M src/main/java/org/apache/hadoop/hbase/catalog/CatalogTracker.java
Added override on constructor.
M src/main/java/org/apache/hadoop/hbase/catalog/MetaReader.java
Revamped methods so can handle being passed .META. and -ROOT-.
Renamed getServerRegions as getServerUserRegions.
M src/main/java/org/apache/hadoop/hbase/client/HConnection.java
Javadoc spelling correction
M src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
Let out IE.
{code}
> major_compact (and other admin commands) broken for .META.
> ----------------------------------------------------------
>
> Key: HBASE-2943
> URL: https://issues.apache.org/jira/browse/HBASE-2943
> Project: HBase
> Issue Type: Bug
> Reporter: Jonathan Gray
> Priority: Critical
> Fix For: 0.90.0
>
> Attachments: 2943-v2.txt, 2943.txt
>
>
> Table admin commands seem to be broken against META. Implementation is new in master rewrite branch so should wait until that goes in to see if this bug still exists.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HBASE-2943) major_compact (and other admin
commands) broken for .META.
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack resolved HBASE-2943.
--------------------------
Hadoop Flags: [Reviewed]
Assignee: stack
Resolution: Fixed
Committed. Thanks for review J-D. Got your first comment -- added logging of user initiated flush -- but didn't get second comment. Will address later in a general review of how we now let out IEs. Thanks.
> major_compact (and other admin commands) broken for .META.
> ----------------------------------------------------------
>
> Key: HBASE-2943
> URL: https://issues.apache.org/jira/browse/HBASE-2943
> Project: HBase
> Issue Type: Bug
> Reporter: Jonathan Gray
> Assignee: stack
> Priority: Critical
> Fix For: 0.90.0
>
> Attachments: 2943-v2.txt, 2943.txt
>
>
> Table admin commands seem to be broken against META. Implementation is new in master rewrite branch so should wait until that goes in to see if this bug still exists.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-2943) major_compact (and other admin
commands) broken for .META.
Posted by "Jean-Daniel Cryans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12905666#action_12905666 ]
Jean-Daniel Cryans commented on HBASE-2943:
-------------------------------------------
+1, fix the following on commit if you think it's good:
I think it's more related to the master rewrite, but it would be nice to see the message on the region server when it arrives (before we saw it because it was coming from the master).
In HBA you don't give an explanation for the IE's javadoc, although the IO gets that treatment. For consistency, I would add a few words on how you can get that exception and what to do with it.
> major_compact (and other admin commands) broken for .META.
> ----------------------------------------------------------
>
> Key: HBASE-2943
> URL: https://issues.apache.org/jira/browse/HBASE-2943
> Project: HBase
> Issue Type: Bug
> Reporter: Jonathan Gray
> Priority: Critical
> Fix For: 0.90.0
>
> Attachments: 2943-v2.txt, 2943.txt
>
>
> Table admin commands seem to be broken against META. Implementation is new in master rewrite branch so should wait until that goes in to see if this bug still exists.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-2943) major_compact (and other admin
commands) broken for .META.
Posted by "Jonathan Gray (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12904827#action_12904827 ]
Jonathan Gray commented on HBASE-2943:
--------------------------------------
Mostly. The issue isn't in the shell, afaik, it's in a method called getTableRegions where we are not looking at ROOT when doing something to META (we look in META for META), doh.
> major_compact (and other admin commands) broken for .META.
> ----------------------------------------------------------
>
> Key: HBASE-2943
> URL: https://issues.apache.org/jira/browse/HBASE-2943
> Project: HBase
> Issue Type: Bug
> Reporter: Jonathan Gray
> Priority: Critical
> Fix For: 0.90.0
>
>
> Table admin commands seem to be broken against META. Implementation is new in master rewrite branch so should wait until that goes in to see if this bug still exists.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-2943) major_compact (and other admin
commands) broken for .META.
Posted by "Jean-Daniel Cryans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12904818#action_12904818 ]
Jean-Daniel Cryans commented on HBASE-2943:
-------------------------------------------
HBASE-2788 ?
> major_compact (and other admin commands) broken for .META.
> ----------------------------------------------------------
>
> Key: HBASE-2943
> URL: https://issues.apache.org/jira/browse/HBASE-2943
> Project: HBase
> Issue Type: Bug
> Reporter: Jonathan Gray
> Priority: Critical
> Fix For: 0.90.0
>
>
> Table admin commands seem to be broken against META. Implementation is new in master rewrite branch so should wait until that goes in to see if this bug still exists.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-2943) major_compact (and other admin
commands) broken for .META.
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-2943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-2943:
-------------------------
Attachment: 2943.txt
Start in on a fix. Also adds unit test for MetaReader. Not done yet.
> major_compact (and other admin commands) broken for .META.
> ----------------------------------------------------------
>
> Key: HBASE-2943
> URL: https://issues.apache.org/jira/browse/HBASE-2943
> Project: HBase
> Issue Type: Bug
> Reporter: Jonathan Gray
> Priority: Critical
> Fix For: 0.90.0
>
> Attachments: 2943.txt
>
>
> Table admin commands seem to be broken against META. Implementation is new in master rewrite branch so should wait until that goes in to see if this bug still exists.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.