You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "chennaji9 (via GitHub)" <gi...@apache.org> on 2026/09/30 10:55:39 UTC
[PR] [ISSUE #11293] fix(docs): correct send-status guidance and default values in Operations_Producer.md [rocketmq]
chennaji9 opened a new pull request, #11300:
URL: https://github.com/apache/rocketmq/pull/11300
<!-- Please make sure the target branch is right. In most case, the target branch should be `develop`. -->
### Which Issue(s) This PR Fixes
Fixes #11293
### Brief Description
Three factual corrections in `docs/en/Operations_Producer.md`:
1. The page claimed "we will always get SEND_OK if no exception is thrown". That is wrong: `MQClientAPIImpl.processSendResponse` maps `FLUSH_DISK_TIMEOUT`, `FLUSH_SLAVE_TIMEOUT` and `SLAVE_NOT_AVAILABLE` to ordinary `SendStatus` values without throwing (the page itself documents these statuses right below). The sentence now tells readers to check `SendResult.getSendStatus()`.
2. "0 times in asynchronous mode" → async sends retry **2** times by default (`DefaultMQProducer.retryTimesWhenSendAsyncFailed = 2`).
3. "sendMsgTimeout(default is 10 seconds)" → the default is **3000 ms** (`DefaultMQProducer.sendMsgTimeout = 3000`). Also fixes the "less then" typo in the same sentence.
### How Did You Test This Change?
Verified each claim against current `develop` source: `client/src/main/java/org/apache/rocketmq/client/producer/DefaultMQProducer.java` (lines 116/133/140) and `client/src/main/java/org/apache/rocketmq/client/impl/MQClientAPIImpl.java#processSendResponse` (non-throwing branches for the three statuses). Three-line textual diff only.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #11293] fix(docs): correct send-status guidance and default values in Operations_Producer.md [rocketmq]
Posted by "chennaji9 (via GitHub)" <gi...@apache.org>.
chennaji9 commented on PR #11300:
URL: https://github.com/apache/rocketmq/pull/11300#issuecomment-6259832697
Sorry to bother you @RongtongJin — just nudging this PR since it hasn't had any feedback yet. Tests and CI are green on my end, and the fix (correct send-status guidance and default values in Operation…) is ready to go. Could you help review it and, if it works for you, merge it? More than happy to address any comments. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #11293] fix(docs): correct send-status guidance and default values in Operations_Producer.md [rocketmq]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #11300:
URL: https://github.com/apache/rocketmq/pull/11300#issuecomment-6247685242
## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/11300?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 49.73%. Comparing base ([`78b96bc`](https://app.codecov.io/gh/apache/rocketmq/commit/78b96bc5e21216cd7896efae08f90c5cde4cae53?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`bd8f642`](https://app.codecov.io/gh/apache/rocketmq/commit/bd8f64233c6a61d4c670f782a5363bfdc5ea03db?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 15 commits behind head on develop.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## develop #11300 +/- ##
=============================================
- Coverage 49.74% 49.73% -0.02%
- Complexity 14352 14371 +19
=============================================
Files 1390 1390
Lines 103190 103262 +72
Branches 13493 13504 +11
=============================================
+ Hits 51337 51360 +23
- Misses 45688 45699 +11
- Partials 6165 6203 +38
```
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/rocketmq/pull/11300?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org