You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/08 10:31:58 UTC
[GitHub] [airflow] jhtimmins opened a new pull request #12915: Make sure perms list isn't None before looking within list.
jhtimmins opened a new pull request #12915:
URL: https://github.com/apache/airflow/pull/12915
Currently, the `._has_access()` method in `Security.py` checks whether the security manager object has `.perms` property, which is then checked for the presence of a specific permission. This causes an error when the `.perms` property is set to `None`, rather than an iterable.
This fix makes sure that `.perms` isn't `None` before looking inside. Otherwise, the permissions are lookup up and saved to the `.perms` property.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #12915: Make sure perms list isn't None before looking within list.
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #12915:
URL: https://github.com/apache/airflow/pull/12915
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #12915: Make sure perms list isn't None before looking within list.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12915:
URL: https://github.com/apache/airflow/pull/12915#issuecomment-740558219
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org