You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/06/22 16:32:24 UTC
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #33022: [SPARK-35856][SQL][TESTS] Move new interval type test cases from CastSuite to CastBaseSuite
dongjoon-hyun commented on a change in pull request #33022:
URL: https://github.com/apache/spark/pull/33022#discussion_r656393492
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CastSuiteBase.scala
##########
@@ -73,7 +73,9 @@ abstract class CastSuiteBase extends SparkFunSuite with ExpressionEvalHelper {
}
}
- protected def isAlwaysNullable: Boolean = false
+ // Whether the test suite is for TryCast. If yes, there is no exceptions and the result is
+ // always nullable.
+ protected def isTryCast: Boolean = false
Review comment:
In this case, this looks like a major refactoring instead of simple **moving**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org