You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by "DaanHoogland (via GitHub)" <gi...@apache.org> on 2025/10/21 08:04:00 UTC
[PR] Update Apache RAT version to 0.17 in workflow [cloudstack-cloudmonkey]
DaanHoogland opened a new pull request, #198:
URL: https://github.com/apache/cloudstack-cloudmonkey/pull/198
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update Apache RAT version to 0.17 in workflow [cloudstack-cloudmonkey]
Posted by "vishesh92 (via GitHub)" <gi...@apache.org>.
vishesh92 merged PR #198:
URL: https://github.com/apache/cloudstack-cloudmonkey/pull/198
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update Apache RAT version to 0.17 in workflow [cloudstack-cloudmonkey]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #198:
URL: https://github.com/apache/cloudstack-cloudmonkey/pull/198#discussion_r2447190384
##########
.github/workflows/rat.yaml:
##########
@@ -42,12 +42,12 @@ jobs:
- name: Download Apache RAT
run: |
- curl -L -O https://downloads.apache.org/creadur/apache-rat-0.16.1/apache-rat-0.16.1-bin.tar.gz
- tar -xzf apache-rat-0.16.1-bin.tar.gz
+ curl -L -O https://downloads.apache.org/creadur/apache-rat-0.17/apache-rat-0.17-bin.tar.gz
+ tar -xzf apache-rat-0.17-bin.tar.gz
- name: Run RAT
run: |
- java -jar apache-rat-0.16.1/apache-rat-0.16.1.jar -d . -E .rat-excludes > rat-report.txt
+ java -jar apache-rat-0.17/apache-rat-0.17.jar -d . -E .rat-excludes > rat-report.txt
cat rat-report.txt
# Fail if unapproved licenses are found
- grep -qe '^0 Unknown Licenses' rat-report.txt && exit 0 || exit 1
+ grep -qe '^\s*Unapproved:\s*0\s*A count of unapproved licenses.$' rat-report.txt && exit 0 || exit 1
Review Comment:
The grep pattern appears overly specific by including the descriptive text 'A count of unapproved licenses.' This makes the check brittle to minor output format changes. Consider matching just the essential part: `grep -qe '^\s*Unapproved:\s*0\s*'` to improve maintainability while still ensuring zero unapproved licenses.
```suggestion
grep -qe '^\s*Unapproved:\s*0\s*' rat-report.txt && exit 0 || exit 1
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update Apache RAT version to 0.17 in workflow [cloudstack-cloudmonkey]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #198:
URL: https://github.com/apache/cloudstack-cloudmonkey/pull/198#issuecomment-3425316772
<!-- cmk-build-artifact-comment -->
✅ Build complete for PR #198.
🔗 Download the [cmk binaries](https://github.com/apache/cloudstack-cloudmonkey/actions/runs/18677109595/artifacts/4325425866) (expires on October 31, 2025)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org