You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by rnewson <gi...@git.apache.org> on 2015/08/08 15:04:36 UTC
[GitHub] couchdb-couch pull request: Add option to make CSRF cookie mandato...
GitHub user rnewson opened a pull request:
https://github.com/apache/couchdb-couch/pull/83
Add option to make CSRF cookie mandatory
When enabled, the CSRF cookie/header is required on all requests
except those to the welcome message at /.
COUCHDB-2762
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloudant/couchdb-couch 2762-csrf-mandatory
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-couch/pull/83.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #83
----
commit 8fc187d79c1573ffa6b61d756f6ad8601243d3ae
Author: Robert Newson <rn...@apache.org>
Date: 2015-08-08T13:03:23Z
Add option to make CSRF cookie mandatory
When enabled, the CSRF cookie/header is required on all requests
except those to the welcome message at /.
COUCHDB-2762
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: Add option to make CSRF cookie mandato...
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-couch/pull/83#issuecomment-128993913
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: Add option to make CSRF cookie mandato...
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-couch/pull/83#issuecomment-129003097
Tested, all fine, sorry for confusion. Too many paths, too many servers (: +1, it works as expected.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: Add option to make CSRF cookie mandato...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/couchdb-couch/pull/83
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: Add option to make CSRF cookie mandato...
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on a diff in the pull request:
https://github.com/apache/couchdb-couch/pull/83#discussion_r36578920
--- Diff: src/couch_httpd_csrf.erl ---
@@ -63,6 +63,16 @@ validate(Csrf) when is_list(Csrf) ->
end
end.
+throw_if_mandatory(#httpd{path_parts = []}) ->
+ ok; %% Welcome message is public / entrypoint
--- End diff --
Here could be not welcome message, but database endpoint, thanks to vhosts and rewrite feature.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---