You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@tomcat.apache.org by "Igal @ Lucee.org" <ig...@lucee.org> on 2016/10/20 20:09:15 UTC
Allow Customization of service.bat
service.bat is a great tool to install and remove Tomcat as a Windows
service, but it has a few hardcoded values that should be
customize-able, like the heap memory size and JVM args.
I've modified the script slightly to address these issues. The first
part sets default values:
if "%SERVICE_STARTUP_MODE%" == "" set SERVICE_STARTUP_MODE=manual
if "%JvmMs%" == "" set JvmMs=128
if "%JvmMx%" == "" set JvmMx=256
The second part makes use of those values:
--Startup "%SERVICE_STARTUP_MODE%" ^
--JvmOptions
"%JvmArgs%;-Dcatalina.home=%CATALINA_HOME%;-Dcatalina.base=%CATALINA_BASE%;-Djava.io.tmpdir=%CATALINA_BASE%\temp;-Djava.util.logging.manager=org.apache.juli.ClassLoaderLogManager;-Djava.util.logging.config.file=%CATALINA_BASE%\conf\logging.properties"
^
--JvmMs "%JvmMs%" ^
--JvmMx "%JvmMx%"
It'd be great, however, if these changes were accepted to be part of the
Tomcat distribution.
Can I submit a patch for that?
--
Igal Sapir
Lucee Core Developer
Lucee.org <http://lucee.org/>
Re: Allow Customization of service.bat
Posted by "Igal @ Lucee.org" <ig...@lucee.org>.
Chris,
On 10/21/2016 12:05 PM, Christopher Schultz wrote:
>
>> For some reason I thought that I read somewhere that the git repo
>> is read-only. I didn't realize that I can submit a PR there.
> It *is* read-only. But you can clone the repo and make a read-write
> copy, then publish a pull-request from there.
>
> It doesn't matter to you at all if the ASF's git repo is read-only.
> Only the owner cares about that.
When I wrote read-only I meant a "read-only mirror for Subversion".
Obviously I did not expect to have commit permissions on the official
Tomcat repo.
Anyway, I've submitted a PR at
https://github.com/apache/tomcat/pull/36/files
Igal
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@tomcat.apache.org
For additional commands, e-mail: users-help@tomcat.apache.org
Re: Allow Customization of service.bat
Posted by Christopher Schultz <ch...@christopherschultz.net>.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Igal,
On 10/21/16 1:02 PM, Igal @ Lucee.org wrote:
> Thanks Violeta,
>
> On 10/20/2016 11:10 PM, Violeta Georgieva wrote:
>> We also accept PRs from GitHub [2]. [2]
>> https://github.com/apache/tomcat
>
> For some reason I thought that I read somewhere that the git repo
> is read-only. I didn't realize that I can submit a PR there.
It *is* read-only. But you can clone the repo and make a read-write
copy, then publish a pull-request from there.
It doesn't matter to you at all if the ASF's git repo is read-only.
Only the owner cares about that.
- -chris
-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - http://gpgtools.org
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQIcBAEBCAAGBQJYCmbdAAoJEBzwKT+lPKRY9CwP/jmNWJHZCdGwYX2M68JvQHul
qk+/pMoOSQvTsRGbaTMJJuKjeKNp3rJ35iEfHzBUF0svA7D2Y1WHkIv8wwWq4euk
ewnYItsxu1QwyNC6rQUA8b2m4n6jWlM4rsQclpv/eUmZIpblxciAHrGnIED2fG4v
4sWBEiQe6NO22MlT2UYxK1viESfuZOMfUxcXMSuUIgyAVYAiITSYLI/eHcfH8qAn
NluNlVDcPGqwHaCA1UGVToHmBOLwWqTUp5LcKY0/XQX/tVHjkgAL+1xSxW+Dr705
o+OFJTD1OcMk2F/kdoXeAolzGb6Q8ai4rr/hJrxNdiwYbIaQpwy0H6Ao2xkmbkR6
Ujdqt8Nl/kB+HuodpmFAGzXY2wB/mTDCw+uTbvik8t2cTZICoM8Vue6uR4Q15feN
4Mj2IlxGxdoK4Q4NpuAciqrMs75WizaRk0XQWSXmYAPdqIDNP6lD4sdAZiY9riMc
aFVT5kuyLaA8IyjBmTlh4bieH9dF6jT4KsBn6Tw4idG+pEKyQR9Hq1hlpjxxuBWe
8knbu8aKvAcrWop9E8qW5eviJUEvp1Gvxq9VP9g3h1hZ1N1O9257hljnYhi3JBaZ
rwolek5O3vZK0QZVdIjGj67mA9ihbB9Dvpiq+kXmqTWFW4IEymgmZpLc63h5rLrt
vgfqzCD+NG53w021RHge
=IybW
-----END PGP SIGNATURE-----
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@tomcat.apache.org
For additional commands, e-mail: users-help@tomcat.apache.org
Re: Allow Customization of service.bat
Posted by "Igal @ Lucee.org" <ig...@lucee.org>.
Thanks Violeta,
On 10/20/2016 11:10 PM, Violeta Georgieva wrote:
> We also accept PRs from GitHub [2].
> [2] https://github.com/apache/tomcat
For some reason I thought that I read somewhere that the git repo is
read-only. I didn't realize that I can submit a PR there.
I'll do that.
Igal Sapir
Lucee Core Developer
Lucee.org <http://lucee.org/>
Re: Allow Customization of service.bat
Posted by "Igal @ Lucee.org" <ig...@lucee.org>.
Hi Violeta,
On 11/7/2016 10:04 AM, Violeta Georgieva wrote:
> The fix is available in:
> - trunk for 9.0.0.M14 onwards
> - 8.5.x for 8.5.9 onwards
Awesome, thanks!
Igal
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@tomcat.apache.org
For additional commands, e-mail: users-help@tomcat.apache.org
Re: Allow Customization of service.bat
Posted by Violeta Georgieva <mi...@gmail.com>.
Hi,
2016-11-02 19:27 GMT+02:00 Igal @ Lucee.org <ig...@lucee.org>:
>
> Violeta,
>
> On 10/20/2016 11:10 PM, Violeta Georgieva wrote:
>>
>> Here [1] it is described how you can report a bug. Attach the patch to
the
>> bug. When you attaching the file there is a checkbox "patch".
>> We also accept PRs from GitHub [2].
>>
>> [1] http://tomcat.apache.org/bugreport.html#Reporting_Apache_Tomcat_bugs
>> [2] https://github.com/apache/tomcat
>
> Are you sure about the GitHub PRs? I submitted this one almost a couple
of weeks ago:
> https://github.com/apache/tomcat/pull/36
Thanks for the patch.
The fix is available in:
- trunk for 9.0.0.M14 onwards
- 8.5.x for 8.5.9 onwards
Regards,
Violeta
> Thanks,
>
>
>
> Igal
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: users-help@tomcat.apache.org
>
Re: Allow Customization of service.bat
Posted by "Igal @ Lucee.org" <ig...@lucee.org>.
Violeta,
On 10/20/2016 11:10 PM, Violeta Georgieva wrote:
> Here [1] it is described how you can report a bug. Attach the patch to the
> bug. When you attaching the file there is a checkbox "patch".
> We also accept PRs from GitHub [2].
>
> [1] http://tomcat.apache.org/bugreport.html#Reporting_Apache_Tomcat_bugs
> [2] https://github.com/apache/tomcat
Are you sure about the GitHub PRs? I submitted this one almost a couple
of weeks ago:
https://github.com/apache/tomcat/pull/36
Thanks,
Igal
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@tomcat.apache.org
For additional commands, e-mail: users-help@tomcat.apache.org
Re: Allow Customization of service.bat
Posted by Violeta Georgieva <mi...@gmail.com>.
Hi,
2016-10-21 1:23 GMT+03:00 Igal @ Lucee.org <ig...@lucee.org>:
>
> Hi Mark,
>
> On 10/20/2016 1:19 PM, Mark Thomas wrote:
>>
>>
>>> Can I submit a patch for that?
>>
>> Sure. Got for it.
>
>
> I'm not very familiar with SVN (hopefully Apache will move to GIT soon),
so I wasn't sure where to submit the patch.
>
> The Apache Contributors Guide suggests the bug tracking platform. Should
I create a ticket in Bugzilla and add the patch there?
>
> I also attached the patch file here for convenience.
>
> Thank you,
Here [1] it is described how you can report a bug. Attach the patch to the
bug. When you attaching the file there is a checkbox "patch".
We also accept PRs from GitHub [2].
[1] http://tomcat.apache.org/bugreport.html#Reporting_Apache_Tomcat_bugs
[2] https://github.com/apache/tomcat
Regards,
Violeta
>
> Igal
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: users-help@tomcat.apache.org
Re: Allow Customization of service.bat
Posted by "Igal @ Lucee.org" <ig...@lucee.org>.
Hi Mark,
On 10/20/2016 1:19 PM, Mark Thomas wrote:
>
>> Can I submit a patch for that?
> Sure. Got for it.
I'm not very familiar with SVN (hopefully Apache will move to GIT soon),
so I wasn't sure where to submit the patch.
The Apache Contributors Guide suggests the bug tracking platform. Should
I create a ticket in Bugzilla and add the patch there?
I also attached the patch file here for convenience.
Thank you,
Igal
Re: Allow Customization of service.bat
Posted by Mark Thomas <ma...@apache.org>.
On 20/10/2016 21:09, Igal @ Lucee.org wrote:
> service.bat is a great tool to install and remove Tomcat as a Windows
> service, but it has a few hardcoded values that should be
> customize-able, like the heap memory size and JVM args.
>
> I've modified the script slightly to address these issues. The first
> part sets default values:
>
> if "%SERVICE_STARTUP_MODE%" == "" set SERVICE_STARTUP_MODE=manual
> if "%JvmMs%" == "" set JvmMs=128
> if "%JvmMx%" == "" set JvmMx=256
>
> The second part makes use of those values:
>
> --Startup "%SERVICE_STARTUP_MODE%" ^
> --JvmOptions
> "%JvmArgs%;-Dcatalina.home=%CATALINA_HOME%;-Dcatalina.base=%CATALINA_BASE%;-Djava.io.tmpdir=%CATALINA_BASE%\temp;-Djava.util.logging.manager=org.apache.juli.ClassLoaderLogManager;-Djava.util.logging.config.file=%CATALINA_BASE%\conf\logging.properties"
> ^
> --JvmMs "%JvmMs%" ^
> --JvmMx "%JvmMx%"
>
> It'd be great, however, if these changes were accepted to be part of the
> Tomcat distribution.
>
> Can I submit a patch for that?
Sure. Got for it.
Thanks,
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@tomcat.apache.org
For additional commands, e-mail: users-help@tomcat.apache.org