[jira] [Commented] (KAFKA-296) Update Go Client to new version of Go

["Jeffrey Damick (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13227288#comment-13227288 ] 

Jeffrey Damick commented on KAFKA-296:
--------------------------------------

good updates, however the formatting wouldn't be so big if you stuck with the current switches..
 
(from the old Makefile and still work..)
gofmt -w -tabwidth=2 -tabindent=false 

i'd rather use spaces and not tabs..
                
> Update Go Client to new version of Go
> -------------------------------------
>
>                 Key: KAFKA-296
>                 URL: https://issues.apache.org/jira/browse/KAFKA-296
>             Project: Kafka
>          Issue Type: Improvement
>          Components: clients
>    Affects Versions: 0.7.1
>            Reporter: AaronR
>         Attachments: go1updates.patch
>
>
> go  (http://golang.org) is close to releasing a new release of go (1.0) which requires updates to the client, in the meantime most of the go community has moved to this version.  
> This change contains:
> * language changes to existing client (os.Error, time. Signals, etc)
> * removes the Makefile's (no longer used by go)
> * It also runs "go fmt"  (formats it in standard go) which are most of the lines changes, from spaces to tabs.
> * updates the import path to allow for "go get" installs (don't need to get source and build)   
> Not sure which versions this should apply to, but i think it should go to 0.7 and newer.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira