You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "andygrove (via GitHub)" <gi...@apache.org> on 2026/05/11 19:10:03 UTC

[PR] ci: convert spark_sql_test paths-ignore to explicit paths allow-list [datafusion-comet]

andygrove opened a new pull request, #4290:
URL: https://github.com/apache/datafusion-comet/pull/4290

   ## Which issue does this PR close?
   
   Closes #.
   
   ## Rationale for this change
   
   The Spark SQL Tests workflow uses `paths-ignore` to skip CI on changes to docs, benchmarks, tests, etc. An allow-list (`paths`) is easier to reason about: it states exactly what *does* trigger the workflow, so new top-level directories or unrelated files won't accidentally trigger an expensive multi-matrix test run.
   
   ## What changes are included in this PR?
   
   `.github/workflows/spark_sql_test.yml` — replace `paths-ignore` on both `push` and `pull_request` triggers with explicit `paths` allow-lists covering:
   
   - Native crates compiled into `libcomet` (`native/**/src/**`, `native/**/Cargo.toml`, `native/Cargo.lock`), with `native/hdfs/**` and `native/fs-hdfs/**` negated since they are not in the default workspace members.
   - JVM main sources (`common/src/main/**`, `spark/src/main/**`) with `spark/src/main/scala/org/apache/comet/GenerateDocs.scala` negated (preserves the original exclusion).
   - Module poms (`pom.xml`, `common/pom.xml`, `spark/pom.xml`).
   - Spark patch diffs (`dev/diffs/**`) applied during the test.
   - `rust-toolchain.toml`.
   - This workflow file and the two composite actions it uses (`setup-builder`, `setup-spark-builder`).
   
   ## How are these changes tested?
   
   This PR is opened as a draft. The workflow itself is in the allow-list, so this PR triggers the full Spark SQL test matrix and validates the new filter.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] ci: convert spark_sql_test paths-ignore to explicit paths allow-list [datafusion-comet]

Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove merged PR #4290:
URL: https://github.com/apache/datafusion-comet/pull/4290


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org