[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #6066: Detect the behavior when column name mismatches in the query

[GitBox <gi...@apache.org>]

mayankshriv commented on a change in pull request #6066:
URL: https://github.com/apache/incubator-pinot/pull/6066#discussion_r522438725



##########
File path: pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
##########
@@ -984,32 +984,57 @@ private void fixColumnName(String rawTableName, TransformExpressionTree expressi
   private void fixColumnName(String rawTableName, Expression expression, @Nullable Map<String, String> columnNameMap) {
     ExpressionType expressionType = expression.getType();
     if (expressionType == ExpressionType.IDENTIFIER) {
-      Identifier identifier = expression.getIdentifier();
-      identifier.setName(getActualColumnName(rawTableName, identifier.getName(), columnNameMap));
+      if (!isStarIdentifier(expression)) {

Review comment:
       This special casing just for emitting a metric does not seem right. Perhaps it might be more straight forward to do it on the server side as follows:
   
   - For each segment, if the segment gets pruned due to missing column, we return that to broker as part of metadata (or executionstatistics). May be we can emit a metric there.
   
   - Broker can decide to act on what to do (metric or metadata in response, or both) if it sees server responses where segments where pruned due to missing column.
   
   cc: @mcvsubbu 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org