You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Albert Mayo (JIRA)" <ji...@apache.org> on 2009/05/22 18:54:45 UTC
[jira] Created: (OFBIZ-2512) duplicate orders in picklist
duplicate orders in picklist
----------------------------
Key: OFBIZ-2512
URL: https://issues.apache.org/jira/browse/OFBIZ-2512
Project: OFBiz
Issue Type: Bug
Components: product
Affects Versions: Release Branch 4.0
Reporter: Albert Mayo
Priority: Trivial
The conditions for the error:
- the order maysplit = Y
- the order must have at least 1 backordered item and 1 item not backordered
- a picklist is created with the non-backordered item
If you create another picklist, it will include the non-backordered item.
Also for some reason it looks like this situation causes a bin number to not be included in the picklist. I created a picklist of 5 orders and Bin Num 1 is missing.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2512) duplicate orders in picklist
Posted by "Albert Mayo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12712166#action_12712166 ]
Albert Mayo commented on OFBIZ-2512:
------------------------------------
Unfortunately, I don't have time to officially contribute to the OFBiz project by properly submitting a patch, but I can explain the patch I am working on that seems to work.
In PicklistServices.xml under the simple-method findOrdersToPickMove, around line 187, the code tries to filter out backordered items. The problem is it gives the condition <if-compare field-name="orderItemShipGroup.maySplit" operator="equals" value="Y"/>. This will make a backordered item to allow that order to the picklist. Since this order is added to the picklist, somewhere down road the order's non-backordered items are added to the picklist, even if it is already part of another picklist.
I made 1 other modification that could be considered an enhancement or a bug. If a picked is marked as picked, any order in that picklist that was accidently missed will never show up in a future picklist. I made a modification to filter out Picked picklists, just as it does with Cancelled picklists, so that no orders are missed. This mod was made around line 151 with the addition of <condition-expr field-name="statusId" operator="not-equals" value="PICKLIST_PICKED"/>.
I attached a patch for your reference only. It is from my personal repository.
> duplicate orders in picklist
> ----------------------------
>
> Key: OFBIZ-2512
> URL: https://issues.apache.org/jira/browse/OFBIZ-2512
> Project: OFBiz
> Issue Type: Bug
> Components: product
> Affects Versions: Release Branch 4.0
> Reporter: Albert Mayo
> Priority: Trivial
>
> The conditions for the error:
> - the order maysplit = Y
> - the order must have at least 1 backordered item and 1 item not backordered
> - a picklist is created with the non-backordered item
> If you create another picklist, it will include the non-backordered item.
> Also for some reason it looks like this situation causes a bin number to not be included in the picklist. I created a picklist of 5 orders and Bin Num 1 is missing.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2512) duplicate orders in picklist
Posted by "Albert Mayo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Albert Mayo updated OFBIZ-2512:
-------------------------------
Attachment: picklist.patch
attached patch for reference
> duplicate orders in picklist
> ----------------------------
>
> Key: OFBIZ-2512
> URL: https://issues.apache.org/jira/browse/OFBIZ-2512
> Project: OFBiz
> Issue Type: Bug
> Components: product
> Affects Versions: Release Branch 4.0
> Reporter: Albert Mayo
> Priority: Trivial
> Attachments: picklist.patch
>
>
> The conditions for the error:
> - the order maysplit = Y
> - the order must have at least 1 backordered item and 1 item not backordered
> - a picklist is created with the non-backordered item
> If you create another picklist, it will include the non-backordered item.
> Also for some reason it looks like this situation causes a bin number to not be included in the picklist. I created a picklist of 5 orders and Bin Num 1 is missing.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2512) duplicate orders in picklist
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacques Le Roux updated OFBIZ-2512:
-----------------------------------
Issue Type: Sub-task (was: Bug)
Parent: OFBIZ-3268
> duplicate orders in picklist
> ----------------------------
>
> Key: OFBIZ-2512
> URL: https://issues.apache.org/jira/browse/OFBIZ-2512
> Project: OFBiz
> Issue Type: Sub-task
> Components: product
> Affects Versions: Release Branch 4.0
> Reporter: Albert Mayo
> Priority: Trivial
> Attachments: picklist.patch
>
>
> The conditions for the error:
> - the order maysplit = Y
> - the order must have at least 1 backordered item and 1 item not backordered
> - a picklist is created with the non-backordered item
> If you create another picklist, it will include the non-backordered item.
> Also for some reason it looks like this situation causes a bin number to not be included in the picklist. I created a picklist of 5 orders and Bin Num 1 is missing.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.