You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Julie Tibshirani (JIRA)" <ji...@apache.org> on 2014/09/10 00:37:28 UTC
[jira] [Commented] (LUCENE-5929) Standard highlighting doesn't work
for ToParentBlockJoinQuery
[ https://issues.apache.org/jira/browse/LUCENE-5929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14127694#comment-14127694 ]
Julie Tibshirani commented on LUCENE-5929:
------------------------------------------
I have a simple fix ready that simply adds a check in WeightedSpanTermExtractor for ToParentBlockJoinQuery and ToChildBlockJoinQuery. I'm new to committing to Lucene -- is there anything I'm missing or need to watch out for?
> Standard highlighting doesn't work for ToParentBlockJoinQuery
> -------------------------------------------------------------
>
> Key: LUCENE-5929
> URL: https://issues.apache.org/jira/browse/LUCENE-5929
> Project: Lucene - Core
> Issue Type: Bug
> Components: modules/highlighter
> Reporter: Julie Tibshirani
> Attachments: HighligherTest.patch
>
>
> Because WeightedSpanTermExtractor#extract doesn't check for ToParentBlockJoinQuery, the Highlighter class fails to produce highlights for this type of query.
> At first it may seem like there's no issue, because ToParentBlockJoinQuery only returns parent documents, while the highlighting applies to children. But if a client can directly supply the text from child documents (as elasticsearch does if _source is enabled), then highlighting will unexpectedly fail.
> A test case that triggers the bug is attached. The same issue exists for ToChildBlockJoinQuery.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org