[GitHub] [solr-operator] HoustonPutman commented on a change in pull request #292: Add config options to enable TLS from cert files mounted to a dir on each pod by a cert-manager extension

[GitBox <gi...@apache.org>]

HoustonPutman commented on a change in pull request #292:
URL: https://github.com/apache/solr-operator/pull/292#discussion_r675029576



##########
File path: controllers/solrprometheusexporter_controller.go
##########
@@ -216,6 +216,11 @@ func (r *SolrPrometheusExporterReconciler) Reconcile(req ctrl.Request) (ctrl.Res
 				}
 			}
 		}
+	} else if prometheusExporter.Spec.SolrReference.SolrTLS != nil && prometheusExporter.Spec.SolrReference.SolrTLS.MountedTLSDir != nil {
+		tlsClientOptions = &util.TLSClientOptions{}
+		tlsClientOptions.TLSOptions = prometheusExporter.Spec.SolrReference.SolrTLS
+		// TODO: How to get this from the SolrCloud reference?

Review comment:
       Yeah, no other option 😢 
   
   Maybe in the description of the field we can say it is only used when mountedTLS is enabled?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org