You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@kvrocks.apache.org by GitBox <gi...@apache.org> on 2022/10/28 15:27:54 UTC

[GitHub] [incubator-kvrocks] PragmaTwice commented on a diff in pull request #1048: Fix the anonymous typedef struct compile warnings

PragmaTwice commented on code in PR #1048:
URL: https://github.com/apache/incubator-kvrocks/pull/1048#discussion_r1008190251


##########
src/types/geohash.h:
##########
@@ -87,23 +87,23 @@ typedef enum {
   GEOHASH_NORT_EAST
 } GeoDirection;
 
-typedef struct {
+typedef struct GeoHashBits {
   uint64_t bits = 0;
   uint8_t step = 0;
 } GeoHashBits;

Review Comment:
   ```suggestion
   struct GeoHashBits {
     uint64_t bits = 0;
     uint8_t step = 0;
   };
   ```
   
   I think maybe we do not need `typedef` here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org