You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Pinal Shah <pi...@freestoneinfotech.com> on 2021/06/22 17:11:20 UTC
Review Request 73431: ATLAS-4341 : Regression: DSL query with like
operator and regex expression does not work
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73431/
-----------------------------------------------------------
Review request for atlas, Ashutosh Mestry, Jayendra Parab, Nixon Rodrigues, and Sarath Subramanian.
Bugs: ATLAS-4341
https://issues.apache.org/jira/browse/ATLAS-4341
Repository: atlas
Description
-------
**Issue:**
hdfs_path having 5 entities with suffix 0 to 5
/api/atlas/v2/search/dsl?typeName=hdfs_path&query=name%20like%20%22hdfs_path_vzxtp_*%22
**Finds the result**
But
/api/atlas/v2/search/dsl?typeName=hdfs_path&query=name like "hdfs_path_vzxtp_[0-9]"
**Returns empty**
Diffs
-----
repository/src/main/java/org/apache/atlas/query/IdentifierHelper.java d2906ea40
Diff: https://reviews.apache.org/r/73431/diff/1/
Testing
-------
Manually verified
Precommit :
Thanks,
Pinal Shah
Re: Review Request 73431: ATLAS-4341 : Regression: DSL query with like
operator and regex expression does not work
Posted by Ashutosh Mestry via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73431/#review223180
-----------------------------------------------------------
repository/src/main/java/org/apache/atlas/query/IdentifierHelper.java
Line 39 (original), 39 (patched)
<https://reviews.apache.org/r/73431/#comment312280>
Can you please add GremlinQueriesComposerTest?
- Ashutosh Mestry
On June 22, 2021, 5:11 p.m., Pinal Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73431/
> -----------------------------------------------------------
>
> (Updated June 22, 2021, 5:11 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, Nixon Rodrigues, and Sarath Subramanian.
>
>
> Bugs: ATLAS-4341
> https://issues.apache.org/jira/browse/ATLAS-4341
>
>
> Repository: atlas
>
>
> Description
> -------
>
> **Issue:**
>
> hdfs_path having 5 entities with suffix 0 to 5
>
> /api/atlas/v2/search/dsl?typeName=hdfs_path&query=name%20like%20%22hdfs_path_vzxtp_*%22
> **Finds the result**
>
> But
>
> /api/atlas/v2/search/dsl?typeName=hdfs_path&query=name like "hdfs_path_vzxtp_[0-9]"
> **Returns empty**
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/query/IdentifierHelper.java d2906ea40
>
>
> Diff: https://reviews.apache.org/r/73431/diff/1/
>
>
> Testing
> -------
>
> Manually verified
>
> Precommit :
>
>
> Thanks,
>
> Pinal Shah
>
>
Re: Review Request 73431: ATLAS-4341 : Regression: DSL query with like
operator and regex expression does not work
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73431/#review223182
-----------------------------------------------------------
Ship it!
Ship It!
- Sarath Subramanian
On June 22, 2021, 10:32 a.m., Pinal Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73431/
> -----------------------------------------------------------
>
> (Updated June 22, 2021, 10:32 a.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, Nixon Rodrigues, and Sarath Subramanian.
>
>
> Bugs: ATLAS-4341
> https://issues.apache.org/jira/browse/ATLAS-4341
>
>
> Repository: atlas
>
>
> Description
> -------
>
> **Issue:**
>
> hdfs_path having 5 entities with suffix 0 to 5
>
> /api/atlas/v2/search/dsl?typeName=hdfs_path&query=name%20like%20%22hdfs_path_vzxtp_*%22
> **Finds the result**
>
> But
>
> /api/atlas/v2/search/dsl?typeName=hdfs_path&query=name like "hdfs_path_vzxtp_[0-9]"
> **Returns empty**
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/query/IdentifierHelper.java d2906ea40
> repository/src/test/java/org/apache/atlas/query/DSLQueriesTest.java 3404dc6e2
> repository/src/test/java/org/apache/atlas/query/GremlinQueryComposerTest.java 6220c23b9
>
>
> Diff: https://reviews.apache.org/r/73431/diff/3/
>
>
> Testing
> -------
>
> Manually verified
>
> Precommit : https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/693/ (In Progress)
>
>
> Thanks,
>
> Pinal Shah
>
>
Re: Review Request 73431: ATLAS-4341 : Regression: DSL query with like
operator and regex expression does not work
Posted by Pinal Shah <pi...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73431/
-----------------------------------------------------------
(Updated June 22, 2021, 5:32 p.m.)
Review request for atlas, Ashutosh Mestry, Jayendra Parab, Nixon Rodrigues, and Sarath Subramanian.
Bugs: ATLAS-4341
https://issues.apache.org/jira/browse/ATLAS-4341
Repository: atlas
Description
-------
**Issue:**
hdfs_path having 5 entities with suffix 0 to 5
/api/atlas/v2/search/dsl?typeName=hdfs_path&query=name%20like%20%22hdfs_path_vzxtp_*%22
**Finds the result**
But
/api/atlas/v2/search/dsl?typeName=hdfs_path&query=name like "hdfs_path_vzxtp_[0-9]"
**Returns empty**
Diffs
-----
repository/src/main/java/org/apache/atlas/query/IdentifierHelper.java d2906ea40
repository/src/test/java/org/apache/atlas/query/DSLQueriesTest.java 3404dc6e2
repository/src/test/java/org/apache/atlas/query/GremlinQueryComposerTest.java 6220c23b9
Diff: https://reviews.apache.org/r/73431/diff/3/
Testing (updated)
-------
Manually verified
Precommit : https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/693/ (In Progress)
Thanks,
Pinal Shah
Re: Review Request 73431: ATLAS-4341 : Regression: DSL query with like
operator and regex expression does not work
Posted by Pinal Shah <pi...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73431/
-----------------------------------------------------------
(Updated June 22, 2021, 5:30 p.m.)
Review request for atlas, Ashutosh Mestry, Jayendra Parab, Nixon Rodrigues, and Sarath Subramanian.
Bugs: ATLAS-4341
https://issues.apache.org/jira/browse/ATLAS-4341
Repository: atlas
Description
-------
**Issue:**
hdfs_path having 5 entities with suffix 0 to 5
/api/atlas/v2/search/dsl?typeName=hdfs_path&query=name%20like%20%22hdfs_path_vzxtp_*%22
**Finds the result**
But
/api/atlas/v2/search/dsl?typeName=hdfs_path&query=name like "hdfs_path_vzxtp_[0-9]"
**Returns empty**
Diffs (updated)
-----
repository/src/main/java/org/apache/atlas/query/IdentifierHelper.java d2906ea40
repository/src/test/java/org/apache/atlas/query/DSLQueriesTest.java 3404dc6e2
repository/src/test/java/org/apache/atlas/query/GremlinQueryComposerTest.java 6220c23b9
Diff: https://reviews.apache.org/r/73431/diff/3/
Changes: https://reviews.apache.org/r/73431/diff/2-3/
Testing
-------
Manually verified
Precommit : https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/692/ (In Progress)
Thanks,
Pinal Shah
Re: Review Request 73431: ATLAS-4341 : Regression: DSL query with like
operator and regex expression does not work
Posted by Ashutosh Mestry via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73431/#review223181
-----------------------------------------------------------
Ship it!
Ship It!
- Ashutosh Mestry
On June 22, 2021, 5:21 p.m., Pinal Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73431/
> -----------------------------------------------------------
>
> (Updated June 22, 2021, 5:21 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, Nixon Rodrigues, and Sarath Subramanian.
>
>
> Bugs: ATLAS-4341
> https://issues.apache.org/jira/browse/ATLAS-4341
>
>
> Repository: atlas
>
>
> Description
> -------
>
> **Issue:**
>
> hdfs_path having 5 entities with suffix 0 to 5
>
> /api/atlas/v2/search/dsl?typeName=hdfs_path&query=name%20like%20%22hdfs_path_vzxtp_*%22
> **Finds the result**
>
> But
>
> /api/atlas/v2/search/dsl?typeName=hdfs_path&query=name like "hdfs_path_vzxtp_[0-9]"
> **Returns empty**
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/query/IdentifierHelper.java d2906ea40
> repository/src/test/java/org/apache/atlas/query/DSLQueriesTest.java 3404dc6e2
>
>
> Diff: https://reviews.apache.org/r/73431/diff/2/
>
>
> Testing
> -------
>
> Manually verified
>
> Precommit : https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/692/ (In Progress)
>
>
> Thanks,
>
> Pinal Shah
>
>
Re: Review Request 73431: ATLAS-4341 : Regression: DSL query with like
operator and regex expression does not work
Posted by Pinal Shah <pi...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73431/
-----------------------------------------------------------
(Updated June 22, 2021, 5:21 p.m.)
Review request for atlas, Ashutosh Mestry, Jayendra Parab, Nixon Rodrigues, and Sarath Subramanian.
Bugs: ATLAS-4341
https://issues.apache.org/jira/browse/ATLAS-4341
Repository: atlas
Description
-------
**Issue:**
hdfs_path having 5 entities with suffix 0 to 5
/api/atlas/v2/search/dsl?typeName=hdfs_path&query=name%20like%20%22hdfs_path_vzxtp_*%22
**Finds the result**
But
/api/atlas/v2/search/dsl?typeName=hdfs_path&query=name like "hdfs_path_vzxtp_[0-9]"
**Returns empty**
Diffs (updated)
-----
repository/src/main/java/org/apache/atlas/query/IdentifierHelper.java d2906ea40
repository/src/test/java/org/apache/atlas/query/DSLQueriesTest.java 3404dc6e2
Diff: https://reviews.apache.org/r/73431/diff/2/
Changes: https://reviews.apache.org/r/73431/diff/1-2/
Testing (updated)
-------
Manually verified
Precommit : https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/692/ (In Progress)
Thanks,
Pinal Shah