You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/10/29 09:15:04 UTC
[GitHub] [incubator-nuttx-apps] robertalexa2000 opened a new pull request, #1389: apps/ltr308: add simple application to test ltr308 sensor
robertalexa2000 opened a new pull request, #1389:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1389
Signed-off-by: Robert-Ionut Alexa <ro...@gmail.com>
## Summary
I have already opened a pull request for adding support for the LTR308 sensor. This commits provides a sample application for testing it.
## Impact
## Testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] robertalexa2000 commented on pull request #1389: apps/ltr308: add simple application to test ltr308 sensor
Posted by GitBox <gi...@apache.org>.
robertalexa2000 commented on PR #1389:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1389#issuecomment-1322420589
I'm closing this request and will open a new one later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #1389: apps/ltr308: add simple application to test ltr308 sensor
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #1389:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1389#issuecomment-1321765784
@robertalexa2000 do we still need this sample program after https://github.com/apache/incubator-nuttx/pull/7466 utilize the sensor framework?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] Donny9 commented on pull request #1389: apps/ltr308: add simple application to test ltr308 sensor
Posted by GitBox <gi...@apache.org>.
Donny9 commented on PR #1389:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1389#issuecomment-1295785413
@robertalexa2000 You can use uorb_listener tools to monitor light value if the driver of light register by sensor_register(driver/sensors/sensor.c)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] robertalexa2000 closed pull request #1389: apps/ltr308: add simple application to test ltr308 sensor
Posted by GitBox <gi...@apache.org>.
robertalexa2000 closed pull request #1389: apps/ltr308: add simple application to test ltr308 sensor
URL: https://github.com/apache/incubator-nuttx-apps/pull/1389
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] pkarashchenko commented on a diff in pull request #1389: apps/ltr308: add simple application to test ltr308 sensor
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #1389:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1389#discussion_r1008669539
##########
examples/ltr308/ltr308_main.c:
##########
@@ -0,0 +1,72 @@
+/****************************************************************************
+ * apps/examples/ltr308/ltr308_main.c
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ****************************************************************************/
+
+/****************************************************************************
+ * Included Files
+ ****************************************************************************/
+
+#include <nuttx/config.h>
+#include <nuttx/sensors/ioctl.h>
+#include <nuttx/sensors/ltr308.h>
+
+#include <stdio.h>
+#include <fcntl.h>
+#include <sys/ioctl.h>
+
+/****************************************************************************
+ * Public Functions
+ ****************************************************************************/
+
+/****************************************************************************
+ * ltr308_main
+ ****************************************************************************/
+
+int main(int argc, FAR char *argv[])
+{
+ struct ltr308_ctrl_s ctrl;
+ uint32_t data = 0;
+ int fd, ret;
+
+ fd = open("/dev/light0", O_RDONLY);
+ if (fd < 0)
+ {
+ perror("Could not open file");
+ return fd;
+ }
+
+ ctrl.reset = 0;
+ ctrl.enable = 1;
+ ret = ioctl(fd, SNIOC_SET_CTRL, &ctrl);
+ if (ret < 0)
+ {
+ perror("Failed to enable the sensors");
+ return ret;
Review Comment:
Close fd
##########
examples/ltr308/ltr308_main.c:
##########
@@ -0,0 +1,72 @@
+/****************************************************************************
+ * apps/examples/ltr308/ltr308_main.c
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ****************************************************************************/
+
+/****************************************************************************
+ * Included Files
+ ****************************************************************************/
+
+#include <nuttx/config.h>
+#include <nuttx/sensors/ioctl.h>
+#include <nuttx/sensors/ltr308.h>
+
+#include <stdio.h>
+#include <fcntl.h>
+#include <sys/ioctl.h>
+
+/****************************************************************************
+ * Public Functions
+ ****************************************************************************/
+
+/****************************************************************************
+ * ltr308_main
+ ****************************************************************************/
+
+int main(int argc, FAR char *argv[])
+{
+ struct ltr308_ctrl_s ctrl;
+ uint32_t data = 0;
+ int fd, ret;
+
+ fd = open("/dev/light0", O_RDONLY);
+ if (fd < 0)
+ {
+ perror("Could not open file");
+ return fd;
+ }
+
+ ctrl.reset = 0;
+ ctrl.enable = 1;
+ ret = ioctl(fd, SNIOC_SET_CTRL, &ctrl);
+ if (ret < 0)
+ {
+ perror("Failed to enable the sensors");
+ return ret;
+ }
+
+ ret = ioctl(fd, SNIOC_GET_DATA, &data);
+ if (ret < 0)
+ {
+ perror("Failed to get data");
+ return ret;
+ }
+
+ printf("Data: %x\n", data);
Review Comment:
Close fd
##########
examples/ltr308/ltr308_main.c:
##########
@@ -0,0 +1,72 @@
+/****************************************************************************
+ * apps/examples/ltr308/ltr308_main.c
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ****************************************************************************/
+
+/****************************************************************************
+ * Included Files
+ ****************************************************************************/
+
+#include <nuttx/config.h>
+#include <nuttx/sensors/ioctl.h>
+#include <nuttx/sensors/ltr308.h>
+
+#include <stdio.h>
+#include <fcntl.h>
+#include <sys/ioctl.h>
+
+/****************************************************************************
+ * Public Functions
+ ****************************************************************************/
+
+/****************************************************************************
+ * ltr308_main
+ ****************************************************************************/
+
+int main(int argc, FAR char *argv[])
+{
+ struct ltr308_ctrl_s ctrl;
+ uint32_t data = 0;
+ int fd, ret;
+
+ fd = open("/dev/light0", O_RDONLY);
+ if (fd < 0)
+ {
+ perror("Could not open file");
+ return fd;
+ }
+
+ ctrl.reset = 0;
+ ctrl.enable = 1;
+ ret = ioctl(fd, SNIOC_SET_CTRL, &ctrl);
+ if (ret < 0)
+ {
+ perror("Failed to enable the sensors");
+ return ret;
+ }
+
+ ret = ioctl(fd, SNIOC_GET_DATA, &data);
+ if (ret < 0)
+ {
+ perror("Failed to get data");
+ return ret;
Review Comment:
Close fd
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] robertalexa2000 commented on pull request #1389: apps/ltr308: add simple application to test ltr308 sensor
Posted by GitBox <gi...@apache.org>.
robertalexa2000 commented on PR #1389:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1389#issuecomment-1321771768
@xiaoxiang781216 I will update this with a new example that I used for testing and you can decide if we merge it or not. I think it might be useful to exemplify how to use the .calibrate callback
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #1389: apps/ltr308: add simple application to test ltr308 sensor
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #1389:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1389#issuecomment-1321932209
> @xiaoxiang781216 I will update this with a new example that I used for testing and you can decide if we merge it or not. I think it might be useful to exemplify how to use the .calibrate callback
Ok, let's merge your new patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org