You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Shajini Thayasingh (Code Review)" <ge...@cloudera.org> on 2021/06/07 18:02:48 UTC

[Impala-ASF-CR] IMPALA-10729: [DOCS] Document SHA1 and SHA2 functions

Shajini Thayasingh has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17551


Change subject: IMPALA-10729: [DOCS] Document SHA1 and SHA2 functions
......................................................................

IMPALA-10729: [DOCS] Document SHA1 and SHA2 functions

Introduced the new hash functions that were recently added.

Change-Id: I379de6075af2168715e71edfec26265b6ff5eab7
---
M docs/impala.ditamap
M docs/topics/impala_functions.xml
A docs/topics/impala_hash_functions.xml
3 files changed, 79 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/51/17551/1
-- 
To view, visit http://gerrit.cloudera.org:8080/17551
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I379de6075af2168715e71edfec26265b6ff5eab7
Gerrit-Change-Number: 17551
Gerrit-PatchSet: 1
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>

[Impala-ASF-CR] IMPALA-10729: [DOCS] Document SHA1 and SHA2 functions

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17551 )

Change subject: IMPALA-10729: [DOCS] Document SHA1 and SHA2 functions
......................................................................


Patch Set 3:

Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/764/ 

Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317


-- 
To view, visit http://gerrit.cloudera.org:8080/17551
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I379de6075af2168715e71edfec26265b6ff5eab7
Gerrit-Change-Number: 17551
Gerrit-PatchSet: 3
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Amogh Margoor <am...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 29 Apr 2024 19:37:13 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10729: [DOCS] Document SHA1 and SHA2 functions

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has uploaded a new patch set (#3) to the change originally created by Shajini Thayasingh. ( http://gerrit.cloudera.org:8080/17551 )

Change subject: IMPALA-10729: [DOCS] Document SHA1 and SHA2 functions
......................................................................

IMPALA-10729: [DOCS] Document SHA1 and SHA2 functions

Introduced the new hash functions that were recently added.

Change-Id: I379de6075af2168715e71edfec26265b6ff5eab7
---
M docs/impala.ditamap
M docs/topics/impala_functions.xml
A docs/topics/impala_hash_functions.xml
3 files changed, 79 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/51/17551/3
-- 
To view, visit http://gerrit.cloudera.org:8080/17551
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I379de6075af2168715e71edfec26265b6ff5eab7
Gerrit-Change-Number: 17551
Gerrit-PatchSet: 3
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Amogh Margoor <am...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>

[Impala-ASF-CR] IMPALA-10729: [DOCS] Document SHA1 and SHA2 functions

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17551 )

Change subject: IMPALA-10729: [DOCS] Document SHA1 and SHA2 functions
......................................................................


Patch Set 3: Verified+1

Build Successful 

https://jenkins.impala.io/job/gerrit-docs-auto-test/764/ : Doc tests passed.


-- 
To view, visit http://gerrit.cloudera.org:8080/17551
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I379de6075af2168715e71edfec26265b6ff5eab7
Gerrit-Change-Number: 17551
Gerrit-PatchSet: 3
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Amogh Margoor <am...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 29 Apr 2024 19:46:38 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10729: [DOCS] Document SHA1 and SHA2 functions

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17551 )

Change subject: IMPALA-10729: [DOCS] Document SHA1 and SHA2 functions
......................................................................


Patch Set 1:

Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/635/ 

Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317


-- 
To view, visit http://gerrit.cloudera.org:8080/17551
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I379de6075af2168715e71edfec26265b6ff5eab7
Gerrit-Change-Number: 17551
Gerrit-PatchSet: 1
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 07 Jun 2021 18:02:59 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10729: [DOCS] Document SHA1 and SHA2 functions

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17551 )

Change subject: IMPALA-10729: [DOCS] Document SHA1 and SHA2 functions
......................................................................


Patch Set 1: Verified+1

Build Successful 

https://jenkins.impala.io/job/gerrit-docs-auto-test/635/ : Doc tests passed.


-- 
To view, visit http://gerrit.cloudera.org:8080/17551
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I379de6075af2168715e71edfec26265b6ff5eab7
Gerrit-Change-Number: 17551
Gerrit-PatchSet: 1
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 07 Jun 2021 18:10:43 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10729: [DOCS] Document SHA1 and SHA2 functions

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/17551 )

Change subject: IMPALA-10729: [DOCS] Document SHA1 and SHA2 functions
......................................................................


Patch Set 3:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/17551/1/docs/topics/impala_functions.xml
File docs/topics/impala_functions.xml:

http://gerrit.cloudera.org:8080/#/c/17551/1/docs/topics/impala_functions.xml@70
PS1, Line 70: 
Unnecessary indentation here. I cleaned it up.


http://gerrit.cloudera.org:8080/#/c/17551/3/docs/topics/impala_functions.xml
File docs/topics/impala_functions.xml:

http://gerrit.cloudera.org:8080/#/c/17551/3/docs/topics/impala_functions.xml@100
PS3, Line 100:     <table id="impala_functions" frame="none" colsep="0" rowsep="0">
It looks like we normally also add links to all functions in this table.



-- 
To view, visit http://gerrit.cloudera.org:8080/17551
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I379de6075af2168715e71edfec26265b6ff5eab7
Gerrit-Change-Number: 17551
Gerrit-PatchSet: 3
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Amogh Margoor <am...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 29 Apr 2024 19:39:48 +0000
Gerrit-HasComments: Yes