You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by Ian Boston <ie...@tfd.co.uk> on 2008/07/23 21:39:34 UTC
Re: svn commit: r679109 - in /incubator/shindig/trunk: java/social-api/src/main/java/org/apache/shindig/social/ java/social-api/src/main/java/org/apache/shindig/social/core/config/ java/social-api/src/main/java/org/apache/shindig/social/core/model/ j
Do we want the TODO's in check style or in the list of Tags ?
I wasn't certain, so I left it there commented out.
Happy to remove.
Ian
On 23 Jul 2008, at 20:32, Cassie wrote:
>> - <module name="TodoComment"/>
>> +<!--
>> + <module name="TodoComment">
>> + <property name="severity" value="info"/>
>> + </module>
>> +-->
>
> why add this commented out portion?
Re: svn commit: r679109 - in /incubator/shindig/trunk:
java/social-api/src/main/java/org/apache/shindig/social/ java/social-api/src/main/java/org/apache/shindig/social/core/config/
java/social-api/src/main/java/org/apache/shindig/social/core/model/ j
Posted by Cassie <do...@google.com>.
Oh I see, the standard place definitely seems right then.
On Wed, Jul 23, 2008 at 12:49 PM, Ian Boston <ie...@tfd.co.uk> wrote:
> There are 2 places the TODO's can be recorded
> either in the CheckStyle report, or in the Tags report.
>
> The Tags report is a more standard place to record TODO ( and other things
> like FIXME), as they tend to get lots where there are a log of check style
> issues.
>
> So, I wasnt certain if we want to record TODO's as a style issue or not ?
>
> (I am being confusing towards the end of the day here :), if it makes no
> sense just ask me to remove it, and I will.)
>
> Ian
>
> On 23 Jul 2008, at 20:42, Cassie wrote:
>
> Sorry for my slowness but I'm slightly confused by your question.
>> We should probably check the TODO style, is that what you are asking?
>>
>> - Cassie
>>
>>
>> On Wed, Jul 23, 2008 at 12:39 PM, Ian Boston <ie...@tfd.co.uk> wrote:
>>
>> Do we want the TODO's in check style or in the list of Tags ?
>>>
>>> I wasn't certain, so I left it there commented out.
>>>
>>> Happy to remove.
>>>
>>> Ian
>>>
>>> On 23 Jul 2008, at 20:32, Cassie wrote:
>>>
>>> - <module name="TodoComment"/>
>>>
>>>> +<!--
>>>>> + <module name="TodoComment">
>>>>> + <property name="severity" value="info"/>
>>>>> + </module>
>>>>> +-->
>>>>>
>>>>>
>>>> why add this commented out portion?
>>>>
>>>>
>>>
>>>
>
Re: svn commit: r679109 - in /incubator/shindig/trunk: java/social-api/src/main/java/org/apache/shindig/social/ java/social-api/src/main/java/org/apache/shindig/social/core/config/ java/social-api/src/main/java/org/apache/shindig/social/core/model/ j
Posted by Ian Boston <ie...@tfd.co.uk>.
There are 2 places the TODO's can be recorded
either in the CheckStyle report, or in the Tags report.
The Tags report is a more standard place to record TODO ( and other
things like FIXME), as they tend to get lots where there are a log of
check style issues.
So, I wasnt certain if we want to record TODO's as a style issue or
not ?
(I am being confusing towards the end of the day here :), if it makes
no sense just ask me to remove it, and I will.)
Ian
On 23 Jul 2008, at 20:42, Cassie wrote:
> Sorry for my slowness but I'm slightly confused by your question.
> We should probably check the TODO style, is that what you are asking?
>
> - Cassie
>
>
> On Wed, Jul 23, 2008 at 12:39 PM, Ian Boston <ie...@tfd.co.uk> wrote:
>
>> Do we want the TODO's in check style or in the list of Tags ?
>>
>> I wasn't certain, so I left it there commented out.
>>
>> Happy to remove.
>>
>> Ian
>>
>> On 23 Jul 2008, at 20:32, Cassie wrote:
>>
>> - <module name="TodoComment"/>
>>>> +<!--
>>>> + <module name="TodoComment">
>>>> + <property name="severity" value="info"/>
>>>> + </module>
>>>> +-->
>>>>
>>>
>>> why add this commented out portion?
>>>
>>
>>
Re: svn commit: r679109 - in /incubator/shindig/trunk: java/social-api/src/main/java/org/apache/shindig/social/ java/social-api/src/main/java/org/apache/shindig/social/core/config/ java/social-api/src/main/java/org/apache/shindig/social/core/model/ j
Posted by Ian Boston <ie...@tfd.co.uk>.
Oh and BTW, sorry for the deluge of commits, there wont be any more
today unless I have need to fix things that I have broken. I thought
it was a quiet opportunity after the refractor. I have nothing
pending here.
Ian
On 23 Jul 2008, at 20:42, Cassie wrote:
> Sorry for my slowness but I'm slightly confused by your question.
> We should probably check the TODO style, is that what you are asking?
>
> - Cassie
>
>
> On Wed, Jul 23, 2008 at 12:39 PM, Ian Boston <ie...@tfd.co.uk> wrote:
>
>> Do we want the TODO's in check style or in the list of Tags ?
>>
>> I wasn't certain, so I left it there commented out.
>>
>> Happy to remove.
>>
>> Ian
>>
>> On 23 Jul 2008, at 20:32, Cassie wrote:
>>
>> - <module name="TodoComment"/>
>>>> +<!--
>>>> + <module name="TodoComment">
>>>> + <property name="severity" value="info"/>
>>>> + </module>
>>>> +-->
>>>>
>>>
>>> why add this commented out portion?
>>>
>>
>>
Re: svn commit: r679109 - in /incubator/shindig/trunk:
java/social-api/src/main/java/org/apache/shindig/social/ java/social-api/src/main/java/org/apache/shindig/social/core/config/
java/social-api/src/main/java/org/apache/shindig/social/core/model/ j
Posted by Cassie <do...@google.com>.
Sorry for my slowness but I'm slightly confused by your question.
We should probably check the TODO style, is that what you are asking?
- Cassie
On Wed, Jul 23, 2008 at 12:39 PM, Ian Boston <ie...@tfd.co.uk> wrote:
> Do we want the TODO's in check style or in the list of Tags ?
>
> I wasn't certain, so I left it there commented out.
>
> Happy to remove.
>
> Ian
>
> On 23 Jul 2008, at 20:32, Cassie wrote:
>
> - <module name="TodoComment"/>
>>> +<!--
>>> + <module name="TodoComment">
>>> + <property name="severity" value="info"/>
>>> + </module>
>>> +-->
>>>
>>
>> why add this commented out portion?
>>
>
>