[jira] [Work logged] (BEAM-11985) Python Bigtable - Implement IO Request Count metrics

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/BEAM-11985?focusedWorklogId=702817&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-702817 ]

ASF GitHub Bot logged work on BEAM-11985:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 02/Jan/22 19:36
            Start Date: 02/Jan/22 19:36
    Worklog Time Spent: 10m 
      Work Description: rashidjeffreysky commented on pull request #15562:
URL: https://github.com/apache/beam/pull/15562#issuecomment-1003764345


   Hi everyone,
   
   We are seeing errors which _possibly_ originate from this code:
   
   `def write_mutate_metrics(self, rows):
       for status in rows:
         grpc_status_string = (
             ServiceCallMetric.bigtable_error_code_to_grpc_status_string(
                 status.code))
         self.service_call_metric.call(grpc_status_string)
   `
   
   Error message:
   `
   File "/usr/local/lib/python3.6/site-packages/apache_beam/io/gcp/bigtableio.py", line 123, in write_mutate_metrics status.code))
   AttributeError: 'NoneType' object has no attribute 'code' [while running 'Write event Bigtable row/ParDo(_BigTableWriteFn)-ptransform-58134']
   `
   
   Would you have any idea about this issue? 
   
   
   In addition, the choice of parameter name (rows) is confusing. Perhaps something like responses or response_list ?
   https://cloud.google.com/bigtable/docs/writing-data#batch
   https://googleapis.dev/python/bigtable/1.3.0/_modules/google/cloud/bigtable/table.html#Table.mutate_rows
   
   Thank you for your time.
   
   Regards
   Rashid
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 702817)
    Time Spent: 8h 40m  (was: 8.5h)

> Python Bigtable - Implement IO Request Count metrics
> ----------------------------------------------------
>
>                 Key: BEAM-11985
>                 URL: https://issues.apache.org/jira/browse/BEAM-11985
>             Project: Beam
>          Issue Type: Test
>          Components: io-py-gcp
>            Reporter: Alex Amato
>            Assignee: Benjamin Gonzalez
>            Priority: P3
>          Time Spent: 8h 40m
>  Remaining Estimate: 0h
>
> Reference PRs (See BigQuery IO example) and detailed explanation of what's needed to instrument this IO with Request Count metrics is found in this handoff doc:
> [https://docs.google.com/document/d/1lrz2wE5Dl4zlUfPAenjXIQyleZvqevqoxhyE85aj4sc/edit'|https://docs.google.com/document/d/1lrz2wE5Dl4zlUfPAenjXIQyleZvqevqoxhyE85aj4sc/edit'?authuser=0]



--
This message was sent by Atlassian Jira
(v8.20.1#820001)