You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by patricker <gi...@git.apache.org> on 2018/06/29 14:37:55 UTC
[GitHub] nifi pull request #2824: NIFI-5339 - Better Time Tracking for ExecuteSQL Dur...
GitHub user patricker opened a pull request:
https://github.com/apache/nifi/pull/2824
NIFI-5339 - Better Time Tracking for ExecuteSQL Durations
@pvillard31 I forgot to add in the `WritesAttribute` annotations for the new attributes on NIFI-5339.
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/patricker/nifi NIFI-5339
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2824.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2824
----
commit 8c3775e09ea0cacab2cc16f7a1b2baa92095d8a3
Author: patricker <pa...@...>
Date: 2018-06-26T19:27:11Z
NIFI-5339
commit 1e41e1521c881fd12752734686d86820bf7defca
Author: patricker <pa...@...>
Date: 2018-06-29T14:33:51Z
NIFI-5339
----
---
[GitHub] nifi issue #2824: NIFI-5339 - Better Time Tracking for ExecuteSQL Durations
Posted by pvillard31 <gi...@git.apache.org>.
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2824
Merged, thanks @patricker
---
[GitHub] nifi pull request #2824: NIFI-5339 - Better Time Tracking for ExecuteSQL Dur...
Posted by pvillard31 <gi...@git.apache.org>.
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2824#discussion_r199181403
--- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ExecuteSQL.java ---
@@ -93,6 +93,8 @@
@WritesAttributes({
@WritesAttribute(attribute="executesql.row.count", description = "Contains the number of rows returned in the select query"),
@WritesAttribute(attribute="executesql.query.duration", description = "Duration of the query in milliseconds"),
--- End diff --
Update this description to say it's the addition of query execution and fetch time?
---
[GitHub] nifi pull request #2824: NIFI-5339 - Better Time Tracking for ExecuteSQL Dur...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/2824
---
[GitHub] nifi pull request #2824: NIFI-5339 - Better Time Tracking for ExecuteSQL Dur...
Posted by patricker <gi...@git.apache.org>.
Github user patricker commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2824#discussion_r199182375
--- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ExecuteSQL.java ---
@@ -93,6 +93,8 @@
@WritesAttributes({
@WritesAttribute(attribute="executesql.row.count", description = "Contains the number of rows returned in the select query"),
@WritesAttribute(attribute="executesql.query.duration", description = "Duration of the query in milliseconds"),
--- End diff --
Updated.
---