You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "dlmarion (via GitHub)" <gi...@apache.org> on 2024/02/13 13:49:10 UTC
[PR] Removed contrib/getting-started/.gitignore, updated contrib/.gitignore [accumulo-access]
dlmarion opened a new pull request, #48:
URL: https://github.com/apache/accumulo-access/pull/48
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Removed contrib/getting-started/.gitignore, updated contrib/.gitignore [accumulo-access]
Posted by "ddanielr (via GitHub)" <gi...@apache.org>.
ddanielr commented on code in PR #48:
URL: https://github.com/apache/accumulo-access/pull/48#discussion_r1488160538
##########
contrib/.gitignore:
##########
@@ -31,3 +30,17 @@
/antlr4/nb-configuration.xml
/antlr4/.vscode/
/antlr4/.factorypath
+/getting-started/target/
Review Comment:
> I don't know if `target/` will get the subdirectories, or if it needs to be something like `**/target/`.
`target/` will get the subdirectories.
I just tested that by removing the `contrib/.gitignore` file and running `mvn clean package` in `accumulo-access/contrib/antlr4`.
The `accumulo-access/contrib/antlr4/target` directory showed up under untracked files.
I then modified the entry in the `accumulo-access/.gitignore` from `/target/` to `target/` and my `accumulo-access/contrib/antlr4/target` directory and contents were successfully ignored.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Removed contrib/getting-started/.gitignore, updated contrib/.gitignore [accumulo-access]
Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion commented on PR #48:
URL: https://github.com/apache/accumulo-access/pull/48#issuecomment-1941561774
contrib/getting-started/.gitignore is missing a license header. Resolved this by removing the file and updating the .gitignore file at a higher level in the directory hierarchy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Removed contrib/getting-started/.gitignore, updated contrib/.gitignore [accumulo-access]
Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion commented on code in PR #48:
URL: https://github.com/apache/accumulo-access/pull/48#discussion_r1488136099
##########
contrib/.gitignore:
##########
@@ -31,3 +30,17 @@
/antlr4/nb-configuration.xml
/antlr4/.vscode/
/antlr4/.factorypath
+/getting-started/target/
Review Comment:
I don't know if `target/` will get the subdirectories, or if it needs to be something like `**/target/`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Removed contrib/getting-started/.gitignore, updated contrib/.gitignore [accumulo-access]
Posted by "ddanielr (via GitHub)" <gi...@apache.org>.
ddanielr commented on PR #48:
URL: https://github.com/apache/accumulo-access/pull/48#issuecomment-1941866069
You could also remove `contrib/.gitignore` updating the entries in the repo's root .gitignore file to not be directory specific. This would remove the need for the duplicate entries in `contrib/.gitignore`
```
# Maven ignores
target/
# IDE ignores
.settings/
.project
.classpath
.pydevproject
.idea
*.iml
*.ipr
*.iws
nbproject/
nbactions.xml
nb-configuration.xml
.vscode/
.factorypath
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Removed contrib/getting-started/.gitignore, updated contrib/.gitignore [accumulo-access]
Posted by "DomGarguilo (via GitHub)" <gi...@apache.org>.
DomGarguilo commented on code in PR #48:
URL: https://github.com/apache/accumulo-access/pull/48#discussion_r1487998088
##########
contrib/.gitignore:
##########
@@ -31,3 +30,17 @@
/antlr4/nb-configuration.xml
/antlr4/.vscode/
/antlr4/.factorypath
+/getting-started/target/
Review Comment:
If we wanted to ignore any target directories couldn't we just add `target/` to cover that? This applies to other entries here too. I am also not certain that we do want to cover all directories with these name, just wanted to point this out/ask about it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Removed contrib/getting-started/.gitignore, updated contrib/.gitignore [accumulo-access]
Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion commented on code in PR #48:
URL: https://github.com/apache/accumulo-access/pull/48#discussion_r1488187776
##########
contrib/.gitignore:
##########
@@ -31,3 +30,17 @@
/antlr4/nb-configuration.xml
/antlr4/.vscode/
/antlr4/.factorypath
+/getting-started/target/
Review Comment:
I removed the .gitignore files in contrib/ and updated the parent .gitignore to remove the leading `/` characters so that it would match at all levels
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Removed contrib/getting-started/.gitignore, updated contrib/.gitignore [accumulo-access]
Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion merged PR #48:
URL: https://github.com/apache/accumulo-access/pull/48
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Removed contrib/getting-started/.gitignore, updated contrib/.gitignore [accumulo-access]
Posted by "DomGarguilo (via GitHub)" <gi...@apache.org>.
DomGarguilo commented on code in PR #48:
URL: https://github.com/apache/accumulo-access/pull/48#discussion_r1488145774
##########
contrib/.gitignore:
##########
@@ -31,3 +30,17 @@
/antlr4/nb-configuration.xml
/antlr4/.vscode/
/antlr4/.factorypath
+/getting-started/target/
Review Comment:
Im pretty sure it will catch subdirectories too. [Found this that says as much](https://stackoverflow.com/questions/1470572/ignoring-any-bin-directory-on-a-git-project).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Removed contrib/getting-started/.gitignore, updated contrib/.gitignore [accumulo-access]
Posted by "ctubbsii (via GitHub)" <gi...@apache.org>.
ctubbsii commented on code in PR #48:
URL: https://github.com/apache/accumulo-access/pull/48#discussion_r1488165053
##########
contrib/.gitignore:
##########
@@ -31,3 +30,17 @@
/antlr4/nb-configuration.xml
/antlr4/.vscode/
/antlr4/.factorypath
+/getting-started/target/
Review Comment:
If you do /target/, then it will only work at the root.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Removed contrib/getting-started/.gitignore, updated contrib/.gitignore [accumulo-access]
Posted by "ctubbsii (via GitHub)" <gi...@apache.org>.
ctubbsii commented on code in PR #48:
URL: https://github.com/apache/accumulo-access/pull/48#discussion_r1488162898
##########
contrib/.gitignore:
##########
@@ -31,3 +30,17 @@
/antlr4/nb-configuration.xml
/antlr4/.vscode/
/antlr4/.factorypath
+/getting-started/target/
Review Comment:
Just target/ is fine. Look at Accumulo's.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org