You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "blerer (via GitHub)" <gi...@apache.org> on 2023/06/06 13:01:50 UTC
[GitHub] [cassandra] blerer commented on a diff in pull request #1286: CASSANDRA-17047(trunk): Fix queries for DROP column when schema propagation takes time
blerer commented on code in PR #1286:
URL: https://github.com/apache/cassandra/pull/1286#discussion_r1219611017
##########
src/java/org/apache/cassandra/db/filter/ColumnFilter.java:
##########
@@ -1043,28 +1072,50 @@ public ColumnFilter deserialize(DataInputPlus in, int version, TableMetadata met
// is assumed that all columns are queried.
if (!hasQueried || isUpgradingFromVersionLowerThan34())
{
- return new WildCardColumnFilter(fetched);
- }
-
- // pre CASSANDRA-12768 (4.0-) all static columns should be fetched along with all regular columns.
- if (isUpgradingFromVersionLowerThan40())
- {
- return new SelectionColumnFilter(FetchingStrategy.ALL_COLUMNS, queried, fetched, subSelections);
+ return hasNoExtraStaticColumns && hasNoExtraRegularColumns ? new WildCardColumnFilter(fetched)
+ : new SelectionColumnFilter(FetchingStrategy.FETCHED_COLUMNS, fetched, fetched, subSelections);
Review Comment:
It would work but that is not the case in which ONLY_QUERIED_COLUMNS should be use so for somebody debugging the system it would be really confusing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org