You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@tinkerpop.apache.org by spmallette <gi...@git.apache.org> on 2016/02/09 17:25:37 UTC

[GitHub] incubator-tinkerpop pull request: TINKERPOP-916 Provide more robus...

GitHub user spmallette opened a pull request:

    https://github.com/apache/incubator-tinkerpop/pull/216

    TINKERPOP-916 Provide more robust SimpleClient implementations.

    https://issues.apache.org/jira/browse/TINKERPOP-916
    
    These implementations provide for a no-frills way to test Gremlin Server. Added methods to collect all messages returned from the server as opposed to just capturing messages via callback.  Updated all integration tests that were using the old methods.
    
    Tested with: `mvn clean install && mvn verify -pl gremlin-server -DskipIntegrationTests=false`
    
    VOTE: +1

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/incubator-tinkerpop TINKERPOP-916

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-tinkerpop/pull/216.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #216
    
----
commit 30bfe3edaed6b8e93751a90c22c53650f321971e
Author: Stephen Mallette <sp...@genoprime.com>
Date:   2016-02-04T20:42:15Z

    Provide more robust SimpleClient implementations.
    
    These implementations provide for a no-frills way to test Gremlin Server. Added methods to collect all messages returned from the server as opposed to just capturing messages via callback.  Updated all integration tests that were using the old methods.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-tinkerpop pull request: TINKERPOP-916 Provide more robus...

Posted by dkuppitz <gi...@git.apache.org>.

Github user dkuppitz commented on the pull request:

    https://github.com/apache/incubator-tinkerpop/pull/216#issuecomment-182528791
  
    * `mvn clean install`: passed
    * integration tests: passed
    
    Code looks good.
    
    VOTE: +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-tinkerpop pull request: TINKERPOP-916 Provide more robus...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-tinkerpop/pull/216


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-tinkerpop pull request: TINKERPOP-916 Provide more robus...

Posted by okram <gi...@git.apache.org>.

Github user okram commented on the pull request:

    https://github.com/apache/incubator-tinkerpop/pull/216#issuecomment-182114510
  
    I ran `mvn clean install`. All good. VOTE +1.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---