You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "svetakvsundhar (via GitHub)" <gi...@apache.org> on 2023/05/24 20:28:36 UTC

[GitHub] [beam] svetakvsundhar opened a new issue, #26877: [Task][Clean-Up]: Create `Healthcare` Directory under Python SDK IOs

svetakvsundhar opened a new issue, #26877:
URL: https://github.com/apache/beam/issues/26877

   ### What needs to happen?
   
   To mirror what we have in the Java IOs [1], we should create a new directory under [2], and add the DICOM Python IO. This will make the codebase readability cleaner and give a location for folks to add more healthcare IOs in Python if the need arises.
   
   
   
   [1]
   https://github.com/apache/beam/tree/master/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare
   
   [2]
   https://github.com/apache/beam/tree/master/sdks/python/apache_beam/io/gcp
   
   ### Issue Priority
   
   Priority: 3 (nice-to-have improvement)
   
   ### Issue Components
   
   - [ ] Component: Python SDK
   - [ ] Component: Java SDK
   - [ ] Component: Go SDK
   - [ ] Component: Typescript SDK
   - [X] Component: IO connector
   - [ ] Component: Beam examples
   - [ ] Component: Beam playground
   - [ ] Component: Beam katas
   - [ ] Component: Website
   - [ ] Component: Spark Runner
   - [ ] Component: Flink Runner
   - [ ] Component: Samza Runner
   - [ ] Component: Twister2 Runner
   - [ ] Component: Hazelcast Jet Runner
   - [ ] Component: Google Cloud Dataflow Runner


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] svetakvsundhar commented on issue #26877: [Task][Clean-Up]: Create `Healthcare` Directory under Python SDK IOs

Posted by "svetakvsundhar (via GitHub)" <gi...@apache.org>.
svetakvsundhar commented on issue #26877:
URL: https://github.com/apache/beam/issues/26877#issuecomment-1561885790

   .take-issue


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] svetakvsundhar commented on issue #26877: [Task][Clean-Up]: Create `Healthcare` Directory under Python SDK IOs

Posted by "svetakvsundhar (via GitHub)" <gi...@apache.org>.
svetakvsundhar commented on issue #26877:
URL: https://github.com/apache/beam/issues/26877#issuecomment-1561885664

   cc: @ahmedabu98 @Abacn @johnjcasey if you are ok with this, I will put up a PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] svetakvsundhar commented on issue #26877: [Task][Clean-Up]: Create `Healthcare` Directory under Python SDK IOs

Posted by "svetakvsundhar (via GitHub)" <gi...@apache.org>.
svetakvsundhar commented on issue #26877:
URL: https://github.com/apache/beam/issues/26877#issuecomment-1561963873

   Offline discussion with @Abacn : 
   
   The new team I just joined leverages the Healthcare Connectors and so moving these under a healthcare folder will help reduce tech debt in case we contribute Python specific connectors in the future.
   
   We could do what was done in [1] to avoid breaking changes.
   
   cc: @tvalentyn 
   
   [1]
   https://github.com/apache/beam/blob/master/sdks/python/apache_beam/io/external/kafka.py


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] tvalentyn commented on issue #26877: [Task][Clean-Up]: Create `Healthcare` Directory under Python SDK IOs

Posted by "tvalentyn (via GitHub)" <gi...@apache.org>.
tvalentyn commented on issue #26877:
URL: https://github.com/apache/beam/issues/26877#issuecomment-1563517346

   i don't have a strong opinion, but yes we should pay attention to not make breaking changes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] tvalentyn closed issue #26877: [Task][Clean-Up]: Create `Healthcare` Directory under Python SDK IOs

Posted by "tvalentyn (via GitHub)" <gi...@apache.org>.
tvalentyn closed issue #26877: [Task][Clean-Up]: Create `Healthcare` Directory under Python SDK IOs
URL: https://github.com/apache/beam/issues/26877


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Abacn commented on issue #26877: [Task][Clean-Up]: Create `Healthcare` Directory under Python SDK IOs

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on issue #26877:
URL: https://github.com/apache/beam/issues/26877#issuecomment-1561937571

   Yeah In Java each gcp component has its own package (bigquery/bigtable/healthcare etc) but for Python, for now, most are all in gcp (exception is pubsublite which is an external transform) moving healthcare alone does not improve the situation much
   
   and in general I feel like Python modules tends to have fewer layer. Not sure if this was language convention. We moved kafka connector from apache_beam.io.external to apache_beam.io before
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] johnjcasey commented on issue #26877: [Task][Clean-Up]: Create `Healthcare` Directory under Python SDK IOs

Posted by "johnjcasey (via GitHub)" <gi...@apache.org>.
johnjcasey commented on issue #26877:
URL: https://github.com/apache/beam/issues/26877#issuecomment-1564449398

   Agreed on better factoring of connectors.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org