[PATCH] NT CGI fix env var problem

[W G Stoddard <wg...@us.ibm.com>]

Here is a patch for the environment variable passing problem introduced in NT
1.3b7.
Ref PR2294
Bill Stoddard





Users of the Apache webserver are hereby granted a non-exclusive, irrevocable,
world-wide, royalty-free, non-transferable license to use, execute, prepare
derivative works of, and distribute (internally and externally, and including
derivative works) the code accompanying this license as part of, and integrated
into the Apache webserver.

This code is provided "AS IS" WITHOUT WARRANTY OF ANY KIND EITHER EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE IMPLIED WARRANTY OF MERCHANTABILITY
AND FITNESS FOR A PARTICULAR PURPOSE.  THE ENTIRE RISK ARISING OUT OF THE USE
OR PERFORMANCE OF THIS CODE REMAINS WITH USERS OF THE APACHE WEBSERVER.

I represent and warrant that I am legally entitled to grant the above license.

Re: [PATCH] NT CGI fix env var problem

[Ben Laurie <be...@algroup.co.uk>]

W G Stoddard wrote:
> 
> Here is a patch for the environment variable passing problem introduced in NT
> 1.3b7.
> Ref PR2294
> Bill Stoddard

Just a minor nit, but it'd be nice if you'd include the patches in a way
which made them viewable inline instead of having to save them out
first. Presumably giving the attachment a more sensible type that
application/octet-stream might achieve that.

Cheers,

Ben.


-- 
Ben Laurie            |Phone: +44 (181) 735 0686|  Apache Group member
Freelance Consultant  |Fax:   +44 (181) 735 0689|http://www.apache.org
and Technical Director|Email: ben@algroup.co.uk |
A.L. Digital Ltd,     |Apache-SSL author    http://www.apache-ssl.org/
London, England.      |"Apache: TDG" http://www.ora.com/catalog/apache

Re: [PATCH] NT CGI fix env var problem

[Dirk-Willem van Gulik <di...@jrc.it>]

On Thu, 28 May 1998, Brian Behlendorf wrote:

> >Here is a patch for the environment variable passing problem introduced in NT
> >Ref PR2294

> This looks good, I'm about to commit it.  The strcpy looks safe to me, too.

+0 Does not break here. But unsure how 'safe' it is in concept ;-) But I
   never understood the NT model anyway.

>  I'll also put in the NT chdir() fix in a separate commit.

+1 That one works for me.

Dw

Re: [PATCH] NT CGI fix env var problem

[Brian Behlendorf <br...@hyperreal.org>]

At 11:01 AM 5/28/98 -0400, W G Stoddard wrote:
>Here is a patch for the environment variable passing problem introduced in NT
>1.3b7.
>Ref PR2294
>Bill Stoddard

This looks good, I'm about to commit it.  The strcpy looks safe to me, too.
 I'll also put in the NT chdir() fix in a separate commit.

By the way folks, what looks like indentation munging in the patch is
actually conversion of tabs to spaces, which is what the style guide says
is the right thing to do.  I'd do more cleanup but it's not necessary at
this point.

	Brian


--=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=--
pure chewing satisfaction                                  brian@apache.org
                                                        brian@hyperreal.org